* [bug report] net: wwan: t7xx: Data path HW layer
@ 2022-05-17 11:49 Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2022-05-17 11:49 UTC (permalink / raw)
To: haijun.liu; +Cc: linux-mediatek
Hello Haijun Liu,
The patch 33f78ab5a38a: "net: wwan: t7xx: Data path HW layer" from
May 6, 2022, leads to the following Smatch static checker warning:
drivers/net/wwan/t7xx/t7xx_dpmaif.c:1054 t7xx_dl_add_timedout()
warn: signedness bug returning '(-110)'
drivers/net/wwan/t7xx/t7xx_dpmaif.c
1046 static bool t7xx_dl_add_timedout(struct dpmaif_hw_info *hw_info)
^^^^
1047 {
1048 u32 value;
1049 int ret;
1050
1051 ret = ioread32_poll_timeout_atomic(hw_info->pcie_base + DPMAIF_DL_BAT_ADD,
1052 value, !(value & DPMAIF_DL_ADD_NOT_READY), 0,
1053 DPMAIF_CHECK_TIMEOUT_US);
--> 1054 return ret;
Returning negative error codes to bool is non-standard but, in this
case, harmless.
1055 }
regards,
dan carpenter
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2022-05-17 11:49 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-05-17 11:49 [bug report] net: wwan: t7xx: Data path HW layer Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).