From: Mark Brown <broonie@kernel.org>
To: Jiaxin Yu <jiaxin.yu@mediatek.com>
Cc: robh+dt@kernel.org, angelogioacchino.delregno@collabora.com,
aaronyu@google.com, matthias.bgg@gmail.com,
trevor.wu@mediatek.com, tzungbi@google.com,
julianbraha@gmail.com, alsa-devel@alsa-project.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
Project_Global_Chrome_Upstream_Group@mediatek.com
Subject: Re: [PATCH v5 19/20] ASoC: mediatek: mt8186: add machine driver with mt6366, rt1019 and rt5682s
Date: Mon, 6 Jun 2022 17:08:35 +0100 [thread overview]
Message-ID: <Yp4mg3ObzfQJ3FgP@sirena.org.uk> (raw)
In-Reply-To: <20220523132858.22166-20-jiaxin.yu@mediatek.com>
[-- Attachment #1.1: Type: text/plain, Size: 3555 bytes --]
On Mon, May 23, 2022 at 09:28:57PM +0800, Jiaxin Yu wrote:
> Add support for mt8186 board with mt6366, rt1019 and rt5682s.
>
> Signed-off-by: Jiaxin Yu <jiaxin.yu@mediatek.com>
This breaks an x86 allmodconfig build:
/build/stage/linux/sound/soc/mediatek/mt8186/mt8186-mt6366-da7219-max98357.c: In function ‘mt8186_da7219_init’:
/build/stage/linux/sound/soc/mediatek/mt8186/mt8186-mt6366-da7219-max98357.c:58:15: error: too many arguments to function ‘snd_soc_card_jack_new’
58 | ret = snd_soc_card_jack_new(rtd->card, "Headset Jack",
| ^~~~~~~~~~~~~~~~~~~~~
In file included from /build/stage/linux/include/sound/soc.h:1362,
from /build/stage/linux/sound/soc/mediatek/mt8186/mt8186-mt6366-da7219-max98357.c:15:
/build/stage/linux/include/sound/soc-card.h:18:5: note: declared here
18 | int snd_soc_card_jack_new(struct snd_soc_card *card, const char *id, int type,
| ^~~~~~~~~~~~~~~~~~~~~
/build/stage/linux/sound/soc/mediatek/mt8186/mt8186-mt6366-da7219-max98357.c: In function ‘mt8186_mt6366_da7219_max98357_hdmi_init’:
/build/stage/linux/sound/soc/mediatek/mt8186/mt8186-mt6366-da7219-max98357.c:161:15: error: too many arguments to function ‘snd_soc_card_jack_new’
161 | ret = snd_soc_card_jack_new(rtd->card, "HDMI Jack", SND_JACK_LINEOUT,
| ^~~~~~~~~~~~~~~~~~~~~
In file included from /build/stage/linux/include/sound/soc.h:1362,
from /build/stage/linux/sound/soc/mediatek/mt8186/mt8186-mt6366-da7219-max98357.c:15:
/build/stage/linux/include/sound/soc-card.h:18:5: note: declared here
18 | int snd_soc_card_jack_new(struct snd_soc_card *card, const char *id, int type,
| ^~~~~~~~~~~~~~~~~~~~~
make[5]: *** [/build/stage/linux/scripts/Makefile.build:249: sound/soc/mediatek/mt8186/mt8186-mt6366-da7219-max98357.o] Error 1
/build/stage/linux/sound/soc/mediatek/mt8186/mt8186-mt6366-rt1019-rt5682s.c: In function ‘mt8186_rt5682s_init’:
/build/stage/linux/sound/soc/mediatek/mt8186/mt8186-mt6366-rt1019-rt5682s.c:61:15: error: too many arguments to function ‘snd_soc_card_jack_new’
61 | ret = snd_soc_card_jack_new(rtd->card, "Headset Jack",
| ^~~~~~~~~~~~~~~~~~~~~
In file included from /build/stage/linux/include/sound/soc.h:1362,
from /build/stage/linux/sound/soc/mediatek/mt8186/mt8186-mt6366-rt1019-rt5682s.c:17:
/build/stage/linux/include/sound/soc-card.h:18:5: note: declared here
18 | int snd_soc_card_jack_new(struct snd_soc_card *card, const char *id, int type,
| ^~~~~~~~~~~~~~~~~~~~~
/build/stage/linux/sound/soc/mediatek/mt8186/mt8186-mt6366-rt1019-rt5682s.c: In function ‘mt8186_mt6366_rt1019_rt5682s_hdmi_init’:
/build/stage/linux/sound/soc/mediatek/mt8186/mt8186-mt6366-rt1019-rt5682s.c:137:15: error: too many arguments to function ‘snd_soc_card_jack_new’
137 | ret = snd_soc_card_jack_new(rtd->card, "HDMI Jack", SND_JACK_LINEOUT,
| ^~~~~~~~~~~~~~~~~~~~~
In file included from /build/stage/linux/include/sound/soc.h:1362,
from /build/stage/linux/sound/soc/mediatek/mt8186/mt8186-mt6366-rt1019-rt5682s.c:17:
/build/stage/linux/include/sound/soc-card.h:18:5: note: declared here
18 | int snd_soc_card_jack_new(struct snd_soc_card *card, const char *id, int type,
| ^~~~~~~~~~~~~~~~~~~~~
make[5]: *** [/build/stage/linux/scripts/Makefile.build:249: sound/soc/mediatek/mt8186/mt8186-mt6366-rt1019-rt5682s.o] Error 1
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 170 bytes --]
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
next prev parent reply other threads:[~2022-06-06 16:09 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-23 13:28 [PATCH v5 00/20] ASoC: mediatek: Add support for MT8186 SoC Jiaxin Yu
2022-05-23 13:28 ` [PATCH v5 01/20] ASoC: mediatek: mt6366: support for mt6366 codec Jiaxin Yu
2022-05-23 13:28 ` [PATCH v5 02/20] dt-bindings: mediatek: mt6358: add new compatible for using mt6366 Jiaxin Yu
2022-05-23 13:28 ` [PATCH v5 03/20] ASoC: mediatek: mt8186: support audsys clock control Jiaxin Yu
2022-05-23 13:28 ` [PATCH v5 04/20] ASoC: mediatek: mt8186: support adda in platform driver Jiaxin Yu
2022-05-23 13:28 ` [PATCH v5 05/20] ASoC: mediatek: mt8186: support hostless " Jiaxin Yu
2022-05-23 13:28 ` [PATCH v5 06/20] ASoC: mediatek: mt8186: support hw gain " Jiaxin Yu
2022-05-23 13:28 ` [PATCH v5 07/20] ASoC: mediatek: mt8186: support i2s " Jiaxin Yu
2022-05-23 13:28 ` [PATCH v5 08/20] ASoC: mediatek: mt8186: support pcm " Jiaxin Yu
2022-05-23 13:28 ` [PATCH v5 09/20] ASoC: mediatek: mt8186: support src " Jiaxin Yu
2022-05-23 13:28 ` [PATCH v5 10/20] ASoC: mediatek: mt8186: support tdm " Jiaxin Yu
2022-05-23 13:28 ` [PATCH v5 11/20] ASoC: mediatek: mt8186: support audio clock control " Jiaxin Yu
2022-05-23 13:28 ` [PATCH v5 12/20] ASoC: mediatek: mt8186: support gpio " Jiaxin Yu
2022-05-23 13:28 ` [PATCH v5 13/20] ASoC: mediatek: mt8186: add misc driver and register definitions Jiaxin Yu
2022-05-23 13:28 ` [PATCH v5 14/20] ASoC: mediatek: mt8186: add platform driver Jiaxin Yu
2022-05-23 13:28 ` [PATCH v5 15/20] ASoC: mediatek: mt8186: add mt8186-mt6366 common driver Jiaxin Yu
2022-05-23 13:28 ` [PATCH v5 16/20] dt-bindings: mediatek: mt8186: add audio afe document Jiaxin Yu
2022-05-23 13:28 ` [PATCH v5 17/20] ASoC: mediatek: mt8186: add machine driver with mt6366, da7219 and max98357 Jiaxin Yu
2022-05-23 13:28 ` [PATCH v5 18/20] dt-bindings: mediatek: mt8186: add mt8186-mt6366-da7219-max98357 document Jiaxin Yu
2022-06-02 13:35 ` Rob Herring
2022-05-23 13:28 ` [PATCH v5 19/20] ASoC: mediatek: mt8186: add machine driver with mt6366, rt1019 and rt5682s Jiaxin Yu
2022-06-06 16:08 ` Mark Brown [this message]
2022-05-23 13:28 ` [PATCH v5 20/20] dt-bindings: mediatek: mt8186: add mt8186-mt6366-rt1019-rt5682s document Jiaxin Yu
2022-06-02 13:35 ` Rob Herring
2022-06-07 10:55 ` [PATCH v5 00/20] ASoC: mediatek: Add support for MT8186 SoC Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yp4mg3ObzfQJ3FgP@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=aaronyu@google.com \
--cc=alsa-devel@alsa-project.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=jiaxin.yu@mediatek.com \
--cc=julianbraha@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=trevor.wu@mediatek.com \
--cc=tzungbi@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).