From: Sam Ravnborg <sam@ravnborg.org>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Hsin-Yi Wang <hsinyi@chromium.org>,
Rob Clark <robdclark@chromium.org>,
Chun-Kuang Hu <chunkuang.hu@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@linux.ie>,
linux-kernel@vger.kernel.org,
Douglas Anderson <dianders@chromium.org>,
Stephen Boyd <swboyd@chromium.org>,
Rob Herring <robh+dt@kernel.org>,
Thierry Reding <thierry.reding@gmail.com>,
linux-mediatek@lists.infradead.org,
dri-devel@lists.freedesktop.org,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 1/8] drm/panel: Add an API drm_panel_get_orientation() to return panel orientation
Date: Mon, 6 Jun 2022 22:50:57 +0200 [thread overview]
Message-ID: <Yp5osTQK+HCN2Ads@ravnborg.org> (raw)
In-Reply-To: <1c6e4d09-cf7a-2812-fd0d-09a21a275201@redhat.com>
Hi Hans,
> > Please move this up so it is together with the other get_* methods, in
> > alphabetic order. That is, right after get_modes(), and then this also
> > matches the order in the .c file with is extra bonus.
>
> The downside of moving this up is that it will break drivers which don't
> use c99 style named-struct-field initializers for there drm_panel_funcs.
>
> I admit that no drivers should be using the old style struct init, but
> are we sure that that is the case?
There is no in-tree driver that uses old style struct init for
drm_panel_funcs - so we are safe here.
I just did a quick git grep -A 4 drm_panel_funcs to verify it,
browsing through the output did not reveal any old style users.
Sam
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
next prev parent reply other threads:[~2022-06-06 20:51 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-06 15:24 [PATCH v4 0/8] Add a panel API to return panel orientation Hsin-Yi Wang
2022-06-06 15:24 ` [PATCH v4 1/8] drm/panel: Add an API drm_panel_get_orientation() " Hsin-Yi Wang
2022-06-06 19:06 ` Stephen Boyd
2022-06-07 7:53 ` Hsin-Yi Wang
2022-06-06 19:20 ` Sam Ravnborg
2022-06-06 20:15 ` Hans de Goede
2022-06-06 20:50 ` Sam Ravnborg [this message]
2022-06-06 15:24 ` [PATCH v4 2/8] drm/panel: boe-tv101wum-nl6: Implement .get_orientation callback Hsin-Yi Wang
2022-06-06 15:24 ` [PATCH v4 3/8] drm/panel: panel-edp: " Hsin-Yi Wang
2022-06-06 15:24 ` [PATCH v4 4/8] drm/panel: lvds: " Hsin-Yi Wang
2022-06-06 19:08 ` Stephen Boyd
2022-06-06 15:24 ` [PATCH v4 5/8] drm/panel: panel-simple: " Hsin-Yi Wang
2022-06-06 19:25 ` Sam Ravnborg
2022-06-07 3:54 ` Hsin-Yi Wang
2022-06-06 15:24 ` [PATCH v4 6/8] drm/panel: ili9881c: " Hsin-Yi Wang
2022-06-06 15:24 ` [PATCH v4 7/8] drm/panel: elida-kd35t133: " Hsin-Yi Wang
2022-06-06 15:24 ` [PATCH v4 8/8] drm/mediatek: Config orientation property if panel provides it Hsin-Yi Wang
2022-06-06 19:16 ` Stephen Boyd
2022-06-07 3:46 ` Hsin-Yi Wang
2022-06-06 19:31 ` Sam Ravnborg
2022-06-07 3:53 ` Hsin-Yi Wang
2022-06-06 19:28 ` [PATCH v4 0/8] Add a panel API to return panel orientation Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yp5osTQK+HCN2Ads@ravnborg.org \
--to=sam@ravnborg.org \
--cc=airlied@linux.ie \
--cc=chunkuang.hu@kernel.org \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=hdegoede@redhat.com \
--cc=hsinyi@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robdclark@chromium.org \
--cc=robh+dt@kernel.org \
--cc=swboyd@chromium.org \
--cc=thierry.reding@gmail.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).