From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 09400C433EF for ; Mon, 18 Jul 2022 19:00:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=K91k8rhmwAVyxMcS0asmjIubeABEinxJMupE9+6nDAA=; b=YcsW0QKX6SuxrNNhcQe1Nk6LM/ Dp30VO6eT4xJM/NuChXEwiS/IYSWDqkFnJwtv2HujT9OnxEq1g8aEUzEL8hQMuWadEzAa8J/Nb6tN rNUWofXq+Pp0NY1R5FYaqOU3pyY+EvuE8fDh04hklFWU1HpIuxCwSo/rTu9Fq3hOPc5hh4JHZIwIA jZMcvXVzAvurzGNz0TfDVWUmIaVUR8kAxzOG057aLWZHbAUkQ4AY/NS/eyTiLaeQr2vYAu1AF6U8V y/lsWKyKArr0EQLcE6mkMwFR2O//GGnpm6tmCNaH5tPzzJQ2tj2BnaJqMUWec0XhGWtzlb1EmzWQT NFj7rngw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oDVyE-000BuD-Fd; Mon, 18 Jul 2022 18:59:54 +0000 Received: from mga07.intel.com ([134.134.136.100]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oDVy0-000BmH-CH; Mon, 18 Jul 2022 18:59:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1658170780; x=1689706780; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=TIEQ4MTYN/3mHVFEK8QSYRaebmDVBch4wfEANQ4Z+F4=; b=fRp6jyLWEPVRoV5x2sRBRzaprr7U4hIyte5EwODV3FIuhfLx3d1uZhks M46SBrUrNOUi+wgLdQ7yC/abDqYvtSc2WK/bpDEEMUtstqal7D47fzUCy IZpWk5ydGHe9WdQzFHFXs5zi2uKg6OimambPb52TGz7smSd+P0KeSOt9I jnuJWw2kU/oP49aAhu3HmcOWt6OmMOhciQdPqnBX+dLrj3y6EvLMaCrHV B5YeCtGOvG0EjrVmGCCjRlyu1M5NA3lwScHcpf32G+ZRgAf3u8ufDVU51 dRFSMv0hmpJ+WstbeVqQ2YPRGPABKI35GrtEfW/5UNZCpHF4BrgtJzfue Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10412"; a="350258646" X-IronPort-AV: E=Sophos;i="5.92,281,1650956400"; d="scan'208";a="350258646" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jul 2022 11:59:37 -0700 X-IronPort-AV: E=Sophos;i="5.92,281,1650956400"; d="scan'208";a="700140775" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jul 2022 11:59:30 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1oDVxl-001OP6-31; Mon, 18 Jul 2022 21:59:25 +0300 Date: Mon, 18 Jul 2022 21:59:25 +0300 From: Andy Shevchenko To: "Russell King (Oracle)" Cc: Andrew Lunn , Heiner Kallweit , Alexandre Belloni , Alvin __ipraga , Claudiu Manoil , Daniel Scally , "David S. Miller" , DENG Qingfang , Eric Dumazet , Florian Fainelli , George McCollister , Greg Kroah-Hartman , Hauke Mehrtens , Heikki Krogerus , Jakub Kicinski , Kurt Kanzenbach , Landen Chao , Linus Walleij , linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Matthias Brugger , netdev@vger.kernel.org, Paolo Abeni , "Rafael J. Wysocki" , Sakari Ailus , Sean Wang , UNGLinuxDriver@microchip.com, Vivien Didelot , Vladimir Oltean , Woojung Huh , Marek =?iso-8859-1?Q?Beh=FAn?= Subject: Re: [PATCH net-next 5/6] net: dsa: use swnode fixed-link if using default params Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220718_115940_534892_327B5AB3 X-CRM114-Status: GOOD ( 18.86 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Fri, Jul 15, 2022 at 10:36:29PM +0100, Russell King (Oracle) wrote: > On Fri, Jul 15, 2022 at 11:11:18PM +0300, Andy Shevchenko wrote: > > On Fri, Jul 15, 2022 at 05:01:48PM +0100, Russell King (Oracle) wrote: ... > > > Co-developed by Vladimir Oltean and myself. > > > > Why not to use > > > > Co-developed-by: Vladimir Oltean > > Ah, that's an official thing. Thanks. Yep, it's even documented in Submitting Patches. ... > > > + phy_node = of_parse_phandle(dn, "phy-handle", 0); > > > > fwnode in the name, why not to use fwnode APIs? > > > > fwnode_find_reference(); > > Marcin has a series converting DSA to use fwnode things - currently DSA > does not support ACPI, so converting it to fwnode doesn't make that much > sese until the proper ACPI patches get merged, which have now been > rebased on this series by Marcin in the expectation that these patches > would be merged... so I don't want to tred on Marcin's feet on that. But it's normal development process... Anyway, it seems to me that you are using fwnode out of that (with the exception of one call). To me it looks that you add a work to him, rather than making his life easier, since you know ahead that this is going to be converted. -- With Best Regards, Andy Shevchenko