From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 62B4EC32789 for ; Sun, 21 Aug 2022 11:39:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=cs/tc4LRP05aft+lw1s0Hw9J5qiCtDypCAUcIFCUKxA=; b=zbWV/si40QrDEpwkwAnwkR3NkU 7sCRu3SMnxxRvVQCFuNPPhkRGwjabsYOqiCd5frxKe0TG4OgiJohJKtpaWe4ZNt0mcMumJG5BHA1y KzQo9+O3zgU0Kc51h7HJmNYEQjxMoPotd929FtiFr8PKGB9vEoKaGJWkDn0XVAJAfcGrbxyOXzKUs 4KNG1JdR89l9dUCc96faQGCgxAZIJb0HUtYAmyGXoseQFOf2ASrGxgCRkU85MpFhcRAPGn4/axT/9 FqfSovf55mD2NAAF+eiRx4SoLV8pxxTp7H/o8fg4gLZVGXPFS6+xugt8x7pzPrZulfKDHxN4LPW4N GMcDTGhw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oPjIe-009ozy-DN; Sun, 21 Aug 2022 11:39:30 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oPjIO-009osu-Hf; Sun, 21 Aug 2022 11:39:14 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B806DB80CAD; Sun, 21 Aug 2022 11:39:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 16F82C433C1; Sun, 21 Aug 2022 11:39:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1661081946; bh=XskdzOo4d6sQ470cDvLPNQUn3vWKINLbams0NyYkyHs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=h2mT+V1f1lnbZkkGAhFAY/FsV+M1AF9PcfNeRDvNZKCJy57DaoMtr9s0psqD3Q1mO lbDhmNpKNvV/MR3fm6StN1mxNxpQJUC8tyMYcQcHpyiP/DrWCMjJuOVjw/fDkS+Jbx q48H/NylIMORBfw8L2CaoJxyCseFOceSz7e8e7zajZorpFMEhY5H7KErwdtQ0xCEA5 hvyLFOsrJINBQhAU2H/quZ7hJS+vJsR04M2CqzO5yYMTToisG1GuzCWaEmeBmvQMOw uIVl8tgoxsIPMIJR37nelEvAqkJqxypMLHMFaQaclZNgvWJYRb3CySjpqDkfgWXLC6 zNIdvXH7Xnd5w== Date: Sun, 21 Aug 2022 14:39:01 +0300 From: Leon Romanovsky To: Wolfram Sang Cc: linux-kernel@vger.kernel.org, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jay Vosburgh , Veaceslav Falico , Andy Gospodarek , Wolfgang Grandegger , Marc Kleine-Budde , Florian Fainelli , Andrew Lunn , Vivien Didelot , Vladimir Oltean , Kurt Kanzenbach , Steffen Klassert , David Dillow , Russell King , Ion Badulescu , Andreas Larsson , Mark Einon , Lino Sanfilippo , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Jes Sorensen , Shay Agroskin , Arthur Kiyanovski , David Arinzon , Noam Dagan , Saeed Bishara , Don Fry , Tom Lendacky , Shyam Sundar S K , Igor Russkikh , Chris Snook , Michael Chan , Broadcom internal kernel review list , =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= , Rasesh Mody , GR-Linux-NIC-Dev@marvell.com, Ariel Elior , Sudarsana Kalluru , Manish Chopra , Doug Berger , Siva Reddy Kallam , Prashant Sreedharan , Sunil Goutham , Raju Rangoju , Ayush Sawal , Vinay Kumar Yadav , Rohit Maheshwari , Hartley Sweeten , Christian Benvenuti , Govindarajulu Varadarajan <_govind@gmx.com>, Denis Kirjanov , Ajit Khaparde , Sriharsha Basavapatna , Somnath Kotur , Madalin Bucur , Ioana Ciornei , Claudiu Manoil , Joakim Zhang , Pantelis Antoniou , Li Yang , Yisen Zhuang , Salil Mehta , Douglas Miller , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Nick Child , Jesse Brandeburg , Tony Nguyen , Guo-Fu Tseng , Sebastian Hesselbarth , Thomas Petazzoni , Marcin Wojtas , Geetha sowjanya , Subbaraya Sundeep , hariprasad , Taras Chornyi , Mirko Lindner , Stephen Hemminger , Felix Fietkau , John Crispin , Sean Wang , Mark Lee , Matthias Brugger , Tariq Toukan , Saeed Mahameed , Ido Schimmel , Petr Machata , Bryan Whitehead , UNGLinuxDriver@microchip.com, Chris Lee , Jon Mason , Simon Horman , Rain River , Zhu Yanjun , Vladimir Zapolskiy , Rahul Verma , Shahed Shaikh , Heiner Kallweit , nic_swsd@realtek.com, Jiri Pirko , Byungho An , Edward Cree , Martin Habets , Ralf Baechle , Francois Romieu , Daniele Venzano , Nicolas Pitre , Steve Glendinning , Jassi Brar , Ilias Apalodimas , Kunihiko Hayashi , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , Maxime Coquelin , Grygorii Strashko , Samuel Chessman , Geoff Levand , Ishizaki Kou , Kevin Brace , Radhey Shyam Pandey , Michal Simek , Krzysztof Halasa , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Sridhar Samudrala , Dave Jiang , Allen Hubbe , Michael Hennerich , Petko Manolov , Oliver Neukum , "Michael S. Tsirkin" , Jason Wang , Ronak Doshi , VMware PV-Drivers Reviewers , David Ahern , Kalle Valo , Christian Lamparter , Simon Kelley , Larry Finger , Arend van Spriel , Franky Lin , Hante Meuleman , Stanislav Yakovlev , Stanislaw Gruszka , Jouni Malinen , Ajay Singh , Claudiu Beznea , Igor Mitsyanko , Sergey Matyukevich , Herton Ronaldo Krzesinski , Hin-Tak Leung , netdev@vger.kernel.org, linux-can@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-acenic@sunsite.dk, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, intel-wired-lan@lists.osuosl.org, linux-mediatek@lists.infradead.org, linux-rdma@vger.kernel.org, oss-drivers@corigine.com, linux-mips@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-omap@vger.kernel.org, linux-hyperv@vger.kernel.org, ntb@lists.linux.dev, linux-usb@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org, brcm80211-dev-list.pdl@broadcom.com, SHA-cyfmac-dev-list@infineon.com, libertas-dev@lists.infradead.org Subject: Re: [PATCH] net: move from strlcpy with unused retval to strscpy Message-ID: References: <20220818210050.7108-1-wsa+renesas@sang-engineering.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220818210050.7108-1-wsa+renesas@sang-engineering.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220821_043912_929052_25E1739B X-CRM114-Status: GOOD ( 15.35 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Thu, Aug 18, 2022 at 11:00:34PM +0200, Wolfram Sang wrote: > Follow the advice of the below link and prefer 'strscpy' in this > subsystem. Conversion is 1:1 because the return value is not used. > Generated by a coccinelle script. > > Link: https://lore.kernel.org/r/CAHk-=wgfRnXz0W3D37d01q3JFkr_i_uTL=V6A6G1oUZcprmknw@mail.gmail.com/ > Signed-off-by: Wolfram Sang > --- <...> > drivers/net/ethernet/mellanox/mlx4/en_ethtool.c | 6 +++--- > drivers/net/ethernet/mellanox/mlx4/fw.c | 2 +- > .../net/ethernet/mellanox/mlx5/core/en_ethtool.c | 4 ++-- > drivers/net/ethernet/mellanox/mlx5/core/en_rep.c | 2 +- > .../ethernet/mellanox/mlx5/core/ipoib/ethtool.c | 2 +- Thanks, Reviewed-by: Leon Romanovsky