From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 01818C6FA82 for ; Wed, 28 Sep 2022 09:24:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=okSE3xkX1tEEKERaWFRU9udya/5Q/YQuTgKJr+jN9zU=; b=mLS/a1bDHQxWuJUgoOqPQ09wTi sr5c3F/wyPPfUCy1Vrt2NzYSksYPTYZPnFr9k/nntFSozMSxMbm4WkyZ0Q7ywL268yGRUyufiiZhg tXUF4p5ceIrv3q1JT/ClTzXhumSrGKmUSRngQLqNnbQ1kesAT27KRF+7Jf9RgpD6Vpneki1k/rv1s 4cAeoSEiNgbmo0VPHyaQCON40jMzdtCFkunHlx42sOUH/dTBcGuimB6IA41nCJ0mClFvhV1aO2vR0 fTFQCMT2V2h0tRB/V0WjWgxM3Z1Gr5Wx2D2fqyAV/oL2TCuu3Mf/66J4apw3BY5DkULdjnMaHwHEP BLigxaQw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1odTIU-00FAnu-OT; Wed, 28 Sep 2022 09:24:06 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1odTIG-00FAim-Av; Wed, 28 Sep 2022 09:23:53 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2115A61DDF; Wed, 28 Sep 2022 09:23:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 82805C433C1; Wed, 28 Sep 2022 09:23:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1664357030; bh=9Y7blUAL5zN9+EQU3Z3W3p8hWMps5aDqv5Tab1GFLWw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bKKOYjthvdVJdkp/WgUPyyIY6j5diqFOr36p4LlYd98uxj1Y9e/lUHtbTqi98vgyQ KbRS16fpU145hd3vMZQdmELdiDLMGpX8oUnpC6Y7HhKrvI+DAXOp1Tm9DK0N44XL80 mdFstae3oCw2JsYi4Sw3KJbhe3HwkElht+CJ4kpn9MhojQ2oiyppWZXSjQeRYlrQSX BKyF327yD4FFDPGj+fuNVpeUQ4KPGVY5bXC1MfKLj2L6YNGIBOhJkk3hHOjFVVmLNb qweGNfgGyDXDw0TL9Gsif0eqTs8PORFJji2tzGF6cr8+tGLT3NT8J+3GJZe5BvY+uS EHNa/rwudrMgw== Date: Wed, 28 Sep 2022 10:23:42 +0100 From: Lee Jones To: Rob Herring Cc: Jonathan Cameron , ChiaEn Wu , pavel@ucw.cz, krzysztof.kozlowski+dt@linaro.org, matthias.bgg@gmail.com, lars@metafoo.de, andriy.shevchenko@linux.intel.com, chiaen_wu@richtek.com, alice_chen@richtek.com, cy_huang@richtek.com, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, szunichen@gmail.com, AngeloGioacchino Del Regno , Andy Shevchenko , Jonathan Cameron Subject: Re: [PATCH v12 3/5] iio: adc: mt6370: Add MediaTek MT6370 support Message-ID: References: <9bf36f09bc5f002f2b09b7cc26edccf109516465.1663926551.git.chiaen_wu@richtek.com> <20220924155525.5663bed8@jic23-huawei> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220928_022352_495750_9864A7F8 X-CRM114-Status: GOOD ( 23.29 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Mon, 26 Sep 2022, Rob Herring wrote: > On Mon, Sep 26, 2022 at 2:46 AM Lee Jones wrote: > > > > On Sat, 24 Sep 2022, Jonathan Cameron wrote: > > > > > On Fri, 23 Sep 2022 10:51:24 +0800 > > > ChiaEn Wu wrote: > > > > > > > From: ChiaEn Wu > > > > > > > > MediaTek MT6370 is a SubPMIC consisting of a single cell battery charger > > > > with ADC monitoring, RGB LEDs, dual channel flashlight, WLED backlight > > > > driver, display bias voltage supply, one general purpose LDO, and the > > > > USB Type-C & PD controller complies with the latest USB Type-C and PD > > > > standards. > > > > > > > > Add support for the MT6370 ADC driver for system monitoring, including > > > > charger current, voltage, and temperature. > > > > > > > > Reviewed-by: AngeloGioacchino Del Regno > > > > Reviewed-by: Andy Shevchenko > > > > Acked-by: Jonathan Cameron > > > > Signed-off-by: ChiaEn Wu > > > > > > This will have to either wait for next cycle, or go through mfd because > > > of the dt-bindings include which is in the mfd tree. > > > > > > Please make those dependencies clear in new versions. > > > > If the bindings come together in -next, then subsequently in Mainline, > > it shouldn't really matter. > > Except that the bindings haven't come together and at this point may > not for 6.1. linux-next has been warning for weeks because the child > device schemas haven't been applied. I've said it before, all the > schemas for MFD devices need to be applied together. Or at least the > MFD schema needs to get applied last. > > Furthermore, subsequent versions of this don't get tested and we end > up with more warnings[1]. > > It's only your IIO tree that the DT > > tooling with complain about, right? > > And the MFD tree... > > Please apply the LED bindings (patches 1 and 2) so we can get the > existing warnings fixed and address any new warnings. Who usually applies LED bindings? Looks as though they're good to go. -- Lee Jones [李琼斯]