From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EAECBC36010 for ; Fri, 4 Apr 2025 12:11:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Ksgi80fBLzSJaAEI7Zj6pS0brYRqc/LQPT3hzVLK7xU=; b=Qr98Gj1TrrDE4gvee81HImgylA aSwVToFDAvuP0pTGN26pAo1ti3cRQj51oy6xTMoOzA0ZhxR6FZUfqMVM124jrGwykYx636zoussPJ A5w7tCJudnmKFHUcZnHpcXSTbd1NEzrQJnSP8TEINsVH/PH9qxnW3bmj2UDt9yd1vIyzkA0S5uCd2 zhkAHpd8uQGibpAm3/PnI9LdgCwWQWPyXS/jGm1tF6005jYf/K+4H1MbKC/dBGk1b1RBjrxizKEwY mMHB75rd+mrxKheI31YQ7qOcU6MyXvL6exn/YwrAw+O8uFP8hqmuaZUyA1/AnAbHmJpLclpksndM+ oqHlJEBQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.1 #2 (Red Hat Linux)) id 1u0fte-0000000Be1y-40t4; Fri, 04 Apr 2025 12:11:42 +0000 Received: from mail-ed1-x536.google.com ([2a00:1450:4864:20::536]) by bombadil.infradead.org with esmtps (Exim 4.98.1 #2 (Red Hat Linux)) id 1u0fmz-0000000Bcf2-3ldF for linux-mediatek@lists.infradead.org; Fri, 04 Apr 2025 12:04:51 +0000 Received: by mail-ed1-x536.google.com with SMTP id 4fb4d7f45d1cf-5e6167d0536so3528711a12.1 for ; Fri, 04 Apr 2025 05:04:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1743768288; x=1744373088; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Ksgi80fBLzSJaAEI7Zj6pS0brYRqc/LQPT3hzVLK7xU=; b=MBVG77zuER3xCBQXuZ/FodIRN49BQs1QAIYZiRO93V3icUBoMw481MdNBxmM6/2PtW SoI9/zmqg0YYv4qX3bpiRG1m7D3Zl5tZqZeaTufB42gkpI8lwdKX/heHNVXgyBbjjYgU LmXm8Ys8Uyj/xlQSwfJ3Zbs9twJF+884Y0hnOlry0sHrY+Z2D54cW00PdXqs4Cb+UeCB U/dfS91G0mpWpErZfzWAbnsxi6u7cxrwVHprEyBgjIqjZpCqZWuAt2REEePcFJ1NQjXu Gv8VoJQTBgylkuMsvS573NDcajDDkx8RAKEFYK1NZMX/n16ifjqDGJjWWFwK+8t0eoTI XmrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743768288; x=1744373088; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Ksgi80fBLzSJaAEI7Zj6pS0brYRqc/LQPT3hzVLK7xU=; b=v8ZFci9eb+fp8tSVGjWsXO2EKsgwhr2Ids81Yr4PZ03kWU8WCy2EY4wTkTq1R5ePvy dUSFS5ScYLQstZFeilEE1rm1IcjR7IXNhWR27ELjLeLKDdK4mHarfEpePZi1UroXBFmL oHYKnh+UCMwfyZrlOzu/jsVcFZv+j2wyd7iuchx4+ZB/SdY4wNHowxxKu6QbuY8ZajCu vEElKto67Gf6l53gFJtTNSNL9CsUkmxAkJrMky9SoPRYVTd41DQGM/AIre7nkDGMP2vy /MQTC+eSOtxxS4JuYs+w3m3LZCJt1FotGgouJoa+2YC0TWUQj7W1V8uSDI+CI84jvONB LdBQ== X-Forwarded-Encrypted: i=1; AJvYcCVd0XCQSK9Ubwu9JgfcqN3htQ68aNqhX7D+c77dU4Pl91P3Ua1ov/ygRvwkEgoNlymdfBsDKfyic77yzVuAnw==@lists.infradead.org X-Gm-Message-State: AOJu0Yy8+7qNt7gCq3KlMODWLi0pNipZ9IYN7lCrY+viQRPTBqJk0FhH V49vUbYgKqJ41pKB6Mp8WZ3LjRJJFDVM+9ozX8SUHRlEI6+g/w7H4c5tyfcorrM= X-Gm-Gg: ASbGncsUl8+RwxM38JR/9aT6DNersRFfBnzJoG7p7D7KXk+jYTQtsxl7wfckpfJGLb8 7Hz/wNotE7HJ0wsn9XSkyiwBQFHjQtNfZTkrmtRQwBa11xfCsNvkS0xeEBiR9AZbDPeLC5SiQzQ 58rsJMIaz+MAc31laLUcN91UChPLzoTl4x/OMg3haAj7Npr1L326dHqyCPWhV7tUnUagbJoKTn+ wFQu1gJD+UUujmeykL25/Y3i4ogUpQQgRKrdPUYM1gxc2pES46UA/zDTbLGXq37pLvD1UEz7zPY PVPbAm3ybqTBlwp3G577RSOJ4Iny7/Gm4jFYmCYsJUTKSrzwfpF+MPW1 X-Google-Smtp-Source: AGHT+IH5Ij+fmf2Cv6jAlPmeJCCy1hd8btt4BuhHv/bD/os6ByinB+7Aq8sAGgjUE/8mRPndj8Zo0g== X-Received: by 2002:a05:6402:2708:b0:5f0:9eb3:8e71 with SMTP id 4fb4d7f45d1cf-5f0b3e34eafmr2516192a12.27.1743768287658; Fri, 04 Apr 2025 05:04:47 -0700 (PDT) Received: from linaro.org ([2a02:2454:ff21:ef30:e124:1321:48a4:8c63]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5f0880a458csm2276353a12.69.2025.04.04.05.04.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Apr 2025 05:04:47 -0700 (PDT) Date: Fri, 4 Apr 2025 14:04:41 +0200 From: Stephan Gerhold To: "Rob Herring (Arm)" Cc: Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , "Rafael J. Wysocki" , Viresh Kumar , Matthias Brugger , AngeloGioacchino Del Regno , Vincenzo Frascino , Liviu Dudau , Sudeep Holla , Lorenzo Pieralisi , Bjorn Andersson , Konrad Dybcio , Thomas Bogendoerfer , Viresh Kumar , Nishanth Menon , Stephen Boyd , zhouyanjie@wanyeetech.com, Conor Dooley , Nicolas Ferre , Claudiu Beznea , Steen Hegelund , Daniel Machon , UNGLinuxDriver@microchip.com, Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Heiko Stuebner , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Geert Uytterhoeven , Magnus Damm , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-mips@vger.kernel.org, imx@lists.linux.dev, linux-rockchip@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH 06/19] arm64: dts: qcom: msm8939: Fix CPU node "enable-method" property dependencies Message-ID: References: <20250403-dt-cpu-schema-v1-0-076be7171a85@kernel.org> <20250403-dt-cpu-schema-v1-6-076be7171a85@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250403-dt-cpu-schema-v1-6-076be7171a85@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250404_050449_934288_92B8378A X-CRM114-Status: GOOD ( 19.30 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Thu, Apr 03, 2025 at 09:59:27PM -0500, Rob Herring (Arm) wrote: > The "qcom,acc" and "qcom,saw" properties aren't valid with "spin-table" > enable-method nor are they used on 64-bit kernels, so they can be > dropped. > The bootloader we currently use on these devices reads these properties to set up the spin-table, so removing these will break booting secondary CPU cores. The motivation for implementing it that way was that 32-bit vs 64-bit kernel shouldn't be relevant for the describing the hardware blocks in the device tree. The code in the bootloader is generic and handles different SoCs (e.g. msm8916 with 4 cores and msm8939 with 8 cores, the enable sequences are identical). Can we keep this in somehow? To be fair, I'm not sure what property we could match on to check if these properties are allowed ... Thanks, Stephan > The "spin-table" enable-method requires "cpu-release-addr" property, > so add a dummy entry. It is assumed the bootloader will fill in the > correct values. > > Signed-off-by: Rob Herring (Arm) > --- > arch/arm64/boot/dts/qcom/msm8939.dtsi | 24 ++++++++---------------- > 1 file changed, 8 insertions(+), 16 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/msm8939.dtsi b/arch/arm64/boot/dts/qcom/msm8939.dtsi > index 7cd5660de1b3..36f2ba3fb81c 100644 > --- a/arch/arm64/boot/dts/qcom/msm8939.dtsi > +++ b/arch/arm64/boot/dts/qcom/msm8939.dtsi > @@ -46,10 +46,9 @@ cpu0: cpu@100 { > compatible = "arm,cortex-a53"; > device_type = "cpu"; > enable-method = "spin-table"; > + cpu-release-addr = /bits/ 64 <0>; > reg = <0x100>; > next-level-cache = <&l2_1>; > - qcom,acc = <&acc0>; > - qcom,saw = <&saw0>; > cpu-idle-states = <&cpu_sleep_0>; > clocks = <&apcs1_mbox>; > #cooling-cells = <2>; > @@ -64,10 +63,9 @@ cpu1: cpu@101 { > compatible = "arm,cortex-a53"; > device_type = "cpu"; > enable-method = "spin-table"; > + cpu-release-addr = /bits/ 64 <0>; > reg = <0x101>; > next-level-cache = <&l2_1>; > - qcom,acc = <&acc1>; > - qcom,saw = <&saw1>; > cpu-idle-states = <&cpu_sleep_0>; > clocks = <&apcs1_mbox>; > #cooling-cells = <2>; > @@ -77,10 +75,9 @@ cpu2: cpu@102 { > compatible = "arm,cortex-a53"; > device_type = "cpu"; > enable-method = "spin-table"; > + cpu-release-addr = /bits/ 64 <0>; > reg = <0x102>; > next-level-cache = <&l2_1>; > - qcom,acc = <&acc2>; > - qcom,saw = <&saw2>; > cpu-idle-states = <&cpu_sleep_0>; > clocks = <&apcs1_mbox>; > #cooling-cells = <2>; > @@ -90,10 +87,9 @@ cpu3: cpu@103 { > compatible = "arm,cortex-a53"; > device_type = "cpu"; > enable-method = "spin-table"; > + cpu-release-addr = /bits/ 64 <0>; > reg = <0x103>; > next-level-cache = <&l2_1>; > - qcom,acc = <&acc3>; > - qcom,saw = <&saw3>; > cpu-idle-states = <&cpu_sleep_0>; > clocks = <&apcs1_mbox>; > #cooling-cells = <2>; > @@ -103,9 +99,8 @@ cpu4: cpu@0 { > compatible = "arm,cortex-a53"; > device_type = "cpu"; > enable-method = "spin-table"; > + cpu-release-addr = /bits/ 64 <0>; > reg = <0x0>; > - qcom,acc = <&acc4>; > - qcom,saw = <&saw4>; > cpu-idle-states = <&cpu_sleep_0>; > clocks = <&apcs0_mbox>; > #cooling-cells = <2>; > @@ -121,10 +116,9 @@ cpu5: cpu@1 { > compatible = "arm,cortex-a53"; > device_type = "cpu"; > enable-method = "spin-table"; > + cpu-release-addr = /bits/ 64 <0>; > reg = <0x1>; > next-level-cache = <&l2_0>; > - qcom,acc = <&acc5>; > - qcom,saw = <&saw5>; > cpu-idle-states = <&cpu_sleep_0>; > clocks = <&apcs0_mbox>; > #cooling-cells = <2>; > @@ -134,10 +128,9 @@ cpu6: cpu@2 { > compatible = "arm,cortex-a53"; > device_type = "cpu"; > enable-method = "spin-table"; > + cpu-release-addr = /bits/ 64 <0>; > reg = <0x2>; > next-level-cache = <&l2_0>; > - qcom,acc = <&acc6>; > - qcom,saw = <&saw6>; > cpu-idle-states = <&cpu_sleep_0>; > clocks = <&apcs0_mbox>; > #cooling-cells = <2>; > @@ -147,10 +140,9 @@ cpu7: cpu@3 { > compatible = "arm,cortex-a53"; > device_type = "cpu"; > enable-method = "spin-table"; > + cpu-release-addr = /bits/ 64 <0>; > reg = <0x3>; > next-level-cache = <&l2_0>; > - qcom,acc = <&acc7>; > - qcom,saw = <&saw7>; > cpu-idle-states = <&cpu_sleep_0>; > clocks = <&apcs0_mbox>; > #cooling-cells = <2>; > > -- > 2.47.2 >