From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3225BE7716E for ; Thu, 5 Dec 2024 22:40:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=gAnmnDgcIo03qM4IFIt1yQIQ8Wt2+bmQphrrz6tK6iw=; b=k4tjezXCes/ccAlKw/oafHTXj1 cVCr/oeasx88kn2/E6DaZsFNFnxVWMr7Fer439HUFTfplEz2NGiOXsDDG72HBPWZ7Dvo/DhdbfZWZ Y18Ba5T02IG+TqSp/xzBC5jfCe3UaAIqsqnAiStNnmqUeMBpPv2Eg/uhADDYqfoQ4NhDXyoqog+EX gQQcixM45lb5FpEVpxXrqXBrpVo6E0O/oCAiLb9esmbE/fVPcml8p3FDVx1xu1nBiFbKLdfl+Q+dv G2HjcBnSWz+1pxphLMBU/jnVkspJAOOI3Hdoi3KJGP3/o+7bUeiNSGmWaixNxPQmjney0bIfaGUBB 03nMG3ng==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tJKVw-0000000HV4l-1swq; Thu, 05 Dec 2024 22:40:04 +0000 Received: from mgamail.intel.com ([198.175.65.19]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tJKVq-0000000HV3E-39Nw for linux-mediatek@lists.infradead.org; Thu, 05 Dec 2024 22:40:02 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1733438399; x=1764974399; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=bDWc4rhMgoZqDeL0AXlS3HEyZRI+NGFW7RdxbN26PwE=; b=BCwR3MBaeff5j797cWjyd2tKegingtbTF3Zd0FHw171pqqxZNOcWyUDc elDfw2baVXqtfQZqg30i+ngFtBteOPrhdEmCHe1WAO4sPKGi6M/a7TJsq MywCexY+msMLMPafe8sjLrKTb2Y8UZ0K7y4Zmaw/t9NNSxD4SVpzhfD1j kQK7gA/0pTSCbUcNtPsfTfbMJsUh9Tla8d5VLhNRdMHDr3Wq4qk9BcwAO 7WlKZgZiIW0SQPoxIIVmcdaBMufeBv8eMJjZXklsTqWsUltGDLseYueJ9 /7/xtA5ZqIO2iAca2RKM70Qs52so+vtuocrj5SGpBHsdC1k6pwxBdU7W7 Q==; X-CSE-ConnectionGUID: 5aGAys77SriNAkZ0GpIj9Q== X-CSE-MsgGUID: tvuQT4CRSo+dlByfvcKfsg== X-IronPort-AV: E=McAfee;i="6700,10204,11277"; a="33660988" X-IronPort-AV: E=Sophos;i="6.12,211,1728975600"; d="scan'208";a="33660988" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by orvoesa111.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Dec 2024 14:39:55 -0800 X-CSE-ConnectionGUID: s9cK9Ag1RGqhkbjPJGPt5g== X-CSE-MsgGUID: +9UlsE4TSWCPuUIT6GPzKw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,211,1728975600"; d="scan'208";a="99052989" Received: from aschofie-mobl2.amr.corp.intel.com (HELO aschofie-mobl2.lan) ([10.125.108.192]) by fmviesa004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Dec 2024 14:39:53 -0800 Date: Thu, 5 Dec 2024 14:39:51 -0800 From: Alison Schofield To: Zijun Hu Cc: Greg Kroah-Hartman , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , James Bottomley , Thomas =?iso-8859-1?Q?Wei=DFschuh?= , linux-kernel@vger.kernel.org, nvdimm@lists.linux.dev, linux-sound@vger.kernel.org, sparclinux@vger.kernel.org, linux-block@vger.kernel.org, linux-cxl@vger.kernel.org, linux1394-devel@lists.sourceforge.net, arm-scmi@vger.kernel.org, linux-efi@vger.kernel.org, linux-gpio@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-hwmon@vger.kernel.org, linux-media@vger.kernel.org, linux-pwm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-scsi@vger.kernel.org, open-iscsi@googlegroups.com, linux-usb@vger.kernel.org, linux-serial@vger.kernel.org, netdev@vger.kernel.org, Zijun Hu Subject: Re: [PATCH v3 04/11] driver core: Constify API device_find_child() then adapt for various usages Message-ID: References: <20241205-const_dfc_done-v3-0-1611f1486b5a@quicinc.com> <20241205-const_dfc_done-v3-4-1611f1486b5a@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241205-const_dfc_done-v3-4-1611f1486b5a@quicinc.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241205_144001_371275_8E077123 X-CRM114-Status: GOOD ( 14.11 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Thu, Dec 05, 2024 at 08:10:13AM +0800, Zijun Hu wrote: > From: Zijun Hu > > Constify the following API: > struct device *device_find_child(struct device *dev, void *data, > int (*match)(struct device *dev, void *data)); > To : > struct device *device_find_child(struct device *dev, const void *data, > device_match_t match); > typedef int (*device_match_t)(struct device *dev, const void *data); > with the following reasons: > > - Protect caller's match data @*data which is for comparison and lookup > and the API does not actually need to modify @*data. > > - Make the API's parameters (@match)() and @data have the same type as > all of other device finding APIs (bus|class|driver)_find_device(). > > - All kinds of existing device match functions can be directly taken > as the API's argument, they were exported by driver core. > > Constify the API and adapt for various existing usages by simply making > various match functions take 'const void *' as type of match data @data. > > Signed-off-by: Zijun Hu > --- > arch/sparc/kernel/vio.c | 6 +++--- > drivers/base/core.c | 6 +++--- > drivers/block/sunvdc.c | 6 +++--- > drivers/bus/fsl-mc/dprc-driver.c | 4 ++-- > drivers/cxl/core/pci.c | 4 ++-- > drivers/cxl/core/pmem.c | 2 +- > drivers/cxl/core/region.c | 21 ++++++++++++--------- > drivers/firewire/core-device.c | 4 ++-- > drivers/firmware/arm_scmi/bus.c | 4 ++-- > drivers/firmware/efi/dev-path-parser.c | 4 ++-- > drivers/gpio/gpio-sim.c | 2 +- > drivers/gpu/drm/mediatek/mtk_drm_drv.c | 2 +- > drivers/hwmon/hwmon.c | 2 +- > drivers/media/pci/mgb4/mgb4_core.c | 4 ++-- > drivers/nvdimm/bus.c | 2 +- > drivers/pwm/core.c | 2 +- > drivers/rpmsg/rpmsg_core.c | 4 ++-- > drivers/scsi/qla4xxx/ql4_os.c | 3 ++- > drivers/scsi/scsi_transport_iscsi.c | 10 +++++----- > drivers/slimbus/core.c | 8 ++++---- > drivers/thunderbolt/retimer.c | 2 +- > drivers/thunderbolt/xdomain.c | 2 +- > drivers/tty/serial/serial_core.c | 4 ++-- > drivers/usb/typec/class.c | 8 ++++---- > include/linux/device.h | 4 ++-- > include/scsi/scsi_transport_iscsi.h | 4 ++-- > net/dsa/dsa.c | 2 +- > tools/testing/cxl/test/cxl.c | 2 +- > 28 files changed, 66 insertions(+), 62 deletions(-) > For these cxl and nvdimm pieces: drivers/cxl/core/pci.c | 4 ++-- drivers/cxl/core/pmem.c | 2 +- drivers/cxl/core/region.c | 21 ++++++++++++--------- drivers/nvdimm/bus.c | 2 +- tools/testing/cxl/test/cxl.c | 2 +- Reviewed-by: Alison Schofield snip to end