From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6B4E4C28B2F for ; Sun, 9 Mar 2025 17:52:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=trOvshMr7ukZzcXJPcSVt8+zNNX8HGE0PTd1EfamR/U=; b=qfYrnl1HS5aBhAHopW59+NGd83 Mcg++GUYPfPU/25Em/iS/RJo3q/0jQ95RkUmts4sMaG4OORoN9Ysft3UNkZ3/8T4qGhowfy1WvmE/ LPeAl8L8GhcudaJ62DluCNySev8lagVvf2pZwyzPF2Yvt/ayJt0pEt2Q9tx27U0KBeBCTbjOrk9d1 zXksl9aHyJfzVTIO/8jOggTYrGiGTe8Fhw6ebjf7p9PWo6whY4uye60oBLQybtx0Y5B7hTqeomz2m xCdgmMlEY4qTCo0L43WGY4ZfGXvxx4+KYzQk9Gg7dVIyHLOkQwiAAkyanLTRlr/wSvZWRSBVJ+/xO +ch5LxYQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1trKpP-00000000tJ4-2qi9; Sun, 09 Mar 2025 17:52:43 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1trKaO-00000000rTv-3ryy; Sun, 09 Mar 2025 17:37:14 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=trOvshMr7ukZzcXJPcSVt8+zNNX8HGE0PTd1EfamR/U=; b=h56zXtBZa/5wXPcpRpkKYh4PlN FVBXPhxn29lyqhisMCHoD5k3YImfsyxDvgobDx2h1V4Ze+6Lv8MXixMh3rT1z/1cBUTINv+RRk7I9 Cauo7SoF8oQDeFRsPKUpMUYj3/gK+F39fXlNRzZAFZ2m+ZmNVo+iJaF3r6XPIQiwpto+Vkoqi+Zsd or9oIBPQpNHD7/23FH0GGnT+AvjO2484tCM3FrT3b5Jr4UV4Yoh2W1kiiSa+qbdRCmUgd3r/HML4s ZADSv3qpFDmivCUKHVLAe5MXk1YGGXP65LRruV6ch9WwGxnx4l0up2Q7oKv96eihBeKkhlZTwYf5G xUAT2z0w==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:60658) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1trKa6-0001YP-0o; Sun, 09 Mar 2025 17:36:54 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.96) (envelope-from ) id 1trKa1-0001cZ-16; Sun, 09 Mar 2025 17:36:49 +0000 Date: Sun, 9 Mar 2025 17:36:49 +0000 From: "Russell King (Oracle)" To: Christian Marangi Cc: Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vladimir Oltean , Srinivas Kandagatla , Heiner Kallweit , Maxime Chevallier , Matthias Brugger , AngeloGioacchino Del Regno , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, netdev@vger.kernel.org, upstream@airoha.com Subject: Re: [net-next PATCH v12 07/13] net: mdio: regmap: add support for multiple valid addr Message-ID: References: <20250309172717.9067-1-ansuelsmth@gmail.com> <20250309172717.9067-8-ansuelsmth@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250309172717.9067-8-ansuelsmth@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250309_103712_964099_AEDB1733 X-CRM114-Status: GOOD ( 11.01 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Sun, Mar 09, 2025 at 06:26:52PM +0100, Christian Marangi wrote: > +/* If a non empty valid_addr_mask is passed, PHY address and > + * read/write register are encoded in the regmap register > + * by placing the register in the first 16 bits and the PHY address > + * right after. > + */ > +#define MDIO_REGMAP_PHY_ADDR GENMASK(20, 16) > +#define MDIO_REGMAP_PHY_REG GENMASK(15, 0) Clause 45 PHYs have 5 bits of PHY address, then 5 bits of mmd address, and then 16 bits of register address - significant in that order. Can we adjust the mask for the PHY address later to add the MMD between the PHY address and register number? -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!