From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2B5F7C77B73 for ; Thu, 20 Apr 2023 00:22:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Cc:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=SsYeKvWKH+5pLt9rj+RhbIv2MYeootQIidHe3zvqpBo=; b=SoKyX2vG/DxOu6eiAWzzEL5ixE K9JfzhBMDxOGGSnZIgumAlPzIG/oRXQwGBfCqNnXw4ooWRZ2qr2+JxZRgTBHLCHMxTRkDVXOV0Hsa mKS4bb7+3QzKsSJ8UXVGmr6cbG4Ud2zbUHbgj6E86l8sfhnCrsYpA/3ZNiXoXdKKyBMxUTQsO1EQr l3woB5GhUVa9NsFeXdRPlfipk9MuShdjzpAyred0u5QwRaMa+P+VpoxgBc31jiF2/5e7srNCq5Pef sdWMwxRqe9Y48o7XsQksJ6Eh/3j5Tq8RRjRERuc/2pS6harjFmclFUTi/Fko5BqQ/3XWv3zD+WuWd QJ12OF6w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1ppI4J-006iIo-1j; Thu, 20 Apr 2023 00:22:35 +0000 Received: from fudo.makrotopia.org ([2a07:2ec0:3002::71]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1ppI4H-006iI1-12; Thu, 20 Apr 2023 00:22:34 +0000 Received: from local by fudo.makrotopia.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.96) (envelope-from ) id 1ppI47-0006PU-1Z; Thu, 20 Apr 2023 02:22:23 +0200 Date: Thu, 20 Apr 2023 01:22:20 +0100 From: Daniel Golle To: netdev@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Sean Wang , Landen Chao , DENG Qingfang , Andrew Lunn , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Russell King , AngeloGioacchino Del Regno , Matthias Brugger , =?utf-8?B?QXLEsW7DpyDDnE5BTA==?= , Jesse Brandeburg Subject: Re: [PATCH net-next v2] net: dsa: mt7530: fix support for MT7531BE Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230419_172233_359658_BDE3B840 X-CRM114-Status: GOOD ( 16.54 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Sun, Apr 16, 2023 at 01:08:14PM +0100, Daniel Golle wrote: > There are two variants of the MT7531 switch IC which got different > features (and pins) regarding port 5: > * MT7531AE: SGMII/1000Base-X/2500Base-X SerDes PCS > * MT7531BE: RGMII > > Moving the creation of the SerDes PCS from mt753x_setup to mt7530_probe > with commit 6de285229773 ("net: dsa: mt7530: move SGMII PCS creation > to mt7530_probe function") works fine for MT7531AE which got two > instances of mtk-pcs-lynxi, however, MT7531BE requires mt7531_pll_setup > to setup clocks before the single PCS on port 6 (usually used as CPU > port) starts to work and hence the PCS creation failed on MT7531BE. > > Fix this by introducing a pointer to mt7531_create_sgmii function in > struct mt7530_priv and call it again at the end of mt753x_setup like it > was before commit 6de285229773 ("net: dsa: mt7530: move SGMII PCS > creation to mt7530_probe function"). > > Fixes: 6de285229773 ("net: dsa: mt7530: move SGMII PCS creation to mt7530_probe function") > Signed-off-by: Daniel Golle > --- This v2 submission addresses the comments made by Jesse Brandeburg regarding zero-initializing regmap_config as we are now not necessarily using both of them. Comments by Arınç ÜNAL have also been discussed and resulting in receiving Ack. However, I can see in patchwork that the patch has been set to "Changes Requested". Can someone please tell me which further changes are needed? I don't see any other comments on the mailing list or patchwork. Thank you! Daniel