From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8302DC77B61 for ; Tue, 25 Apr 2023 15:08:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=yKetS0BduABo9wi8mcskz8sSRGjTmmkO8q3V6sunxQk=; b=Qzu15P4B/3f+lJlz+1ug67jPGH fz2h4MvzwKt3LKl4ESj2LChXWxLwq9/ieGbv3UOnbUs3/tEAiNMbgYdZxoodMv1NDepLw9OPhGxmA s1FsfjqiU8lM2YdhiFm+EW8GnCYoTbe3/pFPJOpNdTtGtgjAtA7uMDNjfQIF8aR2LkIEIPTKmuySl rzEKfnm8vin/rpud1wH53ywyDYBGxjO/zXxfdt6jVOudPnJgYbCWf3n3brYTgff3BOaebH8s4zIaJ m33tbnWwK29zuaq8ieqU0dhAYL9EurjF1XQBMk7YyP66yz3lypdT3+4/iOkInWIciLK+VA8KORMC/ PGAejx5Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1prKHO-001Ug4-1w; Tue, 25 Apr 2023 15:08:30 +0000 Received: from fudo.makrotopia.org ([2a07:2ec0:3002::71]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1prKHK-001UeN-1l; Tue, 25 Apr 2023 15:08:27 +0000 Received: from local by fudo.makrotopia.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.96) (envelope-from ) id 1prKGx-0004W6-1Y; Tue, 25 Apr 2023 17:08:03 +0200 Date: Tue, 25 Apr 2023 16:06:13 +0100 From: Daniel Golle To: arinc9.unal@gmail.com Subject: Re: [PATCH net-next 03/24] net: dsa: mt7530: use p5_interface_select as data type for p5_intf_sel Message-ID: References: <20230425082933.84654-1-arinc.unal@arinc9.com> <20230425082933.84654-4-arinc.unal@arinc9.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230425082933.84654-4-arinc.unal@arinc9.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230425_080826_585516_C4F0CAE7 X-CRM114-Status: GOOD ( 16.63 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Eric Dumazet , erkin.bozoglu@xeront.com, Florian Fainelli , Russell King , Richard van Schagen , Jakub Kicinski , Paolo Abeni , Landen Chao , Richard van Schagen , Sean Wang , DENG Qingfang , linux-mediatek@lists.infradead.org, Bartel Eerdekens , Matthias Brugger , linux-arm-kernel@lists.infradead.org, AngeloGioacchino Del Regno , =?utf-8?B?QXLEsW7DpyDDnE5BTA==?= , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Vladimir Oltean , "David S. Miller" Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Tue, Apr 25, 2023 at 11:29:12AM +0300, arinc9.unal@gmail.com wrote: > From: Arınç ÜNAL > > Use the p5_interface_select enumeration as the data type for the > p5_intf_sel field. This ensures p5_intf_sel can only take the values > defined in the p5_interface_select enumeration. > > Signed-off-by: Arınç ÜNAL Acked-by: Daniel Golle > --- > drivers/net/dsa/mt7530.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/dsa/mt7530.h b/drivers/net/dsa/mt7530.h > index 845f5dd16d83..415d8ea07472 100644 > --- a/drivers/net/dsa/mt7530.h > +++ b/drivers/net/dsa/mt7530.h > @@ -675,7 +675,7 @@ struct mt7530_port { > > /* Port 5 interface select definitions */ > enum p5_interface_select { > - P5_DISABLED = 0, > + P5_DISABLED, > P5_INTF_SEL_PHY_P0, > P5_INTF_SEL_PHY_P4, > P5_INTF_SEL_GMAC5, > @@ -768,7 +768,7 @@ struct mt7530_priv { > bool mcm; > phy_interface_t p6_interface; > phy_interface_t p5_interface; > - unsigned int p5_intf_sel; > + enum p5_interface_select p5_intf_sel; > u8 mirror_rx; > u8 mirror_tx; > struct mt7530_port ports[MT7530_NUM_PORTS]; > -- > 2.37.2 >