From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AA26AC77B75 for ; Mon, 8 May 2023 07:48:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Ab0pVV55Pz7uG9LLbv5Fg+9Md5m99q19n0DHzkRnwqg=; b=QLRrUCN1u07RbwxST7GrejEpia IQX3V3P+B5y96CsqgxugQX6QRXLIB+6BZob0H67stlxGxs42vYAoSdlzwJtyfzfE3ApafSmDVGhOS EeDw+sD90YulomfIX/l+E+/ER22bQ6ZeI6rp8bQmdBIIJuF4TiMT7ylUSTtXfeaNsugrYfUtu5db/ /jRHu282j8Tz2013lIe4AQlS0iliWdMPon4k5oFDlY+lYzA41m6j+oBWAZooeuFbS9tQt88haHhkH hq9dJA0zXadFGHjpDeYPXCnkaS8egdKoqtREdaKnJTfTlgn3zR3FIT9UVw04lg1iT8/FaRetnCAVB GAueQVvw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pvvbx-00HWW5-2e; Mon, 08 May 2023 07:48:45 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pvvbu-00HWVI-3D; Mon, 08 May 2023 07:48:44 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 292F760F04; Mon, 8 May 2023 07:48:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B9BBEC433D2; Mon, 8 May 2023 07:48:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1683532121; bh=G9HdM1QJziMzpOUvCuJGpW3lxswdvThqfd4Irkdvc78=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SFLrL35w0Msv/Ut1ZxVUaSrWlMrdhAImX35jJa+vNdjFsaccU4K/Tmt46yGGcK/ab ShGUwgzPb0DXnrbmb7y+amP1uv5G7AULBvvpwkxkCI8F/TrVO4X4k20OUy7LQhW354 VQpewPMkAJfEPC2bALgNFB95LK7BWdgiYlJlZMw70TcptzYNU6cjXZ08Hv2+wil21O sidC919sGP4/xfCnp+E8wq+yejJrbmLzoCSv8Fv6Ym+qsqV0c+COSzCe4/6DDVgAN6 SxgSWWuqvXXfvXnWitxgoPYDeztdtBvZsyFeoeZX5IbsFy458+BM+3hXZi1UEKlP5S A2B38BMSM4HgQ== Date: Mon, 8 May 2023 13:18:37 +0530 From: Vinod Koul To: Matthias Brugger Cc: Tom Rix , chunkuang.hu@kernel.org, p.zabel@pengutronix.de, chunfeng.yun@mediatek.com, kishon@kernel.org, angelogioacchino.delregno@collabora.com, nathan@kernel.org, ndesaulniers@google.com, granquet@baylibre.com, dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev Subject: Re: [PATCH] phy: mediatek: fix returning garbage Message-ID: References: <20230414122253.3171524-1-trix@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230508_004843_072789_75A53341 X-CRM114-Status: GOOD ( 13.73 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On 05-05-23, 17:37, Matthias Brugger wrote: > > > On 05/05/2023 11:28, Vinod Koul wrote: > > On 14-04-23, 08:22, Tom Rix wrote: > > > clang reports > > > drivers/phy/mediatek/phy-mtk-hdmi-mt8195.c:298:6: error: variable > > > 'ret' is uninitialized when used here [-Werror,-Wuninitialized] > > > if (ret) > > > ^~~ > > > ret should have been set by the preceding call to mtk_hdmi_pll_set_hw. > > > > I have applied "phy: mediatek: hdmi: mt8195: fix uninitialized variable > > usage in pll_calc" > > Thanks Vinod, that was on my list for today as well. I was a bit puzzled > because you took the patch that added it, but I wasn't sure if you would > take the fix. How do you want to handle things like this in the future? Fixes should be sent as Fixes patch -- ~Vinod