From: Jason Gunthorpe <jgg@nvidia.com>
To: "Ricardo Cañuelo" <ricardo.canuelo@collabora.com>,
"Yong Wu" <yong.wu@mediatek.com>,
linux-mediatek@lists.infradead.org
Cc: iommu@lists.linux.dev, Joerg Roedel <joro@8bytes.org>,
llvm@lists.linux.dev, Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Miguel Ojeda <ojeda@kernel.org>,
Robin Murphy <robin.murphy@arm.com>, Tom Rix <trix@redhat.com>,
Will Deacon <will@kernel.org>,
Lu Baolu <baolu.lu@linux.intel.com>,
Heiko Stuebner <heiko@sntech.de>,
Kevin Tian <kevin.tian@intel.com>,
Nicolin Chen <nicolinc@nvidia.com>,
Niklas Schnelle <schnelle@linux.ibm.com>
Subject: Re: [PATCH v5 10/17] iommu: Do iommu_group_create_direct_mappings() before attach
Date: Mon, 5 Jun 2023 10:47:09 -0300 [thread overview]
Message-ID: <ZH3nXbVFR6JfUKpV@nvidia.com> (raw)
In-Reply-To: <20230605070959.moupivvi7wr4nibu@rcn-XPS-13-9305>
On Mon, Jun 05, 2023 at 09:09:59AM +0200, Ricardo Cañuelo wrote:
> [ 16.267594] Call trace:
> [ 16.267597] mtk_iommu_flush_iotlb_all+0x18/0x70
> [ 16.267603] iommu_create_device_direct_mappings.part.0+0x13c/0x21c
> [ 16.267608] iommu_setup_default_domain+0x27c/0x430
> [ 16.267611] iommu_probe_device+0x7c/0x144
> [ 16.267615] of_iommu_configure+0x114/0x200
> [ 16.267619] of_dma_configure_id+0x1e0/0x3b4
This is definitely some problem in the mtk driver.. But I can't guess
what is wrong:
static void mtk_iommu_flush_iotlb_all(struct iommu_domain *domain)
{
struct mtk_iommu_domain *dom = to_mtk_domain(domain);
if (dom->bank)
mtk_iommu_tlb_flush_all(dom->bank->parent_data);
}
We know domain != NULL since the caller checked (and de-ref'd)
it.
dom->bank should either be NULL (if pre-finalize) or a devm tracked
pointer.
parent_data is always valid if bank is valid.
So I'm at a loss.. Can you debug a bit more and find out where mtk is
crashing?
Thanks,
Jason
next parent reply other threads:[~2023-06-05 13:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <0-v5-1b99ae392328+44574-iommu_err_unwind_jgg@nvidia.com>
[not found] ` <10-v5-1b99ae392328+44574-iommu_err_unwind_jgg@nvidia.com>
[not found] ` <20230605070959.moupivvi7wr4nibu@rcn-XPS-13-9305>
2023-06-05 13:47 ` Jason Gunthorpe [this message]
2023-06-05 14:00 ` [PATCH v5 10/17] iommu: Do iommu_group_create_direct_mappings() before attach Robin Murphy
2023-06-05 14:11 ` Jason Gunthorpe
2023-06-06 5:33 ` Ricardo Cañuelo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZH3nXbVFR6JfUKpV@nvidia.com \
--to=jgg@nvidia.com \
--cc=baolu.lu@linux.intel.com \
--cc=heiko@sntech.de \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=linux-mediatek@lists.infradead.org \
--cc=llvm@lists.linux.dev \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=nicolinc@nvidia.com \
--cc=ojeda@kernel.org \
--cc=ricardo.canuelo@collabora.com \
--cc=robin.murphy@arm.com \
--cc=schnelle@linux.ibm.com \
--cc=trix@redhat.com \
--cc=will@kernel.org \
--cc=yong.wu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox