From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1D67BC77B73 for ; Sat, 3 Jun 2023 12:27:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=NdKc/jMqGPx4GztP2rKQEhUYT+Xz1wkAFWT6ucRh7C8=; b=3dIHnQef0JmltUuah67bdwvGCB G/bUg6ICHAU4QIfJNxWhupPsHgbr1c5lPqJEzrBCZfDWC6Ly+EZIFVWm4929myQiamQkzj8vhp4hR fFzcnPqJVSyQ5xLcnq8w0lLdLtwZZTWUB5/cptblnjyi81Nv58AhueNIWkx8rUtZJ3TLs4ukMfCuZ GZJy5avQFGJBvOkPmHQtoAZPNeZsdUdhmiPMlsExYHblIVSAqCFw9CTthM+qJ9gxhOTofIuP5uU5e t7YD0ud9/oy/cABZmuQXqhNVsQALXEFXCxv3Au2YXhHKv7c0RgauUU8N5y8QhaKc1Kn24PfdIKOdV QBzQGxbA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q5QLi-009jQd-0S; Sat, 03 Jun 2023 12:27:14 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q5QLe-009jOm-2b; Sat, 03 Jun 2023 12:27:12 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=NdKc/jMqGPx4GztP2rKQEhUYT+Xz1wkAFWT6ucRh7C8=; b=P2L+9i8tmKVnpGy9CqOUIgxeu0 jy2PAiKhDLB9S6If9z/dVeyWCDAJKL82PCEWUOoDZB/xTNfdx7Duowb0pEgh9y7dmmuGgNkHOp9CS QghaBMsB5zwQFk7x0KRw/H11pn0N5bg2h7XeRbc4u4CsCPcGO4ivlNJQ9aODrZmtEGnGMEdkuMrKU TigbbfjiWTXCG330nHW2bFL2GvGo+IZNaacpD3mAIXvF0xkgO3sueYhEGUR4S46vLFxBwE0ZNoIvv SoqJ0kOX70n+Wn79QQzyIF+nUwCeRTo9SO64U4OtRKIuSENSrPpOHmYo+Y6936SdHTrSOG4fA5DK/ m+j9+J+w==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:47258) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1q5QL8-0001Fn-DH; Sat, 03 Jun 2023 13:26:38 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1q5QKz-00041Y-AO; Sat, 03 Jun 2023 13:26:29 +0100 Date: Sat, 3 Jun 2023 13:26:29 +0100 From: "Russell King (Oracle)" To: =?utf-8?B?QXLEsW7DpyDDnE5BTA==?= Subject: Re: [PATCH net-next 08/30] net: dsa: mt7530: change p{5,6}_interface to p{5,6}_configured Message-ID: References: <20230522121532.86610-1-arinc.unal@arinc9.com> <20230522121532.86610-1-arinc.unal@arinc9.com> <20230522121532.86610-9-arinc.unal@arinc9.com> <20230522121532.86610-9-arinc.unal@arinc9.com> <20230524175107.hwzygo7p4l4rvawj@skbuf> <576f92b0-1900-f6ff-e92d-4b82e3436ea1@arinc9.com> <20230526130145.7wg75yoe6ut4na7g@skbuf> <7117531f-a9f2-63eb-f69d-23267e5745d0@arinc9.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <7117531f-a9f2-63eb-f69d-23267e5745d0@arinc9.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230603_052711_117896_22C0BBAB X-CRM114-Status: GOOD ( 15.66 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , linux-kernel@vger.kernel.org, Eric Dumazet , mithat.guner@xeront.com, Florian Fainelli , erkin.bozoglu@xeront.com, Richard van Schagen , Jakub Kicinski , Paolo Abeni , Landen Chao , Richard van Schagen , Sean Wang , DENG Qingfang , linux-mediatek@lists.infradead.org, Bartel Eerdekens , Matthias Brugger , linux-arm-kernel@lists.infradead.org, AngeloGioacchino Del Regno , netdev@vger.kernel.org, Daniel Golle , Vladimir Oltean , "David S. Miller" Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Sat, Jun 03, 2023 at 03:15:52PM +0300, Arınç ÜNAL wrote: > On 26.05.2023 16:01, Vladimir Oltean wrote: > > Ok, but given the premise of this patch set, that phylink is always available, > > does it make sense for mt7531_cpu_port_config() and mt7988_cpu_port_config() > > to manually call phylink methods? > > All I know is that that's how the implementation of phylink's PCS support in > this driver works. It expects the MAC to be set up before calling > mt753x_phylink_pcs_link_up() and mt753x_phylink_mac_link_up(). First, do you see a message printed for the DSA device indicating that a link is up, without identifying the interface? For example, with mv88e6xxx: mv88e6085 f1072004.mdio-mii:04: Link is Up - 1Gbps/Full - flow control off as opposed to a user port which will look like this: mv88e6085 f1072004.mdio-mii:04 lan1: Link is Up - 1Gbps/Full - flow control rx/tx If you do, that's likely for the CPU port, and indicates that phylink is being used for the CPU port. If not, then you need to investigate whether you've provided the full description in DT for the CPU port. In other words, phy-mode and a fixed-link specification or in-band mode. Given that, you should have no need to make explicit calls to your mac_config, pcs_link_up and mac_link_up functions. If you need to make these calls, it suggests that phylink is not being used for the CPU port. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!