Re: [PATCH v2 00/10] pinctrl: Provide NOIRQ PM helper and use it

Andy Shevchenko
2023-08-21T17:00:54Z

On Mon, Jul 17, 2023 at 08:28:11PM +0300, Andy Shevchenko wrote:
> Intel pin control drivers use NOIRQ variant of the PM callbacks.
> Besides that several other drivers do similar. Provide a helper
> to make them smaller and less error prone against different
> kernel configurations (with possible defined but not used variables).
>
> The idea is to have an immutable branch that PM tree can pull as well as
> main pin control one. We also can do other way around, if Rafael prefers
> that.

I have partially applied the series to my review and testing queue with
the following changes (besides the tags added):
- split pm_ptr() patches to be first with lynxpoint commit message updated
- fixed wording in the pm.h comment
- amended cherryview to wrap long line
- explained __maybe_unused and pm_ptr() changes in at91 commit message
- added pm_sleep_ptr() and explained that in the tegra commit message
- renesas and mvebu went as is
- intel and mediatek left aside for better rework

drivers/pinctrl/intel/pinctrl-baytrail.c | 11 +++--------
drivers/pinctrl/intel/pinctrl-cherryview.c | 10 +++-------
drivers/pinctrl/intel/pinctrl-lynxpoint.c | 7 +++----
drivers/pinctrl/mvebu/pinctrl-armada-37xx.c | 14 +++-----------
drivers/pinctrl/pinctrl-at91.c | 10 ++++------
drivers/pinctrl/renesas/core.c | 16 +++++++---------
drivers/pinctrl/tegra/pinctrl-tegra.c | 5 +----
drivers/pinctrl/tegra/pinctrl-tegra210.c | 2 +-
include/linux/pm.h | 9 +++++++++
9 files changed, 34 insertions(+), 50 deletions(-)

--
With Best Regards,
Andy Shevchenko