From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>,
Linus Walleij <linus.walleij@linaro.org>,
Balsam CHIHI <bchihi@baylibre.com>,
Claudiu Beznea <claudiu.beznea@microchip.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Thierry Reding <thierry.reding@gmail.com>,
Paul Cercueil <paul@crapouillou.net>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-renesas-soc@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-pm@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Len Brown <len.brown@intel.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Gregory Clement <gregory.clement@bootlin.com>,
Sean Wang <sean.wang@kernel.org>,
Jonathan Hunter <jonathanh@nvidia.com>,
Ludovic Desroches <ludovic.desroches@microchip.com>,
Pavel Machek <pavel@ucw.cz>,
Matthias Brugger <matthias.bgg@gmail.com>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>
Subject: Re: [PATCH v2 04/10] pinctrl: intel: Switch to use DEFINE_NOIRQ_DEV_PM_OPS() helper
Date: Tue, 18 Jul 2023 16:53:29 +0300 [thread overview]
Message-ID: <ZLaZWcyJAnQMK87f@smile.fi.intel.com> (raw)
In-Reply-To: <20230718110451.00001227@Huawei.com>
On Tue, Jul 18, 2023 at 11:04:51AM +0100, Jonathan Cameron wrote:
> On Mon, 17 Jul 2023 20:28:15 +0300
> Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
...
> > EXPORT_SYMBOL_GPL(intel_pinctrl_resume_noirq);
>
> Can you check if this is successfully removed? I think it won't be.
> Not immediately obvious how to tidy that up given these are used
> in a macro called from lots of drivers.
That's what Paul noticed I think with his proposal to export only the ops
variable and make these to be static.
> Maybe just leaving the ifdef is best we can do here.
See above.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-07-19 5:03 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230717172821.62827-1-andriy.shevchenko@linux.intel.com>
[not found] ` <20230717172821.62827-3-andriy.shevchenko@linux.intel.com>
2023-07-17 19:20 ` [PATCH v2 02/10] pinctrl: baytrail: Make use of pm_ptr() Paul Cercueil
2023-07-18 9:53 ` Jonathan Cameron
2023-07-18 13:50 ` Andy Shevchenko
[not found] ` <20230717172821.62827-6-andriy.shevchenko@linux.intel.com>
2023-07-17 19:23 ` [PATCH v2 05/10] pinctrl: lynxpoint: " Paul Cercueil
2023-07-18 10:06 ` Jonathan Cameron
2023-07-18 13:55 ` Andy Shevchenko
[not found] ` <20230717172821.62827-8-andriy.shevchenko@linux.intel.com>
2023-07-17 19:06 ` [PATCH v2 07/10] pinctrl: mediatek: Switch to use DEFINE_NOIRQ_DEV_PM_OPS() helper Paul Cercueil
2023-07-17 19:36 ` Andy Shevchenko
2023-07-17 19:56 ` Paul Cercueil
2023-07-18 12:48 ` Andy Shevchenko
2023-07-18 9:47 ` AngeloGioacchino Del Regno
2023-07-18 12:46 ` Andy Shevchenko
2023-07-18 10:07 ` Jonathan Cameron
[not found] ` <20230717172821.62827-4-andriy.shevchenko@linux.intel.com>
2023-07-17 19:21 ` [PATCH v2 03/10] pinctrl: cherryview: " Paul Cercueil
2023-07-17 19:27 ` Andy Shevchenko
2023-07-17 19:28 ` Paul Cercueil
2023-07-18 9:54 ` Jonathan Cameron
2023-07-18 13:51 ` Andy Shevchenko
[not found] ` <20230717172821.62827-2-andriy.shevchenko@linux.intel.com>
2023-07-17 19:19 ` [PATCH v2 01/10] pm: Introduce " Paul Cercueil
2023-07-17 19:25 ` Andy Shevchenko
2023-07-18 9:55 ` Jonathan Cameron
2023-07-18 10:01 ` Geert Uytterhoeven
2023-07-20 19:00 ` Rafael J. Wysocki
[not found] ` <20230717172821.62827-5-andriy.shevchenko@linux.intel.com>
2023-07-17 19:02 ` [PATCH v2 04/10] pinctrl: intel: Switch to use " Paul Cercueil
2023-07-17 19:33 ` Andy Shevchenko
2023-07-17 19:55 ` Paul Cercueil
2023-07-18 12:57 ` Andy Shevchenko
2023-07-18 13:55 ` Paul Cercueil
2023-07-18 10:04 ` Jonathan Cameron
2023-07-18 13:53 ` Andy Shevchenko [this message]
2023-07-19 10:37 ` Jonathan Cameron
[not found] ` <20230717172821.62827-7-andriy.shevchenko@linux.intel.com>
2023-07-17 19:25 ` [PATCH v2 06/10] pinctrl: at91: " Paul Cercueil
2023-07-17 19:35 ` Andy Shevchenko
2023-07-18 10:06 ` Jonathan Cameron
2023-07-18 14:48 ` claudiu beznea
[not found] ` <20230717172821.62827-9-andriy.shevchenko@linux.intel.com>
2023-07-17 19:26 ` [PATCH v2 08/10] pinctrl: mvebu: " Paul Cercueil
2023-07-18 10:08 ` Jonathan Cameron
[not found] ` <20230717172821.62827-10-andriy.shevchenko@linux.intel.com>
2023-07-17 19:12 ` [PATCH v2 09/10] pinctrl: renesas: " Paul Cercueil
2023-07-17 19:38 ` Andy Shevchenko
2023-07-17 19:57 ` Paul Cercueil
2023-07-18 10:05 ` Geert Uytterhoeven
2023-07-18 12:43 ` Andy Shevchenko
2023-07-18 10:01 ` Geert Uytterhoeven
2023-07-18 10:10 ` Jonathan Cameron
[not found] ` <20230717172821.62827-11-andriy.shevchenko@linux.intel.com>
2023-07-17 19:14 ` [PATCH v2 10/10] pinctrl: tegra: " Paul Cercueil
2023-07-17 19:39 ` Andy Shevchenko
2023-07-18 7:45 ` Thierry Reding
2023-07-18 8:42 ` Paul Cercueil
2023-07-18 11:41 ` Thierry Reding
2023-07-18 11:55 ` Paul Cercueil
2023-07-18 12:50 ` Andy Shevchenko
2023-07-18 13:20 ` Thierry Reding
2023-07-18 13:48 ` Paul Cercueil
2023-07-18 12:53 ` Andy Shevchenko
2023-07-18 7:46 ` Thierry Reding
2023-07-18 10:11 ` Jonathan Cameron
2023-07-18 11:38 ` Thierry Reding
2023-07-18 12:01 ` Paul Cercueil
2023-07-18 13:07 ` Thierry Reding
2023-08-21 17:00 ` [PATCH v2 00/10] pinctrl: Provide NOIRQ PM helper and use it Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZLaZWcyJAnQMK87f@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andrew@lunn.ch \
--cc=angelogioacchino.delregno@collabora.com \
--cc=bchihi@baylibre.com \
--cc=claudiu.beznea@microchip.com \
--cc=geert+renesas@glider.be \
--cc=gregory.clement@bootlin.com \
--cc=jonathanh@nvidia.com \
--cc=len.brown@intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=ludovic.desroches@microchip.com \
--cc=matthias.bgg@gmail.com \
--cc=mika.westerberg@linux.intel.com \
--cc=paul@crapouillou.net \
--cc=pavel@ucw.cz \
--cc=rafael@kernel.org \
--cc=sean.wang@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=thierry.reding@gmail.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).