From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9F4C7C4332F for ; Tue, 12 Dec 2023 09:43:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=tLGoCCqEwS5Rzm6vkLqOJ5b4zPigqMnDTy/qrc3lO8U=; b=QCKE7q6Cn8NR3r6tuxM+riDXeD 8shrmdW+wz10X5CPDM8X57E/aYS8ZAjVn2SmYJU0moxE6FYlTVcszliNxx6R/ljpJncA/LbPZpRGf ADGE6HKXDlssh4XYYdElBYf7L/T1WtP/bW57cSvs4uiAeU6hyiXnYmScjJzvi1KITnlkd0vBTZ4aD N5b9lQmbx00+VdixAyYovvECxLrlkQ+H6eQ01ga1vj6vi+VdJyBuHok45PZYFKmbewZnUzBO1+9Yt ESAAOq1eijwWWMhpVHS5sfxc2F3lTZQMjoB7yriwQOzhI7+r2RHYgGqysAIkY4kPOKgCX0uh/I4GP OhJj+8YQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rCzI4-00BEFW-1U; Tue, 12 Dec 2023 09:43:00 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rCzI1-00BEEy-1Y for linux-mediatek@lists.infradead.org; Tue, 12 Dec 2023 09:42:59 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 6EDFACE13AD; Tue, 12 Dec 2023 09:42:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 12753C433C8; Tue, 12 Dec 2023 09:42:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702374173; bh=muw+Ud0YjfawGe9Cq2DB3pHB3fHCLByUAzvENR+KUes=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=QZZDaECK3qYLvq+KzWWIGu/tekcFSES+1JnM7EEKKVENT3sxhN5vJdU17UqdlLvU7 LmDhRg8bQP8EBl+ppzA+4IH6LqqHZDzrgnVNsyL2Hyi6nBV2dRZtr0KxawXrv5godC Nl7g2BCzCHmLWdndiQbrwn+8NAcUvMZxMQAT2LQB4KkylKPJ5jT218UbZxOqF1ylUM hHLXKkjR6kjTEFM7MvOjrqQCaJQITRvM9EvIQl7TYlOdMzBNr0f5t21Kx2+VFsWtii KrNHpXrGSV9JYkUreY1d8xDzyQwc95ivuQuE7bnxrebWzaNonWf9CSKY2T2JUSyV9i rSJSizzbKr24Q== Date: Wed, 18 Oct 2023 10:09:10 +0200 From: Lorenzo Bianconi To: Kalle Valo Cc: Deren Wu , Felix Fietkau , Jakub Kicinski , "David S . Miller" , Eric Dumazet , Paolo Abeni , Sean Wang , Soul Huang , Ming Yen Hsieh , Leon Yen , Eric-SY Chang , KM Lin , Robin Chiu , CH Yeh , Posh Sun , Stella Chang , Quan Zhou , Ryder Lee , Shayne Chen , AngeloGioacchino Del Regno , linux-wireless , linux-mediatek Subject: Re: [next v2] wifi: mt76: mt7921: fix kernel panic by accessing invalid 6GHz channel info Message-ID: References: <871qds31rw.fsf@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="oyYY5ye5rkYVGNeM" Content-Disposition: inline In-Reply-To: <871qds31rw.fsf@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231212_014257_983830_3E22990A X-CRM114-Status: GOOD ( 12.29 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org --oyYY5ye5rkYVGNeM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > Deren Wu writes: >=20 > > From: Ming Yen Hsieh > > > > When the chip not support 6GHz capability, the channels of 6GHz informa= tion > > should not be updated. > > > > May get the stacktrace without this patch. > > <1>[ 19.442078] Unable to handle kernel NULL pointer dereference at > > virtual address 0000000000000014 > > <1>[ 19.457535] Mem abort info: > > <1>[ 19.465329] ESR =3D 0x0000000096000004 > > <1>[ 19.473295] EC =3D 0x25: DABT (current EL), IL =3D 32 bits > > <1>[ 19.482354] SET =3D 0, FnV =3D 0 > > <1>[ 19.489143] EA =3D 0, S1PTW =3D 0 > > <1>[ 19.495991] FSC =3D 0x04: level 0 translation fault > > <1>[ 19.504554] Data abort info: > > <1>[ 19.511111] ISV =3D 0, ISS =3D 0x00000004, ISS2 =3D 0x00000000 > > <1>[ 19.520269] CM =3D 0, WnR =3D 0, TnD =3D 0, TagAccess =3D 0 > > <1>[ 19.528988] GCS =3D 0, Overlay =3D 0, DirtyBit =3D 0, Xs =3D 0 > > <1>[ 19.537960] user pgtable: 4k pages, 48-bit VAs, pgdp=3D0000000102= 7a9000 > > <1>[ 19.548014] [0000000000000014] pgd=3D0000000000000000, p4d=3D0000= 00000000 > > <0>[ 19.558429] Internal error: Oops: 0000000096000004 [#1] PREEMPT S= MP > > <4>[ 19.568270] Modules linked in: mt7921e mt7921_common mt792x_lib > > mt76_connac_lib mt76 mac80211 btusb btintel cfg80211 btmtk snd_sof_ipc_= msg_ > > btrtl snd_sof_ipc_flood_test btbcm bluetooth snd_sof_mt8195 uvcvideo > > mtk_adsp_common snd_sof_xtensa_dsp uvc snd_sof_of snd_sof videobuf2_vma= lloc > > ecdh_generic ecc snd_sof_utils cros_ec_lid_angle cros_ec_sensors crct10= dif_ > > cros_ec_sensors_core cros_usbpd_logger crypto_user fuse ip_tables ipv6 > > <4>[ 19.614237] CPU: 1 PID: 105 Comm: kworker/1:1 Not tainted > > 6.6.0-rc6-next-20231017+ #324 > > <4>[ 19.625957] Hardware name: Acer Tomato (rev2) board (DT) > > <4>[ 19.634970] Workqueue: events mt7921_init_work [mt7921_common] > > <4>[ 19.644522] pstate: 60400009 (nZCv daif +PAN -UAO -TCO -DIT -SSBS= BTY > > <4>[ 19.655182] pc : mt7921_regd_notifier+0x180/0x290 [mt7921_common] > > <4>[ 19.664983] lr : mt7921_regd_notifier+0xd4/0x290 [mt7921_common] > > <4>[ 19.674679] sp : ffff800080acba80 > > <4>[ 19.681649] x29: ffff800080acba80 x28: 0000000000000000 x27: ffff= 4faf > > <4>[ 19.692483] x26: 0000000000000000 x25: 0000000000000000 x24: ffff= 4faf > > <4>[ 19.703294] x23: 00000000ffffe926 x22: ffff4faf16031fa0 x21: 0000= 0000 > > <4>[ 19.714108] x20: 000000000000001c x19: ffff4faf16ba6f40 x18: 0000= 0000 > > <4>[ 19.724928] x17: 0000000000000000 x16: ffffac6b891c2750 x15: ffff= 8000 > > <4>[ 19.735722] x14: 0000000000000180 x13: 0000000000000000 x12: 0000= 0000 > > <4>[ 19.746478] x11: 0000000000000002 x10: ffff4faf01c21780 x9 : ffff= ac6b > > <4>[ 19.757214] x8 : 00000000006c0000 x7 : ffffac6b6b020cf0 x6 : ffff= ac6b > > <4>[ 19.767945] x5 : ffffac6b6b020d00 x4 : ffffac6b6b020cf8 x3 : ffff= 4faf > > <4>[ 19.778648] x2 : 0000000000000000 x1 : 000000000000001c x0 : 0000= 0000 > > <4>[ 19.789366] Call trace: > > <4>[ 19.795381] mt7921_regd_notifier+0x180/0x290 [mt7921_common] > > <4>[ 19.804675] wiphy_update_regulatory+0x2bc/0xa08 [cfg80211] > > <4>[ 19.813864] wiphy_regulatory_register+0x4c/0x88 [cfg80211] > > <4>[ 19.823029] wiphy_register+0x75c/0x8d0 [cfg80211] > > <4>[ 19.831446] ieee80211_register_hw+0x70c/0xc10 [mac80211] > > <4>[ 19.840479] mt76_register_device+0x168/0x2e8 [mt76] > > <4>[ 19.849008] mt7921_init_work+0xdc/0x250 [mt7921_common] > > <4>[ 19.857817] process_one_work+0x148/0x3c0 > > <4>[ 19.865292] worker_thread+0x32c/0x450 > > <4>[ 19.872489] kthread+0x11c/0x128 > > <4>[ 19.879173] ret_from_fork+0x10/0x20 > > <0>[ 19.886153] Code: f0000041 9100a021 94000aef aa0003f9 (b9401780) > > <4>[ 19.895634] ---[ end trace 0000000000000000 ]--- > > > > Reported-by: AngeloGioacchino Del Regno > > Closes: https://lore.kernel.org/all/927e7d50-826d-4c92-9931-3c59b18c694= 5@collabora.com/ > > Fixes: 09382d8f8641 ("mt7921: update the channel usage when the regd do= main changed") > > Signed-off-by: Ming Yen Hsieh > > Signed-off-by: Deren Wu > > Tested-by: AngeloGioacchino Del Regno > > Reviewed-by: AngeloGioacchino Del Regno >=20 > I assumed I should take this directly to net-next so assigned to me on > patchwork. Felix&Lorenzo, ack? Fine to me. Regards, Lorenzo >=20 > --=20 > https://patchwork.kernel.org/project/linux-wireless/list/ >=20 > https://wireless.wiki.kernel.org/en/developers/documentation/submittingpa= tches --oyYY5ye5rkYVGNeM Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCZS+SowAKCRA6cBh0uS2t rGpkAQDZhGGAUcw9Dh76XkrAld+ZUdn5iroV0rrxkzsMCKpJlQEAt0vb6Tqj30h5 7JtqAzP9eyWQ1Xn7KwJV/Zrr6HMgtg4= =hYdm -----END PGP SIGNATURE----- --oyYY5ye5rkYVGNeM--