From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A3FF8C4167B for ; Tue, 12 Dec 2023 16:43:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=JUjxYNID2Vp9pNVqTeRuKulUH1w6zALGiddUOQd3VnI=; b=dZpc70yoeO5JnlgYEVS0sWFYIs B4MygdiQ7WEUYMt1V4w+hOEF5/QlEA2HAnJl7+Y04rkwR/0ntKo2tIRGjKjTwuyAafPg19LZVvk9r 7ukeG3Q4asvZ4S7IHZNtRDtkDzOhJZXa2GDCSIXWiKTaYu5LVKBgGtiY5SoIuSQ1fm/8QW3zC9R7o XBFAi+psyClVXUDgroAQVmvAbuyami4Hw4qLH1CNYaGeWNbVpRD3KIn5aC8IHdifeaBBK4hLyXqOU 8dd0nA7Nr573lrfTTNi1vyVScrijHGKmF+egiHHR7z/9WsSGPgzgG7bYQIUUd49TSXelo0krqWECx Frzt85lQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rD5qq-00CH0G-1V; Tue, 12 Dec 2023 16:43:20 +0000 Received: from pidgin.makrotopia.org ([185.142.180.65]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rD5qn-00CGzA-2d; Tue, 12 Dec 2023 16:43:19 +0000 Received: from local by pidgin.makrotopia.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.96.2) (envelope-from ) id 1rD5qP-0006en-2c; Tue, 12 Dec 2023 16:42:55 +0000 Date: Tue, 12 Dec 2023 16:42:45 +0000 From: Daniel Golle To: Conor Dooley Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chunfeng Yun , Vinod Koul , Kishon Vijay Abraham I , Felix Fietkau , John Crispin , Sean Wang , Mark Lee , Lorenzo Bianconi , Matthias Brugger , AngeloGioacchino Del Regno , Andrew Lunn , Heiner Kallweit , Russell King , Alexander Couzens , Qingfang Deng , SkyLake Huang , Philipp Zabel , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-phy@lists.infradead.org Subject: Re: [RFC PATCH net-next v3 1/8] dt-bindings: phy: mediatek,xfi-pextp: add new bindings Message-ID: References: <20231212-renderer-strobe-2b46652cd6e7@spud> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <20231212-renderer-strobe-2b46652cd6e7@spud> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231212_084317_856121_8FA55AA3 X-CRM114-Status: GOOD ( 13.46 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Tue, Dec 12, 2023 at 04:21:38PM +0000, Conor Dooley wrote: > On Tue, Dec 12, 2023 at 03:46:26AM +0000, Daniel Golle wrote: >=20 > > + mediatek,usxgmii-performance-errata: > > + $ref: /schemas/types.yaml#/definitions/flag > > + description: > > + USXGMII0 on MT7988 suffers from a performance problem in 10GBase= -R > > + mode which needs a work-around in the driver. The work-around is > > + enabled using this flag. >=20 > Why do you need a property for this if you know that it is present on > the MT7988? Because it is only present in one of the two SerDes channels. Channel 0 needs the work-around, Channel 1 doesn't. See also this commit in the vendor driver for reference[1]. We previously discussed that[2] and it was decided that a property would be the prefered way to represent this as there aren't any other per-instance differences which would justify another compatible. [1]: https://git01.mediatek.com/plugins/gitiles/openwrt/feeds/mtk-openwrt-f= eeds/+/a500d94cd47e279015ce22947e1ce396a7516598%5E%21/#F0 [2]: https://patchwork.kernel.org/comment/25592845/