linux-mediatek.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] wifi: mt76: mt7925: fix the wrong data type for scan command
@ 2024-01-04  9:48 Mingyen Hsieh
  2024-01-04 10:16 ` Lorenzo Bianconi
  0 siblings, 1 reply; 2+ messages in thread
From: Mingyen Hsieh @ 2024-01-04  9:48 UTC (permalink / raw)
  To: nbd, lorenzo
  Cc: deren.wu, Sean.Wang, Soul.Huang, Leon.Yen, Eric-SY.Chang, km.lin,
	robin.chiu, ch.yeh, posh.sun, Quan.Zhou, Ryder.Lee, Shayne.Chen,
	linux-wireless, linux-mediatek, Ming Yen Hsieh

From: Ming Yen Hsieh <mingyen.hsieh@mediatek.com>

For the member of 'struct scan_req_tlv', replace data type of
func_mask_ext from 'u8' to 'u32'.

Signed-off-by: Ming Yen Hsieh <mingyen.hsieh@mediatek.com>
---
 drivers/net/wireless/mediatek/mt76/mt7925/mcu.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/mediatek/mt76/mt7925/mcu.h b/drivers/net/wireless/mediatek/mt76/mt7925/mcu.h
index 3c41e21303b1..82b7e277397f 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7925/mcu.h
+++ b/drivers/net/wireless/mediatek/mt76/mt7925/mcu.h
@@ -208,7 +208,7 @@ struct scan_req_tlv {
 	__le16 channel_dwell_time; /* channel Dwell interval */
 	__le16 timeout_value;
 	__le16 probe_delay_time;
-	u8 func_mask_ext;
+	u32 func_mask_ext;
 };
 
 struct scan_ssid_tlv {
-- 
2.18.0



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] wifi: mt76: mt7925: fix the wrong data type for scan command
  2024-01-04  9:48 [PATCH] wifi: mt76: mt7925: fix the wrong data type for scan command Mingyen Hsieh
@ 2024-01-04 10:16 ` Lorenzo Bianconi
  0 siblings, 0 replies; 2+ messages in thread
From: Lorenzo Bianconi @ 2024-01-04 10:16 UTC (permalink / raw)
  To: Mingyen Hsieh
  Cc: nbd, deren.wu, Sean.Wang, Soul.Huang, Leon.Yen, Eric-SY.Chang,
	km.lin, robin.chiu, ch.yeh, posh.sun, Quan.Zhou, Ryder.Lee,
	Shayne.Chen, linux-wireless, linux-mediatek

[-- Attachment #1: Type: text/plain, Size: 995 bytes --]

On Jan 04, Mingyen Hsieh wrote:
> From: Ming Yen Hsieh <mingyen.hsieh@mediatek.com>
> 
> For the member of 'struct scan_req_tlv', replace data type of
> func_mask_ext from 'u8' to 'u32'.
> 
> Signed-off-by: Ming Yen Hsieh <mingyen.hsieh@mediatek.com>
> ---
>  drivers/net/wireless/mediatek/mt76/mt7925/mcu.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/mediatek/mt76/mt7925/mcu.h b/drivers/net/wireless/mediatek/mt76/mt7925/mcu.h
> index 3c41e21303b1..82b7e277397f 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt7925/mcu.h
> +++ b/drivers/net/wireless/mediatek/mt76/mt7925/mcu.h
> @@ -208,7 +208,7 @@ struct scan_req_tlv {
>  	__le16 channel_dwell_time; /* channel Dwell interval */
>  	__le16 timeout_value;
>  	__le16 probe_delay_time;
> -	u8 func_mask_ext;
> +	u32 func_mask_ext;

should it be __le32? (even if it is not used yet)

Regards,
Lorenzo

>  };
>  
>  struct scan_ssid_tlv {
> -- 
> 2.18.0
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-01-04 10:16 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-04  9:48 [PATCH] wifi: mt76: mt7925: fix the wrong data type for scan command Mingyen Hsieh
2024-01-04 10:16 ` Lorenzo Bianconi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).