From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 196FAC3601E for ; Thu, 10 Apr 2025 07:53:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=3OcYzRuci4DVDvTV5wL2NFanwr7+BVH3bP+rdckE45M=; b=VTaFeuTA0EAot+ydRDMHb43jIP 30A9HSK3q4qwNti6fgMS9T24k6hAk8AFNBIJcrNr8DR8N0uW1G6n+wzH32bWSsyBNIk9ldWqNwXvP dDi3tetXgeAIN3zlcZwGv8nRl2apk9zeykwH1wUsg5hwyMFaSY7aOHtTHiaLdT7ZHUdvoeoyNYnjS xin6TEkQU6mLVjsfth3Bc7PcfEPNrN4TCCIzUUs10D8J/mmrgPO9c9m/WCOIh8c+ZngoD4wVx255w tLfei2IaLAAfHESIEpmoW8aLLo0kx00dHZ9j5qUT9LhmxUN2gvnqXTYGiXDQ8VxPA9Shzj/4x5Cxg /TySjcLw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1u2mic-00000009dC9-45uW; Thu, 10 Apr 2025 07:53:02 +0000 Received: from mail-ed1-x529.google.com ([2a00:1450:4864:20::529]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1u2m42-00000009UBn-2KGz for linux-mediatek@lists.infradead.org; Thu, 10 Apr 2025 07:11:08 +0000 Received: by mail-ed1-x529.google.com with SMTP id 4fb4d7f45d1cf-5efe8d9eb12so723940a12.1 for ; Thu, 10 Apr 2025 00:11:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1744269064; x=1744873864; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=3OcYzRuci4DVDvTV5wL2NFanwr7+BVH3bP+rdckE45M=; b=yUs/O4dwK1DNXbpsQedSsErMEAN7SOtI0a8OqOXOE27FikQyIKhlT5d4gLKHT0jv8g gd0FnHwqeCJM3uZwlLzoXzvTXhoLa5wHnMMcKa3zjwkvIlcyMcE/6c4HnVbBtaANv9Iv p2JRdNmVeP8QXfq9q4A1gWLATNzuFmV56HPSS3BJiB5s9jR/UnF5n9OYy1mk5WA9XRov 9aNPYipgq+GSW4clzCpRR9NFyuDDN4nqgJuJ8Ivzo0GPoizF24hO7SnUQBCL0J1y3mbU wWreQZ4/SCTEKGhq20/+i91oRaxoa8ORn0QpK/0AkxeeXTe62a0LBJhVJOMqG2kbV+0n LLgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744269064; x=1744873864; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=3OcYzRuci4DVDvTV5wL2NFanwr7+BVH3bP+rdckE45M=; b=w0P8Sasxylv2ZIVFhj+OQmCzodKfG5Ta0wjYQE9/sHHU+BPCYQKNs3zPOoPt1ZrPG8 E9EQf1ZFgqps7BO20ItJPuKXUhgEJodwUAZYX6oKo8YaSRvkb76BjiwTWKe4R7vkSuF8 Zghrrfiv+MR2DgRdJrtJvlH5Q9Ce0dJ6NoiGJMI0IrudWquHwASRZWHLvW9KbWV8Oyp0 PC46fjS9dZymp4G7Zi1EEdshqKRNZ2Rkbe+DVjbBdJuXE/1t8pCVCMFE010fBdJdUt4+ /hBrk6efZxUW4ilmTSjpTCSvlGuwJ9DCjR0e5/KQ6GQkwWwNVlaYvSR+RXkbkkumr44p fNMQ== X-Forwarded-Encrypted: i=1; AJvYcCXVbftOx1vo1LJMI6LugP/hU2oIXBms7Q4oPYGS1+9/N7nrioyF2a/p1JyVqspsIPyFabwaNApz+3QjOeAtlA==@lists.infradead.org X-Gm-Message-State: AOJu0YxCXyVZ2ImbnDu3Jg3DDVUitBA/INc29+l+IDoMpkF6zW+hFSuH sf4mEHhvDZkkcwCvPijVON3bCCzcSewoXOK0Tn6qIS8SfxqtpxtXy2hM/xCfNWg= X-Gm-Gg: ASbGncta0hxoB9eXyvnHhZky3J9z9GHgti2grdoUgW4bi2Dz2rCRmZGVP5AbIihVUKK omQToR/sJIJRM9Ls5KalxmjxHrvIO4TOudOiesC2L0hL9gi5zjJ6yL9HzGLwv339mM+fGHCSnPu Wp6MTinhtl8LnlIO8/DkSAPgZajS40d6t0jboXJkVgQ+Dbkx/44kO/y+FsolCH1zpZLhAbA1PrH gglmcdWH45VY2qqxXqjt4/JTMUvuXOS7AriwD77Ohx0TbYPFe4shcw6fcLk8glpZ+m/GJlQXfy7 cRn1JIeC95ujHXvLpuno1TgWrIiM1EBwgFBAnUdKXFzW3AvNzLc= X-Google-Smtp-Source: AGHT+IETfspJRi9jQhAHy7G+NAIq/HN8GQhfewV/oWn/J+Tx4X7F7gfIyNI7Jkc9sjEejt3cHqWuJA== X-Received: by 2002:a17:907:da0:b0:aca:a1d7:a830 with SMTP id a640c23a62f3a-acabd185e69mr120878666b.13.1744269064280; Thu, 10 Apr 2025 00:11:04 -0700 (PDT) Received: from linaro.org ([2a02:2454:ff21:ef30:ae8a:4fb8:9c71:6be]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-acaa1cb3fcdsm219989266b.107.2025.04.10.00.11.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Apr 2025 00:11:03 -0700 (PDT) Date: Thu, 10 Apr 2025 09:10:57 +0200 From: Stephan Gerhold To: Konrad Dybcio Cc: Ulf Hansson , "Rob Herring (Arm)" , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , "Rafael J. Wysocki" , Viresh Kumar , Matthias Brugger , AngeloGioacchino Del Regno , Vincenzo Frascino , Liviu Dudau , Sudeep Holla , Lorenzo Pieralisi , Bjorn Andersson , Konrad Dybcio , Thomas Bogendoerfer , Viresh Kumar , Nishanth Menon , Stephen Boyd , zhouyanjie@wanyeetech.com, Conor Dooley , Nicolas Ferre , Claudiu Beznea , Steen Hegelund , Daniel Machon , UNGLinuxDriver@microchip.com, Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Heiko Stuebner , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Geert Uytterhoeven , Magnus Damm , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-mips@vger.kernel.org, imx@lists.linux.dev, linux-rockchip@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-renesas-soc@vger.kernel.org, Manivannan Sadhasivam Subject: Re: [PATCH 09/19] arm: dts: qcom: sdx55/sdx65: Fix CPU power-domain-names Message-ID: References: <20250403-dt-cpu-schema-v1-0-076be7171a85@kernel.org> <20250403-dt-cpu-schema-v1-9-076be7171a85@kernel.org> <03011a33-174b-4027-bdd2-043aa685380b@oss.qualcomm.com> <66f8d957-f7a5-4aec-b8e7-5bcc7ff7f569@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <66f8d957-f7a5-4aec-b8e7-5bcc7ff7f569@oss.qualcomm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250410_001106_718603_28A2B3C4 X-CRM114-Status: GOOD ( 21.70 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Wed, Apr 09, 2025 at 08:35:29PM +0200, Konrad Dybcio wrote: > On 4/7/25 6:27 PM, Ulf Hansson wrote: > > On Fri, 4 Apr 2025 at 22:41, Konrad Dybcio > > wrote: > >> > >> On 4/4/25 4:59 AM, Rob Herring (Arm) wrote: > >>> "rpmhpd" is not documented nor used anywhere. As the enable-method is > >>> "psci" use "psci" for the power-domain name. > >>> > >>> Signed-off-by: Rob Herring (Arm) > >>> --- > >> > >> "psci" is what we want here, but these platforms require some more > >> massaging.. > > > > So this isn't for CPU performance scaling? > > Nope! > Huh, this is definitely "perf" (= cpufreq) and not "psci" (= cpuidle). If you run blame on this line you get to: commit 0ec7bde7b590f8efa5823df3b52b32dd373060ff Author: Manivannan Sadhasivam Date: Thu Apr 8 22:34:45 2021 +0530 ARM: dts: qcom: sdx55: Add CPUFreq support Add CPUFreq support to SDX55 platform using the cpufreq-dt driver. There is no dedicated hardware block available on this platform to carry on the CPUFreq duties. Hence, it is accomplished using the CPU clock and regulators tied together by the operating points table. https://web.git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=0ec7bde7b590f8efa5823df3b52b32dd373060ff The OPP table looks like it's supposed to set SDX55_CX performance states according to the chosen CPU frequency. MSM8909 has a similar setup where the CPU is supplied directly by VDDCX and we describe that with "perf" too [1]. What I don't understand is why the name "rpmhpd" does not appear in any driver. The MSM8909 setup goes via qcom-cpufreq-nvmem, where "perf" is directly assigned for cpufreq scaling. I can only think of two possible reasons: - The power domain is implicitly attached to the OPP table(?), because there is just a single power domain defined on the CPU, or - This was never working correctly. For both cases, I think it would be best to change the power domain name to "perf" like Uffe suggested. Thanks, Stephan [1]: https://lore.kernel.org/linux-pm/20231018-msm8909-cpufreq-v2-0-0962df95f654@kernkonzept.com/