From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B0E3EC4828F for ; Sun, 4 Feb 2024 14:18:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=h/meM589cBbKRoq1Yh/j2VWjBxZZoI+3UVuISqojP0I=; b=LwOJYkcPfJaC8gAPyfHYtKGH+x S0ajrhEyXJwZ8MCcGpaA9wZyRPpy8pHTCcOTP3q3utkzXnpMWssAqiUAaXr3EXmICRmwQucw/cBRS 1OLh9y9F+gmUS80OWAIXSDQCOclK+HCa70xZusoMuKxi7VRAfb3E8Rn5TNjvUGx+NEU4JxYAYLiL0 2or2LHdd+XXEVHCB9IHgDhroLkbEFG2juVC3bw7qqb9ekfAjOBRlHLT1TTo2FbXKgQz7ULHA0I5P/ EEe4ftjXADcIvYth4LCruTLagK3kEyQIDgpOZ7IK6limHlFP/SCiYBjGOvKhR/cdn/HO3fBaD5blq KNSAE0Jw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rWdKj-00000000wXN-0vzK; Sun, 04 Feb 2024 14:18:57 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rWdKf-00000000wWc-0BQ5; Sun, 04 Feb 2024 14:18:54 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=h/meM589cBbKRoq1Yh/j2VWjBxZZoI+3UVuISqojP0I=; b=czEZ28UZCVcwyVfK6IYz46L35k oS8E6Vz8Ji1Vpyh5NGltpe245f77llZAn+oQy9b/Jizwz/ipsrnMhl/7sNilHLxnPSWMwmsytR4MO MxUfbMhGTcqkh9D05VB0YsWC5lBprBPZEi4rkcqesMHn0VzvAtzc64Nhad2bK0jP8NqSN3D8gf0Zp BdCu3xE676JJgPE7B0DwmqNJZFtOtREgTtm7YGkBLRLON+1xnuzQQ5DjuTGu4uxfvO6QBAeNJw8qh Hcvc3QeGOUuQ2CekJmxPnY/IHRdOF6/RNPAMPNpBX0xMIDE/vke9ENAPrljLKA2KAtkgqwNnbe+HD Jda3b1yg==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:54308) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1rWdKM-00082q-1a; Sun, 04 Feb 2024 14:18:34 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1rWdKG-0001qF-5w; Sun, 04 Feb 2024 14:18:28 +0000 Date: Sun, 4 Feb 2024 14:18:28 +0000 From: "Russell King (Oracle)" To: =?utf-8?B?QXLEsW7DpyDDnE5BTA==?= Cc: Daniel Golle , DENG Qingfang , Sean Wang , Andrew Lunn , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , AngeloGioacchino Del Regno , mithat.guner@xeront.com, erkin.bozoglu@xeront.com, Bartel Eerdekens , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH net-next v3 4/7] net: dsa: mt7530: move XTAL check to mt7530_setup() Message-ID: References: <20240202-for-netnext-mt7530-improvements-2-v3-0-63d5adae99ca@arinc9.com> <20240202-for-netnext-mt7530-improvements-2-v3-4-63d5adae99ca@arinc9.com> <5b744f7f-2f63-4219-a0e9-8f08267b1fdd@arinc9.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240204_061853_113483_F98DF095 X-CRM114-Status: GOOD ( 40.06 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Sun, Feb 04, 2024 at 04:55:40PM +0300, Arınç ÜNAL wrote: > On 2.02.2024 21:39, Daniel Golle wrote: > > On Fri, Feb 02, 2024 at 09:16:02PM +0300, Arınç ÜNAL wrote: > > > On 2.02.2024 14:48, Russell King (Oracle) wrote: > > > > On Fri, Feb 02, 2024 at 12:19:10PM +0300, Arınç ÜNAL via B4 Relay wrote: > > > > > From: Arınç ÜNAL > > > > > > > > > > The crystal frequency concerns the switch core. The frequency should be > > > > > checked when the switch is being set up so the driver can reject the > > > > > unsupported hardware earlier and without requiring port 6 to be used. > > > > > > > > > > Move it to mt7530_setup(). Drop the unnecessary function printing. > > > > > > > > > > Signed-off-by: Arınç ÜNAL > > > > > Reviewed-by: Andrew Lunn > > > > > Reviewed-by: Vladimir Oltean > > > > > > > > I would prefer this to be earlier in the series, before patch 2 which > > > > moves mt7530_setup_port6() to be called from mac_config(). mac_config() > > > > is supposed to be configuration error-free - in other words, all state > > > > should have been checked before hand. > > > > > > I agree but mt7530_mac_config() is not a void function yet. The > > > mac_port_config member of the mt753x_info structure points to this > > > function. My next patch series gets rid of all useless error returns on the > > > phylink path and change mac_port_config to void. So I don't think working > > > on this patch series further will worth the effort. I'd rather have this > > > version applied as is. > > > > I agree regarding not changing the patch itself, but I also agree > > with Russell regarding the patch ordering. I know it's a 10-minute > > git headache to rebase the patches on top of each other in a different > > order, but you can easily compare the end result being identical to > > what you had before and hence don't need to retest. > > This is not about laziness. This is before patch 2: > > phylink_mac_ops :: mac_config() -> dsa_port_phylink_mac_config() > -> dsa_switch_ops :: phylink_mac_config() -> mt753x_phylink_mac_config() > -> mt753x_mac_config() > -> mt753x_info :: mac_port_config() -> mt7530_mac_config() > -> mt7530_setup_port5() > -> mt753x_pad_setup() > -> mt753x_info :: pad_setup() -> mt7530_pad_clk_setup() > > This is after: > > phylink_mac_ops :: mac_config() -> dsa_port_phylink_mac_config() > -> dsa_switch_ops :: phylink_mac_config() -> mt753x_phylink_mac_config() > -> mt753x_mac_config() > -> mt753x_info :: mac_port_config() -> mt7530_mac_config() > -> mt7530_setup_port5() > -> mt7530_setup_port6() > > Patch 2 does not move mt7530_setup_port6() to be called from > phylink_mac_ops :: mac_config(), it already is. There is no valid reason to > reorder the patches. > > My response to Russell should've stated this instead of focusing on his > second sentence. This patch moves the test for a 20MHz crystal to mt7530_setup(), which is something that is entirely orthogonal to patch 2, which can be done cleanly (I've just applied the patches in the original order and then reordered them: 98c481f5d706 net: dsa: mt7530: do not clear config->supported_interfaces 93c6b53b17f4 net: dsa: mt7530: correct port capabilities of MT7988 c9c6d4c51a1d net: dsa: mt7530: simplify mt7530_setup_port6() and change to void adfa948253e0 net: dsa: mt7530: remove pad_setup function pointer 57e21e6c2fc0 net: dsa: mt7530: call port 6 setup from mt7530_mac_config() 959a0f9323c8 net: dsa: mt7530: move XTAL check to mt7530_setup() 856ab64a22ef net: dsa: mt7530: empty default case on mt7530_setup_port5() No problems. The end result is identical comparing the git tree at the original "move XTAL" patch with adfa948253e0. Now, if we look at "net: dsa: mt7530: remove pad_setup function pointer" we can see that yes, the pad_setup() method was called from mac_confing, but this is the exact contents of that patch removing the callsite: - mt753x_pad_setup(ds, state); This returns an integer, which may be an error code, which is ignored. Therefore, if the XTAL frequency check fires, and mt753x_pad_setup() returns an error, it is ignored today. After "net: dsa: mt7530: call port 6 setup from mt7530_mac_config()" the renamed pad_setup() method is now called from mac_config() thusly: + ret = mt7530_setup_port6(priv->ds, interface); + if (ret) + return ret; So now the error checks cause mt7530_mac_config() to return an error which in turn causes mt753x_mac_config() to fail, and therefore mt753x_phylink_mac_config() has different behaviour. So, patch 2 changes the driver behaviour in the case of a 20MHz XTAL, which is then changed again by patch 4. It would be better to have only one change of behaviour by moving patch 4 before patch 2. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!