From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6B557C4828E for ; Fri, 2 Feb 2024 11:46:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=EQiNSIzGWZOhLVeY98Ti6gKM76H8cI4W2W3bGKTfEhA=; b=h2mfz5Ll5BRZagnzGgQSDowEta Z8r06mU125IQiNVo64uQFOrM3wiFfMENnwxOnus6q7r53rnTgGHCk4zbdiM3h4rbVU4eaiTpldQyg tzCprBQjM2WwM5IYrxwQmAjByVdv4Q8FLhGh3ZP4kl46PSV7xyRtOs5x7XSFz63+0xIYp/dL8IoI1 TvNf24Nbo0FCCYDR1trpi/XiNxzZyXhoVKkjnRU+cvDcSPse8jHnI4fz9t9QgGrY3BFUvNKLzUwI6 7tFtk+dkD1WhHUoZRlTGePCDSrpf7RXleDweQpaUMmQRHwKYPaNZMTC0rHGN0f8mNRJ0rzqCgUzz9 3hyq4zAA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rVs0T-0000000BLs9-0Tm1; Fri, 02 Feb 2024 11:46:53 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rVs0Q-0000000BLqm-0ugW; Fri, 02 Feb 2024 11:46:51 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=EQiNSIzGWZOhLVeY98Ti6gKM76H8cI4W2W3bGKTfEhA=; b=ptLmc7MVWQwRfnofPJ5ORYMdMH CsyUIF9bwCZa0Pd81x/m8qANoy1kHQDvzUoOJZ6IXiKTXkj36AKYohJTq0D7I8LargD/ErMnkLdwv yjX+onEq0uTXzJgqteTQhSDqWxLe0itUV8FXL6MVbSQAz+CoRipcJ2HwHPGp3ARlbV+QALTq9oSI0 BJCBrKNLiGLFx+950NY1BnYjtuddckye+7t92SjxvmByhpplsfWrSV64Zx+HiFagrJRsf5Am1cWI8 OlinlbGinZuDQzmHKSic74hNYb/PhFvuGbP5v0ex2nVqBPwf0PHVdG6++nHtMLowmo6ozKnIQAjld iFkHA7fw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:43324) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1rVs0H-0005uJ-1f; Fri, 02 Feb 2024 11:46:41 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1rVs0F-0008I3-Nv; Fri, 02 Feb 2024 11:46:39 +0000 Date: Fri, 2 Feb 2024 11:46:39 +0000 From: "Russell King (Oracle)" To: arinc.unal@arinc9.com Cc: Daniel Golle , DENG Qingfang , Sean Wang , Andrew Lunn , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , AngeloGioacchino Del Regno , mithat.guner@xeront.com, erkin.bozoglu@xeront.com, Bartel Eerdekens , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH net-next v3 3/7] net: dsa: mt7530: remove pad_setup function pointer Message-ID: References: <20240202-for-netnext-mt7530-improvements-2-v3-0-63d5adae99ca@arinc9.com> <20240202-for-netnext-mt7530-improvements-2-v3-3-63d5adae99ca@arinc9.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240202-for-netnext-mt7530-improvements-2-v3-3-63d5adae99ca@arinc9.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240202_034650_277376_2BDB983C X-CRM114-Status: GOOD ( 12.71 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Fri, Feb 02, 2024 at 12:19:09PM +0300, Arınç ÜNAL via B4 Relay wrote: > From: Arınç ÜNAL > > The pad_setup function pointer was introduced with 88bdef8be9f6 ("net: dsa: > mt7530: Extend device data ready for adding a new hardware"). It was being > used to set up the core clock and port 6 of the MT7530 switch, and pll of > the MT7531 switch. > > All of these were moved to more appropriate locations, and it was never > used for the switch on the MT7988 SoC. Therefore, this function pointer > hasn't got a use anymore. Remove it. > > Signed-off-by: Arınç ÜNAL > Acked-by: Daniel Golle > Reviewed-by: Vladimir Oltean Reviewed-by: Russell King (Oracle) Thanks! -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!