From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 39B29C4345F for ; Tue, 16 Apr 2024 08:47:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=NkM0I+aW0wUUvGJQ59wWIPVhiqCpaSf/yczLNzgYK2M=; b=pXFsa67Erai+Ykr5+Iiryflhod NNsLC2b6LNip1txI2UNLnzIiQD3RF8N4G3y3T3rd9Y7OMpgILqQQPFD/Vqn4TY86oGwsYn81b1BlT Gl16kCmRj6QKzmIBdq6IrOrmCUHifXx6xnwVp3dIEEt6Vm7xec/t9sPQ6hQeZoWNc0jMYRHBoJNro yV0zKHBHZVyrUXiN2doG9Q6dVzyLhO2Gpz3yKqUkidtSeCIzbkda9emgo+rI+qQA8CSAsEDcyG6pB N0B0Vqsrf0noyklDuj8uOMdcTmYlg88CkVSZtXBNqwZIN8leZPx5Trr0hq/RgepaAL9G6EC8FSgaI EZqUaRqQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rweTQ-0000000BUgt-2xd2; Tue, 16 Apr 2024 08:47:28 +0000 Received: from mail-ej1-x636.google.com ([2a00:1450:4864:20::636]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rweTM-0000000BUfk-3Bt6 for linux-mediatek@lists.infradead.org; Tue, 16 Apr 2024 08:47:26 +0000 Received: by mail-ej1-x636.google.com with SMTP id a640c23a62f3a-a51ddc783e3so508589366b.0 for ; Tue, 16 Apr 2024 01:47:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1713257242; x=1713862042; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=NkM0I+aW0wUUvGJQ59wWIPVhiqCpaSf/yczLNzgYK2M=; b=DoGdkzSxRZZFjzrtAVt3Shbjhz1Aunq72Rg4zWv8uFN0OWIV0wzilfL8W1pZo2fwTn NGACW55mKb2PeSsoTaLvFh/PGC/VyIaMO1PmkES0EhJfdqczlN6jeX4Wq8dssoc7m+3W BT4XitmFjA4I0URWCaIBB/HKR6gOVxaHJspIFn/AgVrJEriXz+pxgI7cet+E6uKZBQu0 FyacPpuFPDPajqd0H/pUzuJc3/J1dq/p8KT+ssazbABo+XTqw44evEMUEoAqXWiGo/Ig /9lMwYI1Q2GmL9/7sC11uGCkQMCgvdcw2JtA1sQZZxoDqpNdy2//YdVyQtxgfIzg9rw0 3Irg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713257242; x=1713862042; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=NkM0I+aW0wUUvGJQ59wWIPVhiqCpaSf/yczLNzgYK2M=; b=MRHAQIV8hZ6hGuagnRvgUABI5ZSoIMs8va8EbG1Ay+juDe8prD4P/MlhpkYVgEjl5R KZPde263f7ZcQSWkmTGjDwD/B31AG1TQOZyC6Ak+7KOfAk82Tkp8yyeHQtqLP7eGkfTa DOK87WgSTLF/+Rdp6RFuk5Lu8Xn6D4OP+QNg9vjp1rRJysWtmpcu8zSoPbyw8uA2rb1D YA1LNDJ6nYCVFpT0oKZcskV9j4gOJuxqtniM5glnYT+PhJnsd6d2VC1vtOekf2G5GlUY Nq1qpvJ/ZezRbjr1oFGLFfItWB1miOKxqSWhtt+M+wK5EJiNrtP6U1hbv80JmpJuM1OU m2TA== X-Forwarded-Encrypted: i=1; AJvYcCUpkzWDwqZx/sVbRIDOiPwO3zUrUISV4VUOdeR7SaF0wEm5msJLV/Aq2sAIIJxlyGualfPULwjZzqzWAIlBwvHASA2upCMSYBBpUj9qBxfMyx+w X-Gm-Message-State: AOJu0Yxd94oMwnr2tbAm3mH2FO2W8E3FluzOi/LBClUPbr0VAlUF+bRS pso6Xve4m5l0eJ6SMqJnG2HLlzeb/ofE2Mtz7PMQy0Iekw2sUxqH6hsK91QBo74= X-Google-Smtp-Source: AGHT+IERiWoYGa51YbGEPmkvByvhia/eckpCcRSCGVJVNIFEmOLsj+qs5GtIOBV8MGWtuu2neCmDeg== X-Received: by 2002:a17:906:7145:b0:a52:8a8a:59cb with SMTP id z5-20020a170906714500b00a528a8a59cbmr2572423ejj.61.1713257242155; Tue, 16 Apr 2024 01:47:22 -0700 (PDT) Received: from localhost ([102.222.70.76]) by smtp.gmail.com with ESMTPSA id x16-20020a170906135000b00a51a7832a7asm6572111ejb.199.2024.04.16.01.47.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Apr 2024 01:47:21 -0700 (PDT) Date: Tue, 16 Apr 2024 11:47:17 +0300 From: Dan Carpenter To: Ricardo Ribalda Cc: Martin Tuma , Mauro Carvalho Chehab , Laurent Pinchart , Hans Verkuil , Hugues Fruchet , Alain Volmat , Maxime Coquelin , Alexandre Torgue , Paul Kocialkowski , Greg Kroah-Hartman , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Sakari Ailus , Thierry Reding , Jonathan Hunter , Sowjanya Komatineni , Luca Ceresoli , Matthias Brugger , AngeloGioacchino Del Regno , Hans Verkuil , Sergey Kozlov , Abylay Ospan , Ezequiel Garcia , Dmitry Osipenko , Stanimir Varbanov , Vikash Garodia , Bryan O'Donoghue , Bjorn Andersson , Konrad Dybcio , Benjamin Mugnier , Sylvain Petinot , Jacopo Mondi , Kieran Bingham , Laurent Pinchart , Niklas =?iso-8859-1?Q?S=F6derlund?= , Pavel Machek , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, Oleg Drokin Subject: Re: [PATCH 00/35] media: Fix coccinelle warning/errors Message-ID: References: <20240415-fix-cocci-v1-0-477afb23728b@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240415-fix-cocci-v1-0-477afb23728b@chromium.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240416_014724_809059_F5078BE4 X-CRM114-Status: GOOD ( 13.17 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org In my opinion, it's better to just ignore old warnings. When code is new the warnings are going to be mostly correct. The original author is there and knows what the code does. Someone has the hardware ready to test any changes. High value, low burden. When the code is old only the false positives are left. No one is testing the code. It's low value, high burden. Plus it puts static checker authors in a difficult place because now people have to work around our mistakes. It creates animosity. Now we have to hold ourselves to a much higher standard for false positives. It sounds like I'm complaining and lazy, right? But Oleg Drokin has told me previously that I spend too much time trying to silence false positives instead of working on new code. He's has a point which is that actually we have limited amount of time and we have to make choices about what's the most useful thing we can do. So what I do and what the zero day bot does is we look at warnings one time and we re-review old warnings whenever a file is changed. Kernel developers are very good at addressing static checker warnings and fixing the real issues... People sometimes ask me to create a database of warnings which I have reviewed but the answer is that anything old can be ignored. As I write this, I've had a thought that instead of a database of false positives maybe we should record a database of real bugs to ensure that the fixes for anything real is applied. regards, dan carpenter