From: Johannes Berg <johannes@sipsolutions.net>
To: Lorenzo Bianconi <lorenzo@kernel.org>
Cc: Ryder Lee <ryder.lee@mediatek.com>,
Sean Wang <sean.wang@mediatek.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
linux-wireless@vger.kernel.org, Felix Fietkau <nbd@nbd.name>,
Shayne Chen <shayne.chen@mediatek.com>,
Christian Marangi <ansuelsmth@gmail.com>,
linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH wireless-next v3] wifi: mac80211: Add eMLSR/eMLMR action frame parsing support
Date: Wed, 28 Jan 2026 13:57:23 +0100 [thread overview]
Message-ID: <a2013bbb6988d53be3f6722cd8ff838dbd4d7f1c.camel@sipsolutions.net> (raw)
In-Reply-To: <aXoHdmjLKB-g54ie@lore-desk> (sfid-20260128_135628_166382_5E70C1A1)
On Wed, 2026-01-28 at 13:56 +0100, Lorenzo Bianconi wrote:
> >
> > > + if (drv_set_eml_op_mode(sdata, &sta->sta, &eml_params))
> > > + return;
> > > +
> > > + ieee80211_send_eml_op_mode_notif(sdata, mgmt, opt_len);
> >
> > IMHO it would make more sense to pass "ptr, opt_len" rather than "mgmt,
> > opt_len", since that's just what gets copied and then the callee doesn't
> > need to dig it out.
>
> But I guess we need mgmt pointer to set even other fields (e.g. dst-addr,
> dialog_token, ecc.).
Yeah, good point, passing them all individually isn't great either.
johannes
prev parent reply other threads:[~2026-01-28 12:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-28 11:17 [PATCH wireless-next v3] wifi: mac80211: Add eMLSR/eMLMR action frame parsing support Lorenzo Bianconi
2026-01-28 11:50 ` Johannes Berg
2026-01-28 12:56 ` Lorenzo Bianconi
2026-01-28 12:57 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a2013bbb6988d53be3f6722cd8ff838dbd4d7f1c.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=angelogioacchino.delregno@collabora.com \
--cc=ansuelsmth@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo@kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=nbd@nbd.name \
--cc=ryder.lee@mediatek.com \
--cc=sean.wang@mediatek.com \
--cc=shayne.chen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox