From: Chunfeng Yun <chunfeng.yun@mediatek.com>
To: Daniel Golle <daniel@makrotopia.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-phy@lists.infradead.org>, "Vinod Koul" <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>
Cc: <linux-mediatek@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>
Subject: Re: [PATCH 2/2] dt-bindings: phy: mediatek: tphy: add compatible for tphy-v4
Date: Fri, 21 Oct 2022 14:14:58 +0800 [thread overview]
Message-ID: <a24326d0a454082ab532025ae52462757d4d6bab.camel@mediatek.com> (raw)
In-Reply-To: <07c5d962515c4f675f076bb91d69eaf651b187c6.1666193782.git.daniel@makrotopia.org>
On Wed, 2022-10-19 at 16:38 +0100, Daniel Golle wrote:
> V4 can be found in MT7986 and MT7981 SoCs, it supports PCIe with two
> lanes.
NAK.
mt7981/mt7986 shall use "mediatek,generic-tphy-v2" instead.
Thanks a lot
>
> Signed-off-by: Daniel Golle <daniel@makrotopia.org>
> ---
> Documentation/devicetree/bindings/phy/mediatek,tphy.yaml | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml
> b/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml
> index 5613cc5106e32f..851e3dda7b638b 100644
> --- a/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml
> +++ b/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml
> @@ -89,6 +89,11 @@ properties:
> - mediatek,mt8188-tphy
> - mediatek,mt8195-tphy
> - const: mediatek,generic-tphy-v3
> + - items:
> + - enum:
> + - mediatek,mt7981-tphy
> + - mediatek,mt7986-tphy
> + - const: mediatek,generic-tphy-v4
> - const: mediatek,mt2701-u3phy
> deprecated: true
> - const: mediatek,mt2712-u3phy
> @@ -99,7 +104,7 @@ properties:
> description:
> Register shared by multiple ports, exclude port's private
> register.
> It is needed for T-PHY V1, such as mt2701 and mt8173, but not
> for
> - T-PHY V2/V3, such as mt2712.
> + T-PHY V2/V3/V4, such as mt2712.
> maxItems: 1
>
> "#address-cells":
next prev parent reply other threads:[~2022-10-21 6:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-19 15:37 [PATCH 1/2] phy: phy-mtk-tphy: Add PCIe 2 lane efuse support Daniel Golle
2022-10-19 15:38 ` [PATCH 2/2] dt-bindings: phy: mediatek: tphy: add compatible for tphy-v4 Daniel Golle
2022-10-21 1:56 ` Rob Herring
2022-10-21 6:14 ` Chunfeng Yun [this message]
2022-10-21 2:23 ` [PATCH 1/2] phy: phy-mtk-tphy: Add PCIe 2 lane efuse support Sam Shih
2022-10-21 6:11 ` Chunfeng Yun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a24326d0a454082ab532025ae52462757d4d6bab.camel@mediatek.com \
--to=chunfeng.yun@mediatek.com \
--cc=daniel@makrotopia.org \
--cc=devicetree@vger.kernel.org \
--cc=kishon@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-phy@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox