From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthias Brugger Subject: Re: [PATCH 4/9] drm/mediatek: fix the rate and divder of hdmi phy for MT2701 Date: Wed, 9 Jan 2019 17:54:13 +0100 Message-ID: References: <1546585439-30455-1-git-send-email-chunhui.dai@mediatek.com> <1546585439-30455-5-git-send-email-chunhui.dai@mediatek.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1546585439-30455-5-git-send-email-chunhui.dai@mediatek.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: chunhui dai , --to=Michael Turquette , Stephen Boyd , CK Hu Cc: Philipp Zabel , David Airlie , Sean Wang , Ryder Lee , Colin Ian King , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, dri-devel@lists.freedesktop.org, srv_heupstream@mediatek.com, bibby.hsieh@mediatek.com, jamesjj.liao@mediatek.com, jitao.shi@mediatek.com List-Id: linux-mediatek@lists.infradead.org On 04/01/2019 08:03, chunhui dai wrote: > fix the rate and divder of hdmi phy for MT2701. This is a bug? Then we would need a fixes tag. Otherwise you should explain in the commit, that you need to change the calculation due to previous commits. Regards, Matthias > > Signed-off-by: chunhui dai > --- > drivers/gpu/drm/mediatek/mtk_mt2701_hdmi_phy.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_mt2701_hdmi_phy.c b/drivers/gpu/drm/mediatek/mtk_mt2701_hdmi_phy.c > index a28a32d..10b6235 100644 > --- a/drivers/gpu/drm/mediatek/mtk_mt2701_hdmi_phy.c > +++ b/drivers/gpu/drm/mediatek/mtk_mt2701_hdmi_phy.c > @@ -114,8 +114,8 @@ static int mtk_hdmi_pll_set_rate(struct clk_hw *hw, unsigned long rate, > > if (rate <= 64000000) > pos_div = 3; > - else if (rate <= 12800000) > - pos_div = 1; > + else if (rate <= 128000000) > + pos_div = 2; > else > pos_div = 1; > >