Re: [PATCH v2 15/23] arm64: dts: mt8192: Add m4u and smi nodes - allen-kh.cheng

From: allen-kh.cheng <allen-kh.cheng@mediatek.com>
To: "Nícolas F. R. A. Prado" <nfraprado@collabora.com>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	--to=Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	<Project_Global_Chrome_Upstream_Group@mediatek.com>,
	<devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>,
	<linux-mediatek@lists.infradead.org>,
	Chen-Yu Tsai <wenst@chromium.org>,
	Ryder Lee <ryder.lee@kernel.org>
Subject: Re: [PATCH v2 15/23] arm64: dts: mt8192: Add m4u and smi nodes
Date: Wed, 23 Feb 2022 21:34:55 +0800	[thread overview]
Message-ID: <a3f13c65c4d36f447f2159fe46ba66b93031b97c.camel@mediatek.com> (raw)
In-Reply-To: <20220222214822.3sxsbjrtm6ild6rx@notapiano>

On Tue, 2022-02-22 at 16:48 -0500, Nícolas F. R. A. Prado wrote:
> On Fri, Feb 18, 2022 at 05:16:25PM +0800, Allen-KH Cheng wrote:
> > +		larb16: larb@1a00f000 {
> > +			compatible = "mediatek,mt8192-smi-larb";
> > +			reg = <0 0x1a00f000 0 0x1000>;
> > +			mediatek,larb-id = <16>;
> > +			mediatek,smi = <&smi_common>;
> > +			clocks = <&camsys_rawa CLK_CAM_RAWA_CAM>,
> > +				 <&camsys_rawa CLK_CAM_RAWA_LARBX>;
> > +			clock-names = "apb", "smi";
> > +			mediatek,smi-id = <16>;
> 
> This mediatek,smi-id property isn't handled in the driver or
> mentioned in the
> dt-binding, and seems redundant to mediatek,larb-id. So just drop it.
> 
> Other than that,
> 
> Reviewed-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>

I will drop this from series. thanks.

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek