Re: [PATCH v1] ufs: core: Fix runtime suspend error deadlock

Peter Wang (王信友)
2025-09-24T09:26:42Z

On Tue, 2025-09-23 at 09:07 -0700, Bart Van Assche wrote:
>
>
> Does this patch introduce a race condition? Can a power management
> operation start after hba->pm_op_in_progress has been tested and
> before
> ufshcd_err_handling_prepare() is called? Should the added code
> perhaps
> be surrounded with ufshcd_rpm_get_noresume() and ufshcd_rpm_put()?
>
> Thanks,
>
> Bart.

Hi Bart,

Are you saying that after the runtime suspend timer expires,
the error handler might be triggered just before runtime suspend?
I don't think this can happen, since there shouldn't be anything
triggering the error handler when the bus has been idle for a long
time.

Thanks
Peter