From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 50455C433F5 for ; Mon, 16 May 2022 08:44:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=31tBqmfgYA77IZ9MDApiVVbhh7hp1RWYGr/XMNZRqGg=; b=Fj1nw9XoaJFGpU WBj9lny17x1oYpjwpEGtQpSVNxWqlcXMDHA/h5GRalJMomvXYxUuY2Xu7EYG7CArcHxCRfFEdCjFB ShCUwJeD1VIKX3yIrmls05aR9Kk6J8vzYEQVT6xIT4NE3yqkVQPxLBV99MqerJIT1W68BEAXELDzy ZXyOm1GGn0cYg97pFWpuqedZVfd0aFdVjPbjaNLE9jjAqkLkljV7wdVSY0YMCCx0FWLM2zXEz1dSU QZot+afzpABPFAjNKd61EwTF8Tli1+2gHw0bQ7wRGzRk7qSQXi6/9MZ1wYrLI5lM9oek+b8tqnm1j hBpykrIJ4OoFxlIqoRtQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nqWLK-006j0u-8C; Mon, 16 May 2022 08:44:42 +0000 Received: from bhuna.collabora.co.uk ([46.235.227.227]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nqWKz-006isR-Rp; Mon, 16 May 2022 08:44:23 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: kholk11) with ESMTPSA id AA2351F427F3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1652690660; bh=/A+cNqtSPHG/D4qhatlAKYS/dqSWn1bu3i/Z2T9OGN8=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=XDOVMGDR+NJ6s8VoO9u2vElluOF9m3hpIu+RFa3HjxJBsrZRUvXxnHq4iSzXqxW3O dfQpBXHhFN/+Rc62GprPJ0M9G/kPT5GiZRc/xxU3bonQwqoyGID8I90+SLMwQmr7l7 9bP1jxx1FV8GBCxK/drzz+SBpEKbhlOwfc4aDVteuYCrcn3tk3UXC2wovIC/IBiOPH V0wXYHwPixsUeKzr4W5Sf5/254a7Y2o+GNp+ap3oXvEAN7AO0LnlVmlRdTC2JULXvM paQk33Y9eAgNHfa842LRJ6yDI6IOhpxDZljnp1VvwrUr3k2dROpNWIQlh3VZvF5hgs eqJLVkEIB4iIQ== Message-ID: Date: Mon, 16 May 2022 10:44:16 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH] soc: mediatek: mtk-mmsys: Add support for MT6795 Helio X10 Content-Language: en-US To: CK Hu , matthias.bgg@gmail.com Cc: linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, konrad.dybcio@somainline.org, marijn.suijten@somainline.org, martin.botka@somainline.org, ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, paul.bouchara@somainline.org, kernel@collabora.com References: <20220513170350.502501-1-angelogioacchino.delregno@collabora.com> <7c996c665a57fdd9ba8d6df4dc085f70afc1b933.camel@mediatek.com> From: AngeloGioacchino Del Regno In-Reply-To: <7c996c665a57fdd9ba8d6df4dc085f70afc1b933.camel@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220516_014422_110231_FBCC3924 X-CRM114-Status: GOOD ( 20.48 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Il 16/05/22 07:43, CK Hu ha scritto: > Hi, Angelo: > > On Fri, 2022-05-13 at 19:03 +0200, AngeloGioacchino Del Regno wrote: >> Add MM support for the MT6795 SoC, using the mmsys default routing >> table. >> >> Signed-off-by: AngeloGioacchino Del Regno < >> angelogioacchino.delregno@collabora.com> >> --- >> >> In order for this patch to have any meaning and functionality, it is >> required to also have in-tree the [1] MT6795 clocks series, even >> though that's not required to actually compile this code. >> >> [1] >> https://urldefense.com/v3/__https://patchwork.kernel.org/project/linux-mediatek/list/?series=641493__;!!CTRNKA9wMg0ARbw!ywDb_Gj4oV0iYHK_PbtJSNejzsJGlFVjX-1O0G1mR0vZX_5VeMtlZJ_AS6K_Mg$ >> >> >> drivers/soc/mediatek/mtk-mmsys.c | 11 +++++++++++ >> 1 file changed, 11 insertions(+) >> >> diff --git a/drivers/soc/mediatek/mtk-mmsys.c >> b/drivers/soc/mediatek/mtk-mmsys.c >> index 06d8e83a2cb5..38b36b881a3b 100644 >> --- a/drivers/soc/mediatek/mtk-mmsys.c >> +++ b/drivers/soc/mediatek/mtk-mmsys.c >> @@ -57,6 +57,13 @@ static const struct mtk_mmsys_match_data >> mt6779_mmsys_match_data = { >> }, >> }; >> >> +static const struct mtk_mmsys_driver_data mt6795_mmsys_driver_data = >> { >> + .clk_driver = "clk-mt6795-mm", >> + .routes = mmsys_default_routing_table, > > mt6795 should have its own routing table instead of default one. The > default one is used for mt8173, mt2701, mt2712 which no one knows how > to separate them. If you don't know the routing table of mt6795, just > left this as NULL. > Hello CK, I agree with you, in fact the first test that I've done was with leaving routes to NULL, but that did not work (I couldn't get the display to work), while assigning the default routing table resulted in having a working internal (DSI) display et al, which is why I have done that. I am sure that this may be a quirk that is required due to my platform's bootloader, but still, it won't work otherwise. If anyone from MediaTek wants to help with providing a better solution for that, you're welcome to - but otherwise, my proposal is to configure MT6795 with that default routing table and eventually come back to this later if any issue with this gets discovered... I couldn't find any, though. Cheers, Angelo _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek