From: "Sverdlin, Alexander" <alexander.sverdlin@siemens.com>
To: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"florian.fainelli@broadcom.com" <florian.fainelli@broadcom.com>
Cc: "andrew@lunn.ch" <andrew@lunn.ch>,
"olteanv@gmail.com" <olteanv@gmail.com>,
"bridge@lists.linux.dev" <bridge@lists.linux.dev>,
"claudiu.manoil@nxp.com" <claudiu.manoil@nxp.com>,
"dqfext@gmail.com" <dqfext@gmail.com>,
"nbd@nbd.name" <nbd@nbd.name>,
"davem@davemloft.net" <davem@davemloft.net>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
"angelogioacchino.delregno@collabora.com"
<angelogioacchino.delregno@collabora.com>,
"Mark-MC.Lee@mediatek.com" <Mark-MC.Lee@mediatek.com>,
"UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"arinc.unal@arinc9.com" <arinc.unal@arinc9.com>,
"alexandre.belloni@bootlin.com" <alexandre.belloni@bootlin.com>,
"edumazet@google.com" <edumazet@google.com>,
"bcm-kernel-feedback-list@broadcom.com"
<bcm-kernel-feedback-list@broadcom.com>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"daniel@makrotopia.org" <daniel@makrotopia.org>,
"razor@blackwall.org" <razor@blackwall.org>,
"kuba@kernel.org" <kuba@kernel.org>,
"sean.wang@mediatek.com" <sean.wang@mediatek.com>,
"roopa@nvidia.com" <roopa@nvidia.com>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"f.fainelli@gmail.com" <f.fainelli@gmail.com>,
"lorenzo@kernel.org" <lorenzo@kernel.org>
Subject: Re: [PATCH 1/2] net: dsa: RCU-protect dsa_ptr in struct net_device
Date: Tue, 10 Sep 2024 20:40:26 +0000 [thread overview]
Message-ID: <a89dfb1524d9592a5077d2a7a34dceed579e7d3d.camel@siemens.com> (raw)
In-Reply-To: <b6604e07-9add-4e93-ad6b-f1efc336e3bf@broadcom.com>
Hi Florian!
On Tue, 2024-09-10 at 10:40 -0700, Florian Fainelli wrote:
> > RCU-protect dsa_ptr and use rcu_dereference() or rtnl_dereference()
> > depending on the calling context.
> >
> > Rename netdev_uses_dsa() into __netdev_uses_dsa_currently()
> > (assumes ether RCU or RTNL lock held) and netdev_uses_dsa_currently()
> > variants which better reflect the uselessness of the function's
> > return value, which becomes outdated right after the call.
> >
> > Fixes: ee534378f005 ("net: dsa: fix panic when DSA master device unbinds on shutdown")
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Alexander Sverdlin <alexander.sverdlin@siemens.com>
>
> Thanks for doing this work, just a few nits below. This is likely to be
> difficult to backport to stable trees.
Thanks for the quick feedback!
As I've mentioned in the cover letter, I've v6.1 backport already available
and I'm ready to backport to v6.8 as soon as we agree on the final form for
v6.11.
--
Alexander Sverdlin
Siemens AG
www.siemens.com
next prev parent reply other threads:[~2024-09-10 20:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-10 13:03 [PATCH 0/2] net: dsa: RCU-protect dsa_ptr in struct net_device A. Sverdlin
2024-09-10 13:03 ` [PATCH 1/2] " A. Sverdlin
2024-09-10 17:40 ` Florian Fainelli
2024-09-10 20:40 ` Sverdlin, Alexander [this message]
2024-09-13 19:03 ` Vladimir Oltean
2024-09-13 19:27 ` Andrew Lunn
2024-09-14 5:56 ` Greg KH
2024-09-17 8:10 ` Gur Stavi
2024-09-17 8:25 ` Sverdlin, Alexander
2024-09-17 10:30 ` Gur Stavi
2024-09-17 11:08 ` Sverdlin, Alexander
2024-09-11 2:19 ` [PATCH 0/2] " Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a89dfb1524d9592a5077d2a7a34dceed579e7d3d.camel@siemens.com \
--to=alexander.sverdlin@siemens.com \
--cc=Mark-MC.Lee@mediatek.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andrew@lunn.ch \
--cc=angelogioacchino.delregno@collabora.com \
--cc=arinc.unal@arinc9.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bridge@lists.linux.dev \
--cc=claudiu.manoil@nxp.com \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=dqfext@gmail.com \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=florian.fainelli@broadcom.com \
--cc=kuba@kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=lorenzo@kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=razor@blackwall.org \
--cc=roopa@nvidia.com \
--cc=sean.wang@mediatek.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox