From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AC1C4C3ABDD for ; Tue, 20 May 2025 06:56:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=NrL1QJRIMqtNCjap45wWxtkSD8KFor8WXq65Sq+7ONw=; b=ocJ3joXVQt26p4TUDNfRViPxEA WBQEqHyZtGv7WhrlNqdNs5zC1sLqTDqUDsKs8OOb5tNsZL6JbMt1j7IFmxIVMHNZvDbkB6hQRR+yP KhvO25zkGy4KDya2TVMPZKlOTiSRaOMNEI8Sf2NvmRf/KnFgYjEJEc0OZ88zFxutqGEHIr3YwLWBd Sn9QOLq5lJE1uYOqSepVcfvW+f53AHBMJAOm8TeW2Dp/2YPu9jKJTw/5NV/2rs+apn8wcikWutMzv T0Qdfc6Br6oY7MwmL+7nVWAKlTF7MsyN9ilo4WycFSrYNRNLlztvPn9U9rtZtvlRcRiDFe1Aefkdz 6iRI9aiA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uHGuC-0000000Bn1A-2Aeu; Tue, 20 May 2025 06:56:52 +0000 Received: from [193.175.24.41] (helo=elvis.franken.de) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uHGu8-0000000Bmz6-3BTb for linux-mediatek@lists.infradead.org; Tue, 20 May 2025 06:56:51 +0000 Received: from uucp by elvis.franken.de with local-rmail (Exim 3.36 #1) id 1uHGu1-0006iN-00; Tue, 20 May 2025 08:56:41 +0200 Received: by alpha.franken.de (Postfix, from userid 1000) id 35693C00EF; Tue, 20 May 2025 08:49:30 +0200 (CEST) Date: Tue, 20 May 2025 08:49:30 +0200 From: Thomas Bogendoerfer To: Caleb James DeLisle Cc: linux-mips@vger.kernel.org, tglx@linutronix.de, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, daniel.lezcano@linaro.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, benjamin.larsson@genexis.eu, linux-mediatek@lists.infradead.org Subject: Re: [PATCH v5 0/7] Add EcoNet EN751221 MIPS platform support Message-ID: References: <20250507134500.390547-1-cjd@cjdns.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250507134500.390547-1-cjd@cjdns.fr> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250519_235649_088549_60B3BAA6 X-CRM114-Status: GOOD ( 23.20 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Wed, May 07, 2025 at 01:44:53PM +0000, Caleb James DeLisle wrote: > EcoNet MIPS SoCs are big endian machines based on 34Kc and 1004Kc > processors. They are found in xDSL and xPON modems, and contain PCM > (VoIP), Ethernet, USB, GPIO, I2C, SPI (Flash), UART, and PCIe. > > The EcoNet MIPS SoCs are divided broadly into two families, the > EN751221 family based on the 34Kc, and the EN751627 family based on > the 1004Kc. Individual SoCs within a family are very similar, only > with different peripherals. > > This patchset adds basic "boots to a console" support for the EN751221 > family and adds SmartFiber XP8421-B, a low cost commercially available > board that is useful for testing and development. > > Note that Airoha (AN7523, AN7581) is similar to EcoNet in terms of > peripherals, and for historical reasons Airoha chips are sometimes > referred to with the EN75xx prefix. However this is a different > platform because Airoha chips are ARM based. > > This patchset is against mips-next. > > v4 -> v5 > * 2/7 clocksource/drivers: Add EcoNet Timer HPT driver: > * Improve explanation of HPT timer in changelog > * Move pr_info to pr_debug per recommendation > * Remove pointless debug on spurious interrupt > * Small code-style change > > v3 -> v4 > * Rebase to 3b3704261e851e25983860e4c352f1f73786f4ab > * Omit already accepted patches (thanks guys!): > - https://patchwork.kernel.org/project/linux-mips/patch/20250330170306.2584136-2-cjd@cjdns.fr/ > - https://patchwork.kernel.org/project/linux-mips/patch/20250330170306.2584136-3-cjd@cjdns.fr/ > - https://patchwork.kernel.org/project/linux-mips/patch/20250330170306.2584136-4-cjd@cjdns.fr/ > > v2 -> v3 > * econet,en751221-timer.yaml -> Improve code style > * vendor-prefixes.yaml -> Correct alphabetic order > * en751221.dtsi > - interrupt-controller code style > - serial: Explain reason for clock-frequency = <1843200> > * v3->v3 diff provided for reference > - https://gist.github.com/cjdelisle/21c9f0cd225f499bdff3c574c7f185f2 > * CC: linux-mediatek@lists.infradead.org who may be interested. > > v1 -> v2 > * Codestyle > - Apply codestyle from "The tip tree handbook" and recommendations > - Remove "_rai" and "_m" symbol suffixes which are not standard > * irq-econet-en751221.c > - Use cleanup.h _guard() and _free() > - Separate irq_domain_ops from irq_chip, eliminating econet_intc struct > - Remove irqsave in econet_wreg, irqs are already disabled in mask/unmask > - Add explainatory comments > - Refactor shadow logic for clarity, e.g. INTC_NO_SHADOW -> NOT_PERCPU > - Improve error handling in case of invalid DTS > * econet,timer-hpt.yaml > - Rename to econet,timer-en751221.yaml > - Impose rule: "reg" must have 1 item on EN751221 and 2 on EN751627 > * timer-econet-hpt.c > - Rename to timer-econet-en751221.c to follow naming scheme from DT > * econet,en751221-intc.yaml > - Fix validation error from required: interrupt-parent > - shadow-interrupts -> switch to uint32-matrix for list of pairs > * MAINTAINERS -> Fixed accidental F: MAINTAINERS > * Replace "test image" with device SmartFiber-XP8421-B > * Restructure arch/mips/econet/Kconfig per arch/mips/ralink example > * v1->v2 diff is offered for reference: > - https://gist.github.com/cjdelisle/bb3acab78b5f70dcdfe5dd6338293efe > > > Caleb James DeLisle (7): > dt-bindings: timer: Add EcoNet EN751221 "HPT" CPU Timer > clocksource/drivers: Add EcoNet Timer HPT driver > dt-bindings: mips: Add EcoNet platform binding > mips: Add EcoNet MIPS platform support > dt-bindings: vendor-prefixes: Add SmartFiber > mips: dts: Add EcoNet DTS with EN751221 and SmartFiber XP8421-B board > MAINTAINERS: Add entry for newly added EcoNet platform. > > .../devicetree/bindings/mips/econet.yaml | 26 +++ > .../bindings/timer/econet,en751221-timer.yaml | 80 +++++++ > .../devicetree/bindings/vendor-prefixes.yaml | 2 + > MAINTAINERS | 12 + > arch/mips/Kbuild.platforms | 1 + > arch/mips/Kconfig | 25 ++ > arch/mips/boot/compressed/uart-16550.c | 5 + > arch/mips/boot/dts/Makefile | 1 + > arch/mips/boot/dts/econet/Makefile | 2 + > arch/mips/boot/dts/econet/en751221.dtsi | 67 ++++++ > .../econet/en751221_smartfiber_xp8421-b.dts | 19 ++ > arch/mips/econet/Kconfig | 48 ++++ > arch/mips/econet/Makefile | 2 + > arch/mips/econet/Platform | 5 + > arch/mips/econet/init.c | 78 +++++++ > drivers/clocksource/Kconfig | 8 + > drivers/clocksource/Makefile | 1 + > drivers/clocksource/timer-econet-en751221.c | 216 ++++++++++++++++++ > 18 files changed, 598 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mips/econet.yaml > create mode 100644 Documentation/devicetree/bindings/timer/econet,en751221-timer.yaml > create mode 100644 arch/mips/boot/dts/econet/Makefile > create mode 100644 arch/mips/boot/dts/econet/en751221.dtsi > create mode 100644 arch/mips/boot/dts/econet/en751221_smartfiber_xp8421-b.dts > create mode 100644 arch/mips/econet/Kconfig > create mode 100644 arch/mips/econet/Makefile > create mode 100644 arch/mips/econet/Platform > create mode 100644 arch/mips/econet/init.c > create mode 100644 drivers/clocksource/timer-econet-en751221.c applied patches 3-7 to mips-next Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]