From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 223DBC87FD2 for ; Fri, 8 Aug 2025 07:42:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=vC9kSzidZ3lEzWsQIFhc/wqeFJziVL3H7AjboZgOxSk=; b=q4MDsrKWq+M30GeHEVIXYthnwe F493F1wdwh42y0fKuEbvzER2MsqDUR4slktoGuBbuiSTVjW4KcIv6WL4HN2jTASzRcA+RkC/Oo3G2 /GW5+hu97CmOUdEpO6hxBWMTJzWE2Ddu71o3yLQx5/As30NMnE0rsQMWFJNa/jevbnvHBY2u60/DF Pc3lOImCBEPR9ExXpIaAexqgCkxcGas5IO+X8tD9t8rJ8FfOY/DzYOJPdtV4+CLcMfi6l5ixMpQ7D JIAkvGtuhZwnobnk4LWrcg+z4lEXxq6oCrnBOna/ihMmHH9TJ6jqno/UIdOffreg1PVenqcNhuOpF F4D/ML+g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1ukHjt-00000002EXH-3wOC; Fri, 08 Aug 2025 07:42:09 +0000 Received: from mgamail.intel.com ([192.198.163.7]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1ukHR6-00000002BSN-1RiA; Fri, 08 Aug 2025 07:22:45 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1754637764; x=1786173764; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=fbLBorPezoJWXQtvSg4WV87SLfHofuZpGSIX8FwjR+A=; b=dSy2AUy9aybB9w1TePUjoVyp/VDYXlPV5dP3oY7PLSgw7uMaUhEk3BDB bLiXOW8BuZeU03MMaP0QOoNIiDGiBY3vCXlO76XCM6avoo2lWMrY1YRWH 4bdiBxeQkh3IHR3cNpJeFgUeGYRRNWV1mJAg3Uz9FOP/7AL7/DIQaBKvF ntw7cI6MAGi4p0TpZdA+B8ck02yml8XKFc0eDPyxsARyGXkmLNItkVnmU N0CXCoDUyfAWLcrd9wdL8SF9nz/6p1i+BqTx0h+aQmerYzHssv8AZPBo5 U7AUmJ5CsjmHCCmI69vMUdpUyenjAdOQ7yl5CjsSBOJQxdCI60xsb1uMS w==; X-CSE-ConnectionGUID: RbTz6xd1TyKxfaj0BjlemQ== X-CSE-MsgGUID: HTc/G7zVTiOj12eazPNREQ== X-IronPort-AV: E=McAfee;i="6800,10657,11514"; a="82427461" X-IronPort-AV: E=Sophos;i="6.17,274,1747724400"; d="scan'208";a="82427461" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Aug 2025 00:22:44 -0700 X-CSE-ConnectionGUID: OdNPlVlrR9m1H28JVd9Cfw== X-CSE-MsgGUID: 6MIOtN9XTOqpGi12upForA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.17,274,1747724400"; d="scan'208";a="188944168" Received: from fpallare-mobl4.ger.corp.intel.com (HELO kekkonen.fi.intel.com) ([10.245.245.151]) by fmviesa002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Aug 2025 00:22:33 -0700 Received: from kekkonen.localdomain (localhost [127.0.0.1]) by kekkonen.fi.intel.com (Postfix) with SMTP id 7FB8211FC97; Fri, 8 Aug 2025 10:22:31 +0300 (EEST) Date: Fri, 8 Aug 2025 07:22:31 +0000 Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo From: Sakari Ailus To: Laurent Pinchart Cc: Jacopo Mondi , Mauro Carvalho Chehab , Devarsh Thakkar , Benoit Parrot , Hans Verkuil , Mike Isely , Hans de Goede , Parthiban Veerasooran , Christian Gromm , Greg Kroah-Hartman , Alex Shi , Yanteng Si , Dongliang Mu , Jonathan Corbet , Tomasz Figa , Marek Szyprowski , Andy Walls , Michael Tretter , Pengutronix Kernel Team , Bin Liu , Matthias Brugger , AngeloGioacchino Del Regno , Dmitry Osipenko , Thierry Reding , Jonathan Hunter , Mirela Rabulea , Shawn Guo , Sascha Hauer , Fabio Estevam , Kieran Bingham , Michal Simek , Ming Qian , Zhou Peng , Xavier Roumegue , Philipp Zabel , Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Sylwester Nawrocki , Jernej Skrabec , Chen-Yu Tsai , Samuel Holland , Daniel Almeida , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Nas Chung , Jackson Lee , Minghsiu Tsai , Houlong Wei , Andrew-CT Chen , Tiffany Lin , Yunfei Dong , Geert Uytterhoeven , Magnus Damm , Mikhail Ulyanov , Jacob Chen , Ezequiel Garcia , Heiko Stuebner , Detlev Casanova , Krzysztof Kozlowski , Alim Akhtar , Sylwester Nawrocki , =?utf-8?Q?=C5=81ukasz?= Stelmach , Andrzej Pietrasiewicz , Jacek Anaszewski , Andrzej Hajda , Fabien Dessenne , Hugues Fruchet , Jean-Christophe Trotin , Maxime Coquelin , Alexandre Torgue , Nicolas Dufresne , Benjamin Gaignard , Steve Longerbeam , Maxime Ripard , Paul Kocialkowski , Niklas =?iso-8859-1?Q?S=F6derlund?= , Robert Foss , Todor Tomov , Vladimir Zapolskiy , Corentin Labbe , Bingbu Cao , Tianshu Qiu , Stanislaw Gruszka , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-tegra@vger.kernel.org, imx@lists.linux.dev, linux-renesas-soc@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-sunxi@lists.linux.dev, linux-usb@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, mjpeg-users@lists.sourceforge.net Subject: Re: [PATCH 64/65] media: staging: ipu7: isys: Don't set V4L2_FL_USES_V4L2_FH manually Message-ID: References: <20250802-media-private-data-v1-0-eb140ddd6a9d@ideasonboard.com> <20250802-media-private-data-v1-64-eb140ddd6a9d@ideasonboard.com> <20250807170135.GH11583@pendragon.ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250807170135.GH11583@pendragon.ideasonboard.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250808_002244_395203_8458C3D0 X-CRM114-Status: GOOD ( 15.79 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Thu, Aug 07, 2025 at 08:01:35PM +0300, Laurent Pinchart wrote: > Hi Sakari, > > On Thu, Aug 07, 2025 at 09:07:13AM +0000, Sakari Ailus wrote: > > On Sat, Aug 02, 2025 at 11:23:26AM +0200, Jacopo Mondi wrote: > > > From: Laurent Pinchart > > > > > > The V4L2_FL_USES_V4L2_FH flag is set by v4l2_fh_init(). It is not meant > > > to be set manually by drivers. Drop it from the ipu7-isys driver. > > > > > > Signed-off-by: Laurent Pinchart > > > Signed-off-by: Jacopo Mondi > > > > Thanks, Jacopo! > > > > Reviewed-by: Sakari Ailus > > Can we get you review on patch 63/65 too (for the IPU6 driver) too ? Done. -- Sakari Ailus