From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 04269CA1009 for ; Tue, 2 Sep 2025 21:42:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=qHXyTgYlsVDOCondbOXFmhOPZeYBMwy1Jb4bmEJyWmw=; b=QXoRA5SHKjrziHwFZzGrL9vCa7 CqvsYTFAmTHILrn0biOml7oLPtGoX2TWcRBRr+7ZdpfNHrHFnz0bXeQHDAHvm7VhP54g+wKvOjSIC DRqbRIUTG69Ec7umu7jJzfa0CyI3imxvmeYttgb3etjvPmAeXw0wYli9ULMC/jIXUdt1H3ztLGWJF gtTk7LU3lbHLjC4oPr7vwQ7RHXRuvS/5VYR5rP1njG9efM7qntqNEwn0B/HeMSl/u3GCrzz3g3adG 1CdGw2X9HtI2ch3aPBP1XHGtEJxqioSPDth8Gyb5KARJ7cUydd3hxqQh6lzu7vAjE0madCsn88pxK QxC+IiDA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1utYm7-00000002Abe-0KBo; Tue, 02 Sep 2025 21:42:47 +0000 Received: from mgamail.intel.com ([192.198.163.18]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1utRs4-00000000JuZ-0DG1; Tue, 02 Sep 2025 14:20:29 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1756822828; x=1788358828; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=iAXUSwwbvwiZC9bhMY6s6lbOEzUht7j1jWcYwHXsu+I=; b=MIGDtOcYMJ/J2HaWDNElWdKWf1WbKa4/EvFv1NKQK6T+XRVe+VlnR5KJ nFGNEmhvUvroow5pWFPgkWkQe/As0BaR8smTxWZgMMcWmYOIBEEqJtaiB DHSeyHlS+oQpQ5awNRUUWXmoEYiUiG6WpzWx1VhY03JTbvmpzWWbg0Hlk 2P/KiAY32cSas/A15BEaHzqUwII79vbARYflVUgrZ7kW7LwJnRNA+RIgX apeYw9ZdCSZZjb8wka73G9neMSdq1v1+2o/OX6JGNj5Ug8rMm1kqweqzn S4PO/8G1vVRoRmq38rU1eS2vB1ltmFeHOkxh0s0ww7/wFY3sr0GPGRYrB A==; X-CSE-ConnectionGUID: GzhUbaZ2RQaMgEbRWzcWfA== X-CSE-MsgGUID: 62tMVg1+ToCopbTIqN8uww== X-IronPort-AV: E=McAfee;i="6800,10657,11541"; a="58305913" X-IronPort-AV: E=Sophos;i="6.18,230,1751266800"; d="scan'208";a="58305913" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Sep 2025 07:20:24 -0700 X-CSE-ConnectionGUID: MsrrCbkESHiLoR6gD4wQng== X-CSE-MsgGUID: WARwoctoTZupLE1EBSrbfg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.18,230,1751266800"; d="scan'208";a="202237611" Received: from smile.fi.intel.com ([10.237.72.52]) by fmviesa001.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Sep 2025 07:20:13 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.98.2) (envelope-from ) id 1utRrk-0000000AiLA-3gUk; Tue, 02 Sep 2025 17:20:08 +0300 Date: Tue, 2 Sep 2025 17:20:08 +0300 From: Andy Shevchenko To: Bartosz Golaszewski Cc: Linus Walleij , Bjorn Andersson , Konrad Dybcio , Alexey Klimov , Lorenzo Bianconi , Sean Wang , Matthias Brugger , AngeloGioacchino Del Regno , Paul Cercueil , Kees Cook , Andy Shevchenko , Andrew Morton , David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Dong Aisheng , Fabio Estevam , Shawn Guo , Jacky Bai , Pengutronix Kernel Team , NXP S32 Linux Team , Sascha Hauer , Tony Lindgren , Haojian Zhuang , Geert Uytterhoeven , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Neil Armstrong , Mark Brown , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-hardening@vger.kernel.org, linux-mm@kvack.org, imx@lists.linux.dev, linux-omap@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Bartosz Golaszewski , stable@vger.kernel.org Subject: Re: [PATCH v7 01/16] pinctrl: check the return value of pinmux_ops::get_function_name() Message-ID: References: <20250902-pinctrl-gpio-pinfuncs-v7-0-bb091daedc52@linaro.org> <20250902-pinctrl-gpio-pinfuncs-v7-1-bb091daedc52@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250902_072028_106557_F2CDC4F8 X-CRM114-Status: GOOD ( 21.51 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Tue, Sep 02, 2025 at 04:02:27PM +0200, Bartosz Golaszewski wrote: > On Tue, Sep 2, 2025 at 3:50 PM Andy Shevchenko > wrote: > > On Tue, Sep 02, 2025 at 03:29:31PM +0200, Bartosz Golaszewski wrote: > > > On Tue, Sep 2, 2025 at 3:06 PM Andy Shevchenko > > > wrote: > > > > On Tue, Sep 02, 2025 at 01:59:10PM +0200, Bartosz Golaszewski wrote: ... > > > > Fixes? > > > > > > This has always been like that. > > > > > > > Reported? > > > > > > I mean, technically Mark Brown reported my previous patch failing but > > > I don't think we do this if we're still within the same series just > > > another iteration? > > > > > > > Closes? > > > > > > Ditto. > > > > I meant that this fixes a potential issue disregard to your series, right? > > No, as long as the imx driver keeps putting stuff into the pin > function radix tree directly, this cannot happen. The issue was > triggered by the discrepancy between the number of added selectors and > the hardcoded number of functions (we started at 0 which was not in > the radix tree and crashed before we got to 1). Ah, thanks for the explanation. The problem is that current commit message implies a (potential) but lurking somewhere (regardless IMX case). Can you amend it to make more explicit that there is no bug right now. -- With Best Regards, Andy Shevchenko