From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9A0BECAC58C for ; Tue, 9 Sep 2025 17:20:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:In-Reply-To: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=KuUSi/wMj/deuFTckhCe0po1wpou4UMuleZXZpAya2o=; b=AGaJ3ZQ2sYAd4Wbky6VeVbS71L JiozLUiRmmjdv6/v1gRY3p44NTUEWLzbsoN1l/6QTOih2crXiDqXIcnsr11lj+5wV1hMbI9tdFFG7 k47MbAoST7h4h4wrDf4loou7zcLxwRdbUbZXK6NF7xXBLmlDwtRoYNSDIHN0OXjmtvAevdWI+sVmA 6+VJNuz7gpx00DpnzujllRmgzKqG6koUf5FlQLrwphPZBTwMq+ckVGzvlevcZUPxpvKxKXgL+bGJi 8PommbJVYWFhdaSZRZECyB4a1nVk80avGIklPjWGRXLAsvTnIX1LrKj9ZKx2E7m7N4lcpgktIQt9J hFyx016A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uw20d-00000008vL4-3sk3; Tue, 09 Sep 2025 17:20:00 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uvyfQ-00000007Uly-408L for linux-mediatek@lists.infradead.org; Tue, 09 Sep 2025 13:45:54 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1757425551; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KuUSi/wMj/deuFTckhCe0po1wpou4UMuleZXZpAya2o=; b=ZA8mATe8MEWGDAT7FgOEJfCfCxhJ/hpbd1yBqxg1wPv/Eyvsik24cUU/BZh0U+Ma6NGOWi eMrtAhhWqM7svqydPaub90hJZaxrE93/JqDrjdbZMSgT1B94Q+JeyrmFHDSghZO1qLcnXe 8jqvkKZjvkuJpvz8lLRJyJZWigF/WzE= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-171-mrlRl5a_NSyX2uzHaeclig-1; Tue, 09 Sep 2025 09:45:50 -0400 X-MC-Unique: mrlRl5a_NSyX2uzHaeclig-1 X-Mimecast-MFC-AGG-ID: mrlRl5a_NSyX2uzHaeclig_1757425550 Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-72e83eb8cafso89846146d6.2 for ; Tue, 09 Sep 2025 06:45:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757425550; x=1758030350; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KuUSi/wMj/deuFTckhCe0po1wpou4UMuleZXZpAya2o=; b=oAXNLTMDYC1/6PqRBM2vc/JXb0xTC2gDgxdx0WdF5D4tH6wt0HQfDgk/SsxEoQhyhW BHBrXxuecPm5XB7hCwQGaXtRnYqJkJmjmRWK75tJ8oxehDhv/B7uGYiyTDV0nJi4Gzck oEoqbwNC8moUttr45+Tfe9RouyFsrJ7PgSKU3OpLgWpyzYoXlS+Z8Z9LvZjO/WmJDjZX 6jIDRnalHoKaFg23nEo06zP930byfdUkAZL0/Kp2ahxvB2B28tn9OC0/kxdHUaIiVQhs XbII/Q3ZtRNHkKm6WzHSraXlXJEr/g6WEtRkTBI1vRTSCDHsvSpPgsL7QSVEWSJcaYL8 mEQw== X-Forwarded-Encrypted: i=1; AJvYcCVANs9/m9NOQrQVSgmw3jLcygdAfgYKEe++OpH/lf7oR9C1Be//2jT5sqyB7cJsi5whkuQrnfHeum5LD9T6sQ==@lists.infradead.org X-Gm-Message-State: AOJu0Yw+iMtWz32g7gRsL5U0NgDw86nVtEoTUuSJ2YvlxZuOEaFeB16p zKCJDWjBMSgLUBXJ0TrgfXoSvBdb1ConxliY55ZbYaDwCPYEUClGCG8m+fkT37C4GnEiZq5BJOb JCQoydHu+q+hOUmNCsbgWrjE3tOxBf+PWuQ+XEUwtcq9uIEHskWshuRTKrrOOtV/XFv51GCNRsQ == X-Gm-Gg: ASbGncurHSx7q6mtWGG99QJ1mHMH7KUKOb5et1RNvO5j2j0ivjf8gd74DNONm0zreoO 041Ta8jHb0bbhosbMo7PKNY0s0lw+SozCvJRfDfQL9sffLv0k5F0kB/jOdRCxjjP+y6gRgEQ17G 3wfjt3IuQ6U4NlWaCoQ5+JEUFcpc/zM37uN0y/AYTfXQ++AdTrCiuKeRR4mjRBJEM27yKFsYnPS 8iA3dmGIpFrz0IVXcVEenDSn1tSEBqEUfs03GdIn9sq9DTmQu2AZ1S+GaAZ0wSMIBWGcTkTg+zQ mTja+roTeL3tp/tiZcojeoyhLwx6M/k3hzvRca56QpJFAbxvj6+xCELykrs+YkDcSJ9Odp7dW0n qQY3cce5cPNsRZ9DdbtE= X-Received: by 2002:a05:6214:624:b0:70e:3e:6304 with SMTP id 6a1803df08f44-739435cc42bmr94854056d6.65.1757425549578; Tue, 09 Sep 2025 06:45:49 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEmp4FTmcXOP7+RMzS1+U7HWsbh9sfiIsI3KOLWl/uwcWgSrIp6/82zb9nfnJx9VJ/Da/CuPA== X-Received: by 2002:a05:6214:624:b0:70e:3e:6304 with SMTP id 6a1803df08f44-739435cc42bmr94853596d6.65.1757425548985; Tue, 09 Sep 2025 06:45:48 -0700 (PDT) Received: from x1 (c-73-183-52-120.hsd1.pa.comcast.net. [73.183.52.120]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-720b4665fcbsm138866926d6.37.2025.09.09.06.45.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Sep 2025 06:45:48 -0700 (PDT) Date: Tue, 9 Sep 2025 09:45:46 -0400 From: Brian Masney To: Vinod Koul Cc: Kishon Vijay Abraham I , Chun-Kuang Hu , Philipp Zabel , Chunfeng Yun , Matthias Brugger , AngeloGioacchino Del Regno , Heiko Stuebner , linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH v2 2/9] phy: mediatek: phy-mtk-hdmi-mt2701: convert from round_rate() to determine_rate() Message-ID: References: <20250810-phy-clk-round-rate-v2-0-9162470bb9f2@redhat.com> <20250810-phy-clk-round-rate-v2-2-9162470bb9f2@redhat.com> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/2.2.14 (2025-02-20) X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: JczBkNmLGqtBZ3vd39dhtyYurNnvawhpJfujF8QEYOA_1757425550 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250909_064553_069977_0102DFED X-CRM114-Status: GOOD ( 32.65 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hi Vinod, On Wed, Aug 20, 2025 at 01:27:35PM -0400, Brian Masney wrote: > On Wed, Aug 20, 2025 at 09:59:25PM +0530, Vinod Koul wrote: > > On 10-08-25, 18:45, Brian Masney wrote: > > > The round_rate() clk ops is deprecated, so migrate this driver from > > > round_rate() to determine_rate() using the Coccinelle semantic patch > > > on the cover letter of this series. > > > > > > Signed-off-by: Brian Masney > > > --- > > > drivers/phy/mediatek/phy-mtk-hdmi-mt2701.c | 8 ++++---- > > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > > > diff --git a/drivers/phy/mediatek/phy-mtk-hdmi-mt2701.c b/drivers/phy/mediatek/phy-mtk-hdmi-mt2701.c > > > index e51b2d13eab473dddace48c75c2a8d73c8c65635..b0b6497e7eedcb6867541b573d22156ded29a4d5 100644 > > > --- a/drivers/phy/mediatek/phy-mtk-hdmi-mt2701.c > > > +++ b/drivers/phy/mediatek/phy-mtk-hdmi-mt2701.c > > > @@ -90,10 +90,10 @@ static void mtk_hdmi_pll_unprepare(struct clk_hw *hw) > > > usleep_range(80, 100); > > > } > > > > > > -static long mtk_hdmi_pll_round_rate(struct clk_hw *hw, unsigned long rate, > > > - unsigned long *parent_rate) > > > +static int mtk_hdmi_pll_determine_rate(struct clk_hw *hw, > > > + struct clk_rate_request *req) > > > { > > > - return rate; > > > + return 0; > > > > This does not sound correct to me? should this not check the requested > > rate? > > I can't speak as to whether or not this specific driver should have a > rate check here. I've seen in some other drivers where the specific > frequencies are managed in firmware, and Linux just passes on the rate > request as is. > > Some other phy drivers (most notably drivers/gpu/drm/msm/dsi/phy/) only > makes sure that the requested rate is within a min/max range. Assuming > I read this driver's set_rate() correctly, it looks like the min/max > range may be 64-192 MHz. I'm not sure to be honest. > > This change keeps the existing behavior of the driver as it is today, > and just migrates off an old API. I'm just checking to see if you have any questions about this series, and plan to merge it for v6.18. I'm hoping that in v6.19 to remove this old API from the clk core once all of the other subsystems outside of drivers/clk/ have been updated. As I mentioned previously: This change keeps the existing behavior of the driver as it is today, and just migrates off an old API. I don't have access to this hardware, or technical details about what should be here. Brian