From: Dan Carpenter <dan.carpenter@linaro.org>
To: Felix Fietkau <nbd@nbd.name>
Cc: linux-mediatek@lists.infradead.org
Subject: [bug report] wifi: mt76: mt7996: improve hardware restart reliability
Date: Tue, 23 Sep 2025 14:26:55 +0300 [thread overview]
Message-ID: <aNKD_5EjKS9f45Kt@stanley.mountain> (raw)
Hello Felix Fietkau,
Commit ace5d3b6b49e ("wifi: mt76: mt7996: improve hardware restart
reliability") from Sep 15, 2025 (linux-next), leads to the following
Smatch static checker warning:
drivers/net/wireless/mediatek/mt76/mt7996/mac.c:2458 mt7996_mac_full_reset()
warn: assigning signed to unsigned
drivers/net/wireless/mediatek/mt76/mt7996/mac.c
2448 while (!list_empty(&list)) {
2449 struct mt7996_wed_rro_session_id *e;
2450
2451 e = list_first_entry(&list, struct mt7996_wed_rro_session_id,
2452 list);
2453 list_del_init(&e->list);
2454 kfree(e);
2455 }
2456
2457 i = mt76_wcid_alloc(dev->mt76.wcid_mask, MT7996_WTBL_STA);
i could be -1
--> 2458 dev->mt76.global_wcid.idx = i;
^^^^^^^^
saving -1 to a u16
2459 dev->recovery.hw_full_reset = false;
2460
2461 mutex_unlock(&dev->mt76.mutex);
2462
2463 ieee80211_restart_hw(mt76_hw(dev));
2464 }
regards,
dan carpenter
reply other threads:[~2025-09-23 11:27 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aNKD_5EjKS9f45Kt@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=nbd@nbd.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox