From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5299DCCF9E0 for ; Tue, 28 Oct 2025 17:13:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=C43Q3YBXi+t2Vk4E/E5I2wTUl/T4dq5/Lacl/dvHcyE=; b=EdhEdfoJmaDoVM7KkFc8hvR63L Gc5K5VFZmSjevMkYBITS2ngUjvqL3luVOVCZ4/3bL2n0v3xbDbNitUlDgdBzekq9zhB6AMwWpJAMQ x6O4Y3cPDkwXgwFA7eR6ODKjyWnzBUAflp8Lpyd55sxZdlIJCKhxF68Goq4KCr53pUin516Jav71G xzT97opr1DCAllJR5RFId8zN3BzcI1VKEjCTrgORxBZPTqzlF+y8YnnQr3Za9qYrOXDlLxt8qckVE AIuq/OtqysoU/aj3rBecEnyoaPb9C6J4kKMKs200E5NYPU5FXIT27+SG3j0a+hzw0xoYVPmSff3kl 0Q0ANVGg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vDnFr-0000000GOCW-2KAw; Tue, 28 Oct 2025 17:13:07 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vDnFp-0000000GOB8-2WX7 for linux-mediatek@lists.infradead.org; Tue, 28 Oct 2025 17:13:06 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8E21C26B9 for ; Tue, 28 Oct 2025 10:12:55 -0700 (PDT) Received: from e110455-lin.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 276C13F673 for ; Tue, 28 Oct 2025 10:13:03 -0700 (PDT) Date: Tue, 28 Oct 2025 17:12:35 +0000 From: Liviu Dudau To: Nicolas Frattaroli Cc: AngeloGioacchino Del Regno , Boris Brezillon , Jassi Brar , Chia-I Wu , Chen-Yu Tsai , Steven Price , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , Kees Cook , "Gustavo A. R. Silva" , Ulf Hansson , kernel@collabora.com, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-hardening@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH v8 1/5] dt-bindings: gpu: mali-valhall-csf: add mediatek,mt8196-mali variant Message-ID: References: <20251017-mt8196-gpufreq-v8-0-98fc1cc566a1@collabora.com> <20251017-mt8196-gpufreq-v8-1-98fc1cc566a1@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20251017-mt8196-gpufreq-v8-1-98fc1cc566a1@collabora.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251028_101305_763334_6182C13A X-CRM114-Status: GOOD ( 22.81 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Fri, Oct 17, 2025 at 05:31:08PM +0200, Nicolas Frattaroli wrote: > The Mali-based GPU on the MediaTek MT8196 SoC uses a separate MCU to > control the power and frequency of the GPU. This is modelled as a power > domain and clock provider. > > It lets us omit the OPP tables from the device tree, as those can now be > enumerated at runtime from the MCU. > > Add the necessary schema logic to handle what this SoC expects in terms > of clocks and power-domains. > > Reviewed-by: Rob Herring (Arm) > Reviewed-by: AngeloGioacchino Del Regno > Signed-off-by: Nicolas Frattaroli > --- > .../bindings/gpu/arm,mali-valhall-csf.yaml | 37 +++++++++++++++++++++- > 1 file changed, 36 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-valhall-csf.yaml b/Documentation/devicetree/bindings/gpu/arm,mali-valhall-csf.yaml > index 613040fdb444..860691ce985e 100644 > --- a/Documentation/devicetree/bindings/gpu/arm,mali-valhall-csf.yaml > +++ b/Documentation/devicetree/bindings/gpu/arm,mali-valhall-csf.yaml > @@ -45,7 +45,9 @@ properties: > minItems: 1 > items: > - const: core > - - const: coregroup > + - enum: > + - coregroup > + - stacks > - const: stacks I'm not sure how to parse this part of the change. We're overwriting the property for mt8196-mali anyway so why do we need this? And if we do, should 'stacks' still remain as a const? Best regards, Liviu > > mali-supply: true > @@ -110,6 +112,27 @@ allOf: > power-domain-names: false > required: > - mali-supply > + - if: > + properties: > + compatible: > + contains: > + const: mediatek,mt8196-mali > + then: > + properties: > + mali-supply: false > + sram-supply: false > + operating-points-v2: false > + power-domains: > + maxItems: 1 > + power-domain-names: false > + clocks: > + maxItems: 2 > + clock-names: > + items: > + - const: core > + - const: stacks > + required: > + - power-domains > > examples: > - | > @@ -145,5 +168,17 @@ examples: > }; > }; > }; > + - | > + gpu@48000000 { > + compatible = "mediatek,mt8196-mali", "arm,mali-valhall-csf"; > + reg = <0x48000000 0x480000>; > + clocks = <&gpufreq 0>, <&gpufreq 1>; > + clock-names = "core", "stacks"; > + interrupts = , > + , > + ; > + interrupt-names = "job", "mmu", "gpu"; > + power-domains = <&gpufreq>; > + }; > > ... > > -- > 2.51.0 > -- ==================== | I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --------------- ¯\_(ツ)_/¯