From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 14CEA105A56D for ; Thu, 12 Mar 2026 10:56:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=YHiQHdM7Z712lCJRjiNQUGnM8MWO5qQMIBaZ2wYzrz0=; b=wH6I0EnqRpLnlMsScGnzRsG+lI 6uMBkexhWgm8o/DaghoUgB6wTXQSlyd4q3EHS7KVfEuV3rbqi70HrPK2iKikLaDztCMxvbSGgyc+l yD05rz0bY4PYW5L8B3pVrCcMfneK+RHEshilwPHTfIBSXdiWt4KAt0H+d5e2o9nENdVOFkwYl7xV0 oca0Cgo5zzUTbSYQuK70InZPuGw8xAiepiVNk9l9MPmxFlUJmRvRbg37/mHB4OaVOHHLEvy4LIBx2 VrG2qSfnDTRoWLgPd0a+QR7UBvhqIpcaxEaUUpwdl6D5kki3X+fdcWMZ7BqGhA0Lgu7MjXSYhorGs G+mZRdSg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1w0di1-0000000Dtwe-1xhW; Thu, 12 Mar 2026 10:56:05 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1w0dhz-0000000DtwL-4AZx for linux-mediatek@lists.infradead.org; Thu, 12 Mar 2026 10:56:04 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 03E9F60141; Thu, 12 Mar 2026 10:56:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 315EBC4CEF7; Thu, 12 Mar 2026 10:56:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773312962; bh=PE2oXMT0MgH0+Y1J0/akG+DThOQW/ZAHT5MvozIoPpw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=N7TmRCkcZ1mouWhOJMK2LcQIxHkYTroNtnSszOwda6rdXXq7lCsQk8fsIFKRrzwRn h2bYAXuiK7eFJ45wpVNEib2cdjzHbYRWKojNQa0TEbuJ89qth8W3wdXdnTEax5Wh02 UdSgG5B3EcahVm/tO/d5PcNmmR3bu9Hg3QQLD3POpyk4tvPXOY1XX/yupmywKG7kz3 Pc1PO+JFnTc0V6Xd/53ic91mXn0/9cSV68idPQBckEAIz7Emh9GCXMfhXvr7VnTVAS AnJvmsfpbai8i1RZlgrR954qGpKR0kaIef3oWxWHsVjJfnYEjW8ic4fhiGY07fJCDG iJ5/tSDFKNE1Q== Date: Thu, 12 Mar 2026 11:56:00 +0100 From: Lorenzo Bianconi To: Shayne Chen Cc: Felix Fietkau , linux-wireless , Ryder Lee , Evelyn Tsai , Money Wang , linux-mediatek , StanleyYP Wang Subject: Re: [PATCH mt76 6/6] wifi: mt76: mt7996: fix issues with manually triggered radar detection Message-ID: References: <20260312095724.2117448-1-shayne.chen@mediatek.com> <20260312095724.2117448-6-shayne.chen@mediatek.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="JvqYH7pQCmJRC4yZ" Content-Disposition: inline In-Reply-To: <20260312095724.2117448-6-shayne.chen@mediatek.com> X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org --JvqYH7pQCmJRC4yZ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > From: StanleyYP Wang >=20 > Disallow triggering radar detection on non-DFS channels to prevent paused > TX queues from failing to resume, as a channel switch is not performed in > this case. I guess we are missing a Fixes tag here. >=20 > Signed-off-by: StanleyYP Wang > Signed-off-by: Shayne Chen > --- > .../wireless/mediatek/mt76/mt7996/debugfs.c | 22 +++++++++++++++---- > 1 file changed, 18 insertions(+), 4 deletions(-) >=20 > diff --git a/drivers/net/wireless/mediatek/mt76/mt7996/debugfs.c b/driver= s/net/wireless/mediatek/mt76/mt7996/debugfs.c > index 76d623b2cafb..e26bed6b97e7 100644 > --- a/drivers/net/wireless/mediatek/mt76/mt7996/debugfs.c > +++ b/drivers/net/wireless/mediatek/mt76/mt7996/debugfs.c > @@ -226,14 +226,23 @@ mt7996_radar_trigger(void *data, u64 val) > #define RADAR_BACKGROUND 2 > struct mt7996_dev *dev =3D data; > struct mt7996_phy *phy =3D mt7996_band_phy(dev, NL80211_BAND_5GHZ); > - int rdd_idx; > + struct cfg80211_chan_def *chandef; > + int rdd_idx, ret; > =20 > if (!phy || !val || val > RADAR_BACKGROUND) > return -EINVAL; > =20 > - if (val =3D=3D RADAR_BACKGROUND && !dev->rdd2_phy) { > - dev_err(dev->mt76.dev, "Background radar is not enabled\n"); > - return -EINVAL; > + if (test_bit(MT76_SCANNING, &phy->mt76->state)) > + return -EBUSY; > + > + if (val =3D=3D RADAR_BACKGROUND) { > + if (!dev->rdd2_phy || !cfg80211_chandef_valid(&dev->rdd2_chandef)) { > + dev_err(dev->mt76.dev, "Background radar is not enabled\n"); nit: I guess it is better to specify a different error message if rdd2_chan= def is invalid. Regards, Lorenzo > + return -EINVAL; > + } > + chandef =3D &dev->rdd2_chandef; > + } else { > + chandef =3D &phy->mt76->chandef; > } > =20 > rdd_idx =3D mt7996_get_rdd_idx(phy, val =3D=3D RADAR_BACKGROUND); > @@ -242,6 +251,11 @@ mt7996_radar_trigger(void *data, u64 val) > return -EINVAL; > } > =20 > + ret =3D cfg80211_chandef_dfs_required(dev->mt76.hw->wiphy, chandef, > + NL80211_IFTYPE_AP); > + if (ret <=3D 0) > + return ret; > + > return mt7996_mcu_rdd_cmd(dev, RDD_RADAR_EMULATE, rdd_idx, 0); > } > =20 > --=20 > 2.51.0 >=20 --JvqYH7pQCmJRC4yZ Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCabKbwAAKCRA6cBh0uS2t rJOrAP4rmPP1xy2RrdZD846t4P/TbP9rH9yYKlIDBIOLhqFgBgEAmfK6w7IZqCe5 Hzom0sNpM8koVba5F3l9DCKKial9/Q8= =GRDW -----END PGP SIGNATURE----- --JvqYH7pQCmJRC4yZ--