Re: [PATCH v8 1/7] dt-bindings: mediatek: mt8188: Add binding for MM & INFRA IOMMU

["Yong Wu (吴勇)" <Yong.Wu@mediatek.com>]

Hi Krzysztof,

Thanks very much for your help review.

On Wed, 2023-03-08 at 11:35 +0100, Krzysztof Kozlowski wrote:
> On 07/03/2023 09:05, Yong Wu wrote:
> > From: "Chengci.Xu" <chengci.xu@mediatek.com>
> > 
> > Add descriptions for mt8188 IOMMU which also use ARM Short-
> > Descriptor
> > translation table format.
> > 
> > In mt8188, there are two smi-common HW and IOMMU, one is for
> > vdo(video
> > output), the other is for vpp(video processing pipe). They connects
> > with different smi-larbs, then some setting(larbid_remap) is
> > different.
> > Differentiate them with the compatible string.
> > 
> > Something like this:
> > 
> >   IOMMU(VDO)          IOMMU(VPP)
> >       |                   |
> > SMI_COMMON_VDO      SMI_COMMON_VPP
> > 
> > ---------------     ----------------
> >   |     |    ...      |     |    ...
> > larb0 larb2  ...    larb1 larb3  ...
> > 
> > We also have an IOMMU that is for infra master like PCIe.
> > And infra master don't have the larb and ports.
> > 
> > Signed-off-by: Chengci.Xu <chengci.xu@mediatek.com>
> > Reviewed-by: Yong Wu <yong.wu@mediatek.com>
> > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> Indeed, I missed broken checkpatch/DCO chain.

Just confirm what this means.

Do you mean MAINTAINERS need to be updated since we add a prefix
"mediatek," for the header file?


> 
> NAK. Please fix the chain.
> 
> Best regards,
> Krzysztof
>