Re: [PATCH v3 54/65] clk: da8xx: clk48: Switch to determine_rate

David Lechner
2023-04-05T15:04:53Z

On 4/4/23 5:11 AM, Maxime Ripard wrote:
> The TI DA8xx USB0 clk48 clocks implements a mux with a set_parent
> hook, but doesn't provide a determine_rate implementation.
>
> This is a bit odd, since set_parent() is there to, as its name implies,
> change the parent of a clock. However, the most likely candidate to
> trigger that parent change is a call to clk_set_rate(), with
> determine_rate() figuring out which parent is the best suited for a
> given rate.
>

As mentioned in my previous review, parent is selected by device
tree and should never be changed after init.