From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 901BCCD98C5 for ; Mon, 15 Jun 2026 07:10:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=B63Rr7BRtf10FMXqKBI22vFs9Wx6/aB3dAFnmxB7moU=; b=plWsUMPEj29xsv/9D9CH75WkNF atDzmjkoxpTK0xvyAiS+1nKu/83oAHN+ujrj5oVzzyainbL1vpzw8DTPe+JRtuE0xWy3Dr9zfPFYZ GIcEGZUA+lVGMCVZJezZSXnaomQ95ynKVMcYeZT3+eLM6Ei82seWQ4AtmrHEzUDuE3jcveVDEg+ye qOg9gWcjYAyRiB60B8KW/AXvDmvVskdVj/VPSL3kvoDmM4fHetzqkgzxal9snzJAzyTT9+V3IlFkh fGK9joOGiNJlAa6TLX00syNjggAWCNnTP6jIgsujaJwAAqK6DSlSSUGz0avOh2hDSXxr8De+sayzC mv7GRZ5A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wZ1Sw-0000000Dk7h-0t2r; Mon, 15 Jun 2026 07:10:38 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wZ1Su-0000000Dk7Y-29ff for linux-mediatek@lists.infradead.org; Mon, 15 Jun 2026 07:10:36 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id D774940C1C; Mon, 15 Jun 2026 07:10:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 360CC1F000E9; Mon, 15 Jun 2026 07:10:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1781507435; bh=B63Rr7BRtf10FMXqKBI22vFs9Wx6/aB3dAFnmxB7moU=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=KZZ8ooGlkJbDgwEsr1XL6BNAQCABBxMW84Yzff07H25+wSgrg5qu3lAlbQNbNxdKi Rbvfst8tGzfV5LigDKVSaiGRcT3n+KsDBg8iDn3Nb+8oaUGQBs2gueqP+v4Rq6xdFM iin3kls1iw04SvbMxYKwLZ89b1+97EjF5wA9YPP0g1ADeRkWRnFy8bnKeYRFWCzrry 4wQmGDy68l4X3xhRM7euLtbwsiVX19Wohmtaqx1qw6K/YPHM+656D0s+8aHWtEnbL0 D4Qiw3Ww7l4t49fLNgQq0iegILvE1mD7vK9qTXVzSE6NUR+Yd5P24YDYhm7PhTyVJQ aANreiFZ2Xv0A== Date: Mon, 15 Jun 2026 09:10:31 +0200 From: Lorenzo Bianconi To: Sean Wang Cc: Felix Fietkau , linux-wireless@vger.kernel.org, linux-mediatek@lists.infradead.org, Sean Wang Subject: Re: [PATCH 5/5] wifi: mt76: mt7927u: enable USB RX aggregation Message-ID: References: <20260613224655.2405686-1-sean.wang@kernel.org> <20260613224655.2405686-6-sean.wang@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="G88a4jpSspo+4gZ9" Content-Disposition: inline In-Reply-To: <20260613224655.2405686-6-sean.wang@kernel.org> X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org --G88a4jpSspo+4gZ9 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > From: Sean Wang >=20 > Enable USB RX aggregation on MT7927u with vendor driver parameters for > alignment, padding and buffer size. According to the vendor driver, the > hardware should run RX aggregation with USB SG disabled. >=20 > Signed-off-by: Sean Wang > --- > drivers/net/wireless/mediatek/mt76/mt7925/usb.c | 6 +++++- > drivers/net/wireless/mediatek/mt76/usb.c | 11 +++++++++++ > 2 files changed, 16 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/net/wireless/mediatek/mt76/mt7925/usb.c b/drivers/ne= t/wireless/mediatek/mt76/mt7925/usb.c > index a0bfe6f09ae4..42d13bc6ebbc 100644 > --- a/drivers/net/wireless/mediatek/mt76/mt7925/usb.c > +++ b/drivers/net/wireless/mediatek/mt76/mt7925/usb.c > @@ -5,7 +5,6 @@ > #include > #include > #include > - > #include "mt7925.h" > #include "mcu.h" > #include "mac.h" > @@ -235,6 +234,11 @@ static int mt7925u_probe(struct usb_interface *usb_i= ntf, > mdev->rev =3D (0x7927 << 16) | (mdev->rev & 0xff); > } > =20 > + if (is_mt7927(mdev)) > + mt76u_enable_rx_aggr(mdev, MT7927_USB_RX_AGGR_ALIGN, > + MT7927_USB_RX_AGGR_PADDING, > + MT7927_USB_RX_AGGR_BUF_SIZE); This seems to me something like a NETIF_F_GRO_HW. Should the user be able to toggle it via ethtool? Regards, Lorenzo > + > if (mt76_get_field(dev, MT_CONN_ON_MISC, MT_TOP_MISC2_FW_N9_RDY)) { > ret =3D mt792xu_wfsys_reset(dev); > if (ret) > diff --git a/drivers/net/wireless/mediatek/mt76/usb.c b/drivers/net/wirel= ess/mediatek/mt76/usb.c > index 10ad2b024985..f0df510904c5 100644 > --- a/drivers/net/wireless/mediatek/mt76/usb.c > +++ b/drivers/net/wireless/mediatek/mt76/usb.c > @@ -1300,6 +1300,17 @@ static const struct mt76_queue_ops usb_queue_ops = =3D { > .kick =3D mt76u_tx_kick, > }; > =20 > +void mt76u_enable_rx_aggr(struct mt76_dev *dev, int align, int padding, > + int buf_size) > +{ > + dev->usb.sg_en =3D false; > + dev->usb.rx_aggr.enable =3D true; > + dev->usb.rx_aggr.align =3D align; > + dev->usb.rx_aggr.padding =3D padding; > + dev->usb.rx_aggr.buf_size =3D buf_size; > +} > +EXPORT_SYMBOL_GPL(mt76u_enable_rx_aggr); > + > int __mt76u_init(struct mt76_dev *dev, struct usb_interface *intf, > struct mt76_bus_ops *ops) > { > --=20 > 2.43.0 >=20 --G88a4jpSspo+4gZ9 Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCai+lYgAKCRA6cBh0uS2t rGkmAQDpJFWPjvmC0UYH6mNRDhrH2NtuSnd6XC8lal6FDOuxLwD/V6Ulxi/ICKS5 tKv6G9I+PGb0M74xveAHFQu7ljHy7Q8= =2Nz/ -----END PGP SIGNATURE----- --G88a4jpSspo+4gZ9--