From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C9D69C43458 for ; Thu, 9 Jul 2026 14:28:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:In-Reply-To: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=92JJ36rrwvvb7yLlV9W9rV0xnJPT/KBmVXI1YNHLk7c=; b=arHb77q2KmE30yiUZgKnUVevyD QN0N8aVdeSNsh5cSjEre+H8tDH0+mlsolI7y5GH6Pf9iDMdJ6Bf0ByZwsbdfE8HctJ8Yak1rQsfBP ps+VnUZ2u/AUFf+NFtAAG81UBpvTdq+Z03435zG1ww2lro1zIdwwnraM8GgJ9WWKceOxVCZu6afcM l8zvmz4s+9nkqDXEAfPNm4ESpdes65na8tz1afT0PEYOOoOk8hbsMHxGUWuj3d2KZlwaARp2gPMCU KnK8Pn2m1S+YkzVrvJFAqaNVxzBxsWsRVoRnuWlZSf1YBfYeoU2Y26M9XY40WDZ/AjMdpn2UrUqIW NoRvWskg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1whpjd-00000002l6P-3JFZ; Thu, 09 Jul 2026 14:28:17 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1whpjZ-00000002l4B-33GL for linux-mediatek@lists.infradead.org; Thu, 09 Jul 2026 14:28:17 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1783607292; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=92JJ36rrwvvb7yLlV9W9rV0xnJPT/KBmVXI1YNHLk7c=; b=jTjzgptwPo20f9zD7f0S9uwQWmbqDBjnYzNBwkMSWoLfWn/OhaJvNvzzffNfpZiMFPiPXA /ASFojpjyIFs1/DbXAd5dA2vqQ+Dh0mT5waEYkGFMHzHwVo4teWNOLKxqPRB64F24FpHez RAgI11AEJJp8RfEY9s/k8INxalFygFc= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-117-lvGUv5k_PJadQ9SvxnQm8w-1; Thu, 09 Jul 2026 10:28:09 -0400 X-MC-Unique: lvGUv5k_PJadQ9SvxnQm8w-1 X-Mimecast-MFC-AGG-ID: lvGUv5k_PJadQ9SvxnQm8w_1783607288 Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-92e8004d60eso413587585a.1 for ; Thu, 09 Jul 2026 07:28:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783607288; x=1784212088; h=user-agent:in-reply-to:content-disposition:content-type :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=92JJ36rrwvvb7yLlV9W9rV0xnJPT/KBmVXI1YNHLk7c=; b=R1SB4bbkADkjwTtVGUGsBL8/UW7Ya9WT/raAvWOUqRiEiI8Ocvm7qP1xtOGg3tSbYI hBnTn13URN50IjCW+7rF8gPuo0GbxjWsBLEoIuaNkMbSrcLbzjRgREpJ3sPmKkqZ16EH 0f+vw+hUc9Aety39yKBA+LWESz7XLax5+vbkFODVnxizg3EV8AP12BneIA9CTvJ+KXZk +SyYhBKAR2Tl+4/lHUOtZTcvLE4uPKFgRYXZkptl0fh4ySsTGU9t9jaMILDTRc5DVzOc Snkba5AUt3u6D/S7WkV+Wjcu8G4Z7gwdN3AyfYArFJFkWg9sN0KNm6XAD5+yHpGpHmTD +wEQ== X-Forwarded-Encrypted: i=1; AHgh+Roh0gDivWq0D5Vm+LQwkyvvnLu3NssVXkxr1eMDmSPx0kpv8I4P4xAYJgMy1bR+WYnod+rvyiTyZrUBNysXZA==@lists.infradead.org X-Gm-Message-State: AOJu0YzbJHEHH3z51AYt3590zxCmQSO0sbv01Ul6ABmq9l5OMnvPjMss WRB2OcGevM/KZ7Hos8wxIafTZY4BMmy/yxaVu5fOdzxphP+oyr8198VNg0Gpi5HRDvYR8DZ/2SC XCA3aK4VY5neZr9zDh5fJjxGN9sMdmv1EmbOhEEIIH7RGXFroNDeN3KF2kgZTG84ScJWQsrNKeg == X-Gm-Gg: AfdE7cnCGrWy+HzikQIK9u9oXXtqT2q6VlDnaZsfDJYyAK75ihdFH8+4rexi3Azhq7V yE4GeJTt0soUQaBjs0M/gbPbz3rXscavPmDzRJfH/erO/rzamAMLAE/UgjVeMdzRXsI3MwnvdCM Y1GTkAZBZNGZxJ85VIk0rxOfPDrpHOgYGMM0G+2oeZ3nW+sFrQ0GXZ8hLlXFFtbrZ2TlVKAx1lb Bq4UOQnxvehBOMEGelTKIV7tRTXkzN7bKWtGZOZGBdFomokyXcDzYPuSs0dTCdEgx8aFJYfaTpR f6Ks9nw47Zk/bCiXqlQ/rjL4cjJRebnY8wsuxdqOyob6gOoglZnG7rNjQ7PzIkXr0Sx/LRLolia ldCho0YkNA3heONgPQOVe2uD213XIhUOo+t+giqG1rsjtVQ== X-Received: by 2002:ac8:7fc8:0:b0:51c:2068:a9f8 with SMTP id d75a77b69052e-51c8b399047mr79250361cf.5.1783607288359; Thu, 09 Jul 2026 07:28:08 -0700 (PDT) X-Received: by 2002:ac8:7fc8:0:b0:51c:2068:a9f8 with SMTP id d75a77b69052e-51c8b399047mr79249991cf.5.1783607287938; Thu, 09 Jul 2026 07:28:07 -0700 (PDT) Received: from redhat.com (c-73-183-53-213.hsd1.pa.comcast.net. [73.183.53.213]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-51c41d2cde7sm173167731cf.18.2026.07.09.07.28.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Jul 2026 07:28:07 -0700 (PDT) Date: Thu, 9 Jul 2026 10:28:04 -0400 From: Brian Masney To: Louis-Alexis Eyraud Cc: Michael Turquette , Stephen Boyd , Matthias Brugger , AngeloGioacchino Del Regno , Chen-Yu Tsai , Edward-JW Yang , Johnson Wang , kernel@collabora.com, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH v2] clk: mediatek: pllfh: Fix IO remapping leak in register_pllfhs error path Message-ID: References: <20260709-clk-mediatek-pllfh-fix-v2-1-a235078fe9d5@collabora.com> MIME-Version: 1.0 In-Reply-To: <20260709-clk-mediatek-pllfh-fix-v2-1-a235078fe9d5@collabora.com> User-Agent: Mutt/2.3.2 (2026-04-26) X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Bj_ZCNRsTVhpZor1UcFMvARxxDDv11QIxLLXd29Toeo_1783607288 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260709_072813_837082_CF24B052 X-CRM114-Status: GOOD ( 15.27 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Thu, Jul 09, 2026 at 02:23:00PM +0200, Louis-Alexis Eyraud wrote: > When mtk_clk_register_pllfhs function fails to register a PLL, it > unregisters all PLLs and cleans up itself in its error path before > returning, so the function callers don't need to do it. > > But contrary to mtk_clk_unregister_pllfhs function, that does almost > the same sequence, it does not free the IO memory mapped on fhctl node, > leading to a leak. > > Fix this leak by factorizing the cleanup sequence in a new private > function and use it both mtk_clk_register_pllfhs and > mtk_clk_unregister_pllfhs functions. > > Also, change the loop index start value to avoid the -1 operation on > index at each loop. > > Fixes: d7964de8a8ea ("clk: mediatek: Add new clock driver to handle FHCTL hardware") > Signed-off-by: Louis-Alexis Eyraud Reviewed-by: Brian Masney