From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Uwe Kleine-König (The Capable Hub)" <u.kleine-koenig@baylibre.com>
Cc: "Lee Jones" <lee@kernel.org>,
"Florian Fainelli" <florian.fainelli@broadcom.com>,
"Broadcom internal kernel review list"
<bcm-kernel-feedback-list@broadcom.com>,
"Ray Jui" <rjui@broadcom.com>,
"Scott Branden" <sbranden@broadcom.com>,
mfd@lists.linux.dev, linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
linux-mediatek@lists.infradead.org,
"Qunqin Zhao" <zhaoqunqin@loongson.cn>,
linux-crypto@vger.kernel.org,
"Benson Leung" <bleung@chromium.org>,
"Guenter Roeck" <groeck@chromium.org>,
chrome-platform@lists.linux.dev,
"Colin Foster" <colin.foster@in-advantage.com>,
"David Rhodes" <david.rhodes@cirrus.com>,
"Richard Fitzgerald" <rf@opensource.cirrus.com>,
"Mika Westerberg" <mika.westerberg@linux.intel.com>,
"Zha Qipeng" <qipeng.zha@intel.com>,
"Thomas Richard" <thomas.richard@bootlin.com>,
linux-sound@vger.kernel.org, patches@opensource.cirrus.com,
"Xu Yilun" <yilun.xu@intel.com>, "Tom Rix" <trix@redhat.com>,
"Michael Hennerich" <michael.hennerich@analog.com>,
"Chen-Yu Tsai" <wens@kernel.org>,
"Marek Vasut" <marek.vasut+renesas@gmail.com>,
"James Ogletree" <jogletre@opensource.cirrus.com>,
"Fred Treven" <fred.treven@cirrus.com>,
"Ben Bright" <ben.bright@cirrus.com>,
"Support Opensource" <support.opensource@diasemi.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Charles Keepax" <ckeepax@opensource.cirrus.com>,
"Chanwoo Choi" <cw00.choi@samsung.com>,
"Krzysztof Kozlowski" <krzk@kernel.org>,
"André Draszik" <andre.draszik@linaro.org>,
"Aaro Koskinen" <aaro.koskinen@iki.fi>,
"Andreas Kemnade" <andreas@kemnade.info>,
"Kevin Hilman" <khilman@baylibre.com>,
"Roger Quadros" <rogerq@kernel.org>,
"Tony Lindgren" <tony@atomide.com>,
"Andreas Werner" <andreas.werner@men.de>,
"Samuel Kayode" <samkay014@gmail.com>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
linux-renesas-soc@vger.kernel.org, linux-omap@vger.kernel.org,
imx@lists.linux.dev, linux-stm32@st-md-mailman.stormreply.com,
"Linus Walleij" <linusw@kernel.org>,
linux@ew.tq-group.com,
"Nicolas Ferre" <nicolas.ferre@microchip.com>,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
"Claudiu Beznea" <claudiu.beznea@tuxon.dev>,
"Peter Griffin" <peter.griffin@linaro.org>,
"Alim Akhtar" <alim.akhtar@samsung.com>,
"Tim Harvey" <tharvey@gateworks.com>,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Sven Peter" <sven@kernel.org>, "Janne Grunau" <j@jannau.net>,
"Neal Gompa" <neal@gompa.dev>,
"Mathieu Dubois-Briand" <mathieu.dubois-briand@bootlin.com>,
"Luca Ceresoli" <luca.ceresoli@bootlin.com>,
"Saravanan Sekar" <sravanhome@gmail.com>,
"Frank Li" <Frank.Li@nxp.com>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Fabio Estevam" <festevam@gmail.com>,
"Jonathan Neuschäfer" <j.neuschaefer@gmx.net>,
"Matti Vaittinen" <mazziesaccount@gmail.com>,
"Orson Zhai" <orsonzhai@gmail.com>,
"Baolin Wang" <baolin.wang@linux.alibaba.com>,
"Chunyan Zhang" <zhang.lyra@gmail.com>,
"Fabrice Gasnier" <fabrice.gasnier@foss.st.com>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
"Samuel Holland" <samuel@sholland.org>,
"Liviu Dudau" <liviu.dudau@arm.com>,
"Sudeep Holla" <sudeep.holla@kernel.org>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Magnus Damm" <magnus.damm@gmail.com>,
linux-samsung-soc@vger.kernel.org,
linux-amlogic@lists.infradead.org, asahi@lists.linux.dev,
linux-arm-msm@vger.kernel.org, linux-sunxi@lists.linux.dev,
"Peter Tyser" <ptyser@xes-inc.com>
Subject: Re: [PATCH v2 00/23] mfd: Use named initializers for arrays of *_device_data
Date: Wed, 8 Jul 2026 14:34:33 +0300 [thread overview]
Message-ID: <ak41yQp3x78s4Fmx@ashevche-desk.local> (raw)
In-Reply-To: <cover.1783507945.git.u.kleine-koenig@baylibre.com>
On Wed, Jul 08, 2026 at 01:15:07PM +0200, Uwe Kleine-König (The Capable Hub) wrote:
> Hello,
>
> this series superseeds my previous patch "[PATCH v1] mfd: Use named
> initializers for arrays of i2c_device_data"
> (https://lore.kernel.org/lkml/20260515095839.4005460-2-u.kleine-koenig@baylibre.com)
> that Lee asked me to rebase and also the series "[PATCH v1 0/3] mfd:
> Initialize spi_device_id arrays using member names"
> (https://lore.kernel.org/lkml/cover.1783003256.git.u.kleine-koenig@baylibre.com).
>
> The objective for this series is to prepare mfd for changing
> of_device_id etc to make driver_data a union, see
> https://lore.kernel.org/all/cover.1780048925.git.u.kleine-koenig@baylibre.com/
> for the idea behind it.
>
> This series is based on yesterday's next/master and it does the
> restructuring not only for i2c and spi (as the two series mentioned
> above), but for all *_device_id structures that I intend to modify with
> a union that affect mfd. So (I hope) this is the only patch series
> affecting mfd for this quest.
>
> I don't care much about the last few patches unifying the coding style.
> I think it's a good opportunity to do that, but if you don't like them,
> just don't apply these.
The patches bring inconsistency (or still leave it) with the terminator style
in both I²C and ACPI ID tables. Can you revisit that?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-07-08 11:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-08 11:15 [PATCH v2 00/23] mfd: Use named initializers for arrays of *_device_data Uwe Kleine-König (The Capable Hub)
2026-07-08 11:15 ` [PATCH v2 05/23] mfd: mt6360: Drop irrelevant __maybe_unused Uwe Kleine-König (The Capable Hub)
2026-07-08 11:15 ` [PATCH v2 09/23] mfd: Drop unused assignment of platform_device_id driver data Uwe Kleine-König (The Capable Hub)
2026-07-08 11:15 ` [PATCH v2 16/23] mfd: Use named initializers for platform_device_id array Uwe Kleine-König (The Capable Hub)
2026-07-09 19:35 ` Linus Walleij
2026-07-08 11:15 ` [PATCH v2 21/23] mfd: Unify style of of_device_id arrays Uwe Kleine-König (The Capable Hub)
2026-07-08 12:18 ` Charles Keepax
2026-07-08 12:58 ` André Draszik
2026-07-10 19:36 ` Linus Walleij
2026-07-08 11:34 ` Andy Shevchenko [this message]
2026-07-09 16:08 ` [PATCH v2 00/23] mfd: Use named initializers for arrays of *_device_data Uwe Kleine-König (The Capable Hub)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ak41yQp3x78s4Fmx@ashevche-desk.local \
--to=andriy.shevchenko@linux.intel.com \
--cc=Frank.Li@nxp.com \
--cc=aaro.koskinen@iki.fi \
--cc=alexandre.belloni@bootlin.com \
--cc=alexandre.torgue@foss.st.com \
--cc=alim.akhtar@samsung.com \
--cc=andre.draszik@linaro.org \
--cc=andreas.werner@men.de \
--cc=andreas@kemnade.info \
--cc=andy@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=asahi@lists.linux.dev \
--cc=baolin.wang@linux.alibaba.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=ben.bright@cirrus.com \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=ckeepax@opensource.cirrus.com \
--cc=claudiu.beznea@tuxon.dev \
--cc=colin.foster@in-advantage.com \
--cc=cw00.choi@samsung.com \
--cc=david.rhodes@cirrus.com \
--cc=fabrice.gasnier@foss.st.com \
--cc=festevam@gmail.com \
--cc=florian.fainelli@broadcom.com \
--cc=fred.treven@cirrus.com \
--cc=geert+renesas@glider.be \
--cc=groeck@chromium.org \
--cc=imx@lists.linux.dev \
--cc=j.neuschaefer@gmx.net \
--cc=j@jannau.net \
--cc=jernej.skrabec@gmail.com \
--cc=jogletre@opensource.cirrus.com \
--cc=kernel@pengutronix.de \
--cc=khilman@baylibre.com \
--cc=krzk@kernel.org \
--cc=lee@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux-sunxi@lists.linux.dev \
--cc=linux@ew.tq-group.com \
--cc=liviu.dudau@arm.com \
--cc=lpieralisi@kernel.org \
--cc=luca.ceresoli@bootlin.com \
--cc=magnus.damm@gmail.com \
--cc=marek.vasut+renesas@gmail.com \
--cc=mathieu.dubois-briand@bootlin.com \
--cc=matthias.bgg@gmail.com \
--cc=mazziesaccount@gmail.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=mfd@lists.linux.dev \
--cc=michael.hennerich@analog.com \
--cc=mika.westerberg@linux.intel.com \
--cc=neal@gompa.dev \
--cc=neil.armstrong@linaro.org \
--cc=nicolas.ferre@microchip.com \
--cc=orsonzhai@gmail.com \
--cc=patches@opensource.cirrus.com \
--cc=peter.griffin@linaro.org \
--cc=ptyser@xes-inc.com \
--cc=qipeng.zha@intel.com \
--cc=rf@opensource.cirrus.com \
--cc=rjui@broadcom.com \
--cc=rogerq@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=samkay014@gmail.com \
--cc=samuel@sholland.org \
--cc=sbranden@broadcom.com \
--cc=sravanhome@gmail.com \
--cc=sudeep.holla@kernel.org \
--cc=support.opensource@diasemi.com \
--cc=sven@kernel.org \
--cc=tharvey@gateworks.com \
--cc=thomas.richard@bootlin.com \
--cc=tony@atomide.com \
--cc=trix@redhat.com \
--cc=u.kleine-koenig@baylibre.com \
--cc=wens@kernel.org \
--cc=yilun.xu@intel.com \
--cc=zhang.lyra@gmail.com \
--cc=zhaoqunqin@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox