From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0CE5AC43458 for ; Thu, 9 Jul 2026 10:36:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ARFMEq0oVkui4XPPgbn854eRDYcjamGL+khcOdCj0t0=; b=AAbvG4EPPGYaIQ/hcEspOqW/8L x1+XPnjB6x0R/7bUAd6DPlUvsA7PQH7H1Z3NfsJ5qFLPyTrEyZRh6jOg6nnRHdariTjdja7TEHyLe q95ixh65SLHWnX+JI6WBXEU+LX8enqsdBmGj9JzAJoLT9GZKHCxg2GT4k9lMEDpwkW/xy6H/bei3b mMEhg8+8NB/kDQIqhgQXA4RghdRqi6S2WmU9b+uuOyAdl0Py/tqtVfVziQ9VOY91CfRPcVfsBr7Uc vUb1pIuP8/P0Lfgz4ZFZJ2FDNfV+qoYYT6GF983c1tUaaBQR0jGbNJpFTG0AJUNCowKhqzAuy5fow klpqpC0g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1whm7e-00000001z55-0mlv; Thu, 09 Jul 2026 10:36:50 +0000 Received: from mgamail.intel.com ([198.175.65.21]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1whm7b-00000001z4P-1vNt; Thu, 09 Jul 2026 10:36:48 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1783593408; x=1815129408; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=sM/To+DTEc32STAWmbWoa4mxR1gafUH0Ew8jud2Bb6E=; b=bua0mjXM47Lg5VIlNcyvznBOjLcjqQcEEQ4wacmSt+F0RV8lNCP7U73P Mn3xb7t9p2KKRC63biExgj0U23hsmHTB8Bh6otZmanmW+DCLlzIH2kOf0 S0yAHmsd3505TQlTbCDMcbor09GTI6uEa11Bnqyng4KcAqawAQwLd+8RA Az00Lxpp0gbwNs7T1g92yj+eSXbr/Vm2lKHiRAgkUS1YZApOO29CChf4n oby/y0EPycoz6+CF/LBoZDien/jWAeH2ymtmhM67YCYvJG7kz4L6zqrud UcekR56BNrpKnvCCeLOj8nKyIdtgMWJLYWAXiBbXPerrXWkBaQJjd601t g==; X-CSE-ConnectionGUID: HQzzbuM6Ttm90+zcZzHaRw== X-CSE-MsgGUID: vH6uxkH3R8qnPCIKjj+VVQ== X-IronPort-AV: E=McAfee;i="6800,10657,11841"; a="84128310" X-IronPort-AV: E=Sophos;i="6.25,154,1779174000"; d="scan'208";a="84128310" Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jul 2026 03:36:45 -0700 X-CSE-ConnectionGUID: 5i2pH1kLQnmvne4XMmnt5g== X-CSE-MsgGUID: aCmP89aeSLqKerWrRicZLQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.25,154,1779174000"; d="scan'208";a="250148201" Received: from ettammin-mobl3.ger.corp.intel.com (HELO localhost) ([10.245.245.235]) by fmviesa006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jul 2026 03:36:40 -0700 Date: Thu, 9 Jul 2026 13:36:37 +0300 From: Andy Shevchenko To: Chen-Yu Tsai Cc: Bartosz Golaszewski , Greg Kroah-Hartman , Daniel Scally , Heikki Krogerus , Sakari Ailus , "Rafael J. Wysocki" , Danilo Krummrich , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , linux-acpi@vger.kernel.org, driver-core@lists.linux.dev, linux-pm@vger.kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Manivannan Sadhasivam , Alan Stern Subject: Re: [PATCH v4 06/14] usb: core: Move struct usb_port and related APIs to port.h Message-ID: References: <20260709095726.704448-1-wenst@chromium.org> <20260709095726.704448-7-wenst@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260709095726.704448-7-wenst@chromium.org> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260709_033647_534773_0023DADE X-CRM114-Status: GOOD ( 11.79 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Thu, Jul 09, 2026 at 05:57:11PM +0800, Chen-Yu Tsai wrote: > |struct usb_port| and its matching container_of() macro should live in > its own port.h, matching the split we have for .c files. > > Move them as described. Also move usb_port_is_power_on(), since in the > next change its |struct usb_hub *| parameter will be changed to > |struct usb_port *|, and becomes a non-static function that only > references |struct usb_port|. > > port.h is only included from hub.h, as a subsequent patch will directly > use fields from |struct usb_port| in a static inline helper in hub.h. > The USB internal headers don't have header guards to help with this. Reviewed-by: Andy Shevchenko ... > +extern int usb_port_is_power_on(struct usb_hub *hub, unsigned int portstatus); Drop 'extern', it's not needed in a modern code (like 20 years?). -- With Best Regards, Andy Shevchenko