From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A250CC43458 for ; Thu, 9 Jul 2026 16:08:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Gov176wXURlzSR3dUDxqqJ+JUc69jBkAANSG0MToDuM=; b=zF1Qip1qwHbP0uNI1HiymIpgEH OI15WRzz7TVm25FtLefXQjPM3r3qeBtNaIMAMpr7yBMnEP0JDvygEQ3Ds+NYnfw1ACePEb3zNkyIR 1X5fvPOeztPm0yWql+QTQTkvrUWpcsoMxlI/uuo3Eur8XLlu21jgLbX6hhRpeCrwpHDqF5uGBa0fy moWiDfQYMUXDihmEL5m1DR2flcdbE9TOnBi1IG0FX8uYGzE4mvc/D/98y/u5OO8s2ONLdcSww9fut ze3Fd5RDcsp+hkhwpLGDzG6CuaIjskV0LFN9YQ8pHQncUX/R27dmooJhTyiHSc+Bf8rOWh1o1a8+U tEbj3SPQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1whrIz-0000000306M-1AbD; Thu, 09 Jul 2026 16:08:53 +0000 Received: from mail-wr1-x433.google.com ([2a00:1450:4864:20::433]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1whrIu-0000000304K-0hf1 for linux-mediatek@lists.infradead.org; Thu, 09 Jul 2026 16:08:51 +0000 Received: by mail-wr1-x433.google.com with SMTP id ffacd0b85a97d-4758bd3731bso23519f8f.0 for ; Thu, 09 Jul 2026 09:08:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1783613326; x=1784218126; darn=lists.infradead.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=Gov176wXURlzSR3dUDxqqJ+JUc69jBkAANSG0MToDuM=; b=LtDXbeb4Pi7xAPhMjBCE8oULSk4TMOkKdF2XyRf945xrXh3EWchz4AkggSdH3BCQ84 b5Nb25msKn6UDK8xxaAcFIh/+cIgjqpgBbncULlCPlOYozOkpts032Qm1L09FLIkICeJ A7IPQ0ppAlOvrVpSDzm1HYDlROQzIGQYPi3umisO2EkT8a0NWWS4eYXmiAarLmQEM49K /3cic83F6Ajs/shSeV+mmTnwUgCqx0BI8E+zdal2BQtTPhTsvsh4DFMZ/O6pZNU5Des4 zfqFzJr5Cx9G7STqIKArUfDkkk13pvabYdAjwrEv+q77BPaPFA+CIW6+XmeWNMPphx8N tptA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783613326; x=1784218126; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Gov176wXURlzSR3dUDxqqJ+JUc69jBkAANSG0MToDuM=; b=l0HSuT3wECIl96qk86jcSJ9y3a6Mf3VfwYx3KGaIQCm72jyAGoUBoZkYcc+h7Ou2Q1 YkRqFn4d/46wMZ0gghPfJaUY0C5hCLlyTBzYnPHUJlz1X8kNRqCrX1Ewn/QxAuEymcIg Qzil1OV8pdwD0OUSkZHIwbAbuaQG2dVr9w++Ce24GR0IL1bGfJEM302hUiCgq9MeCUlE 168IFtYRwAMSxyFXw32tPuzzWQJ54WITv3bXwhQhzpv8nUGwwUsbNsDBqUukCmOqNPI0 K1XM/WHMcle1V32k6piYmuvuS8+xq+mf7Z4DgXzVvS+yqz9++l8zhdHH9X7e/CRZ+DRI AKbw== X-Forwarded-Encrypted: i=1; AHgh+RpgKcUcz13fwFs+SNRn3a2QWFjqg9liCdNgabtC3gGqS/nXN+TqNN0YavXHECp503lRoYz/dpb89YnChAx7Ww==@lists.infradead.org X-Gm-Message-State: AOJu0Yy20pv4fOuzqfqHR0DNVjz50ZmaB9qHjd6lR1eulI69p4gC+Umw YGdf2EW4NViILGNWjSBljdUlir5N28mlcXwzKP9oqNnMb3YJi6PpdywEYeANUn4KHAI= X-Gm-Gg: AfdE7cnKOZJhrSPHvNR00n8GZAXEj/7jMp0pF+5MQWcB036j/4tfcDpu4Z8UeBaH49T 201Itczs/WmDlUui501DrD1aLJOWifw6b1W7VqSYpcskK8wflBWoWv+KpIjW9c/F/Hnenhph5I/ K9E5SAKU2VbgRLlAOnRO8hG2xCFSidjzJpBcKFrFvsotxWa72QxVcbPlks94hAnzGmpI8abwEGs GADw0KQcQxnytpTQXXNiK9F8y5CKq4sgI/Ui6A6D3w9Ews4UjQo+uKsaX6NWhpr1KukaeBIBqsA xVcSrmbsQnLIQOsa/RiyeFb2ETsi3PzTInNgmJV2Exb02W2X4nRxU+IHeTKYTftUNpt4oiVZCvD bBOOp7H9elPjqRJhGkUVzjlqsY+S+gjJxw/5gDJZG1mUdi/u8nBc8tUD2WtzAF5a9yMkSZpb+mq CbLZ1fbq6pD75qsr1tjddQij5wXWQ8SHsh0oj+ykD7mXfeBhMKnwgBfmF1a0R+Zt6wj6XzC4ikt 531 X-Received: by 2002:a05:6000:230b:b0:46d:f979:1827 with SMTP id ffacd0b85a97d-47df757026bmr3824909f8f.23.1783613325532; Thu, 09 Jul 2026 09:08:45 -0700 (PDT) Received: from localhost (p200300f65f47db043de98c19b374aa68.dip0.t-ipconnect.de. [2003:f6:5f47:db04:3de9:8c19:b374:aa68]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-47aa0960816sm50486350f8f.29.2026.07.09.09.08.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Jul 2026 09:08:43 -0700 (PDT) Date: Thu, 9 Jul 2026 18:08:42 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig_=28The_Capable_Hub=29?= To: Andy Shevchenko Cc: Lee Jones , Florian Fainelli , Broadcom internal kernel review list , Ray Jui , Scott Branden , mfd@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Matthias Brugger , AngeloGioacchino Del Regno , linux-mediatek@lists.infradead.org, Qunqin Zhao , linux-crypto@vger.kernel.org, Benson Leung , Guenter Roeck , chrome-platform@lists.linux.dev, Colin Foster , David Rhodes , Richard Fitzgerald , Mika Westerberg , Zha Qipeng , Thomas Richard , linux-sound@vger.kernel.org, patches@opensource.cirrus.com, Xu Yilun , Tom Rix , Michael Hennerich , Chen-Yu Tsai , Marek Vasut , James Ogletree , Fred Treven , Ben Bright , Support Opensource , Andy Shevchenko , Charles Keepax , Chanwoo Choi , Krzysztof Kozlowski , =?utf-8?B?QW5kcsOp?= Draszik , Aaro Koskinen , Andreas Kemnade , Kevin Hilman , Roger Quadros , Tony Lindgren , Samuel Kayode , Maxime Coquelin , Alexandre Torgue , linux-renesas-soc@vger.kernel.org, linux-omap@vger.kernel.org, imx@lists.linux.dev, linux-stm32@st-md-mailman.stormreply.com, Linus Walleij , linux@ew.tq-group.com, Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Peter Griffin , Alim Akhtar , Tim Harvey , Neil Armstrong , Sven Peter , Janne Grunau , Neal Gompa , Mathieu Dubois-Briand , Luca Ceresoli , Saravanan Sekar , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Jonathan =?utf-8?Q?Neusch=C3=A4fer?= , Matti Vaittinen , Orson Zhai , Baolin Wang , Chunyan Zhang , Fabrice Gasnier , Jernej Skrabec , Samuel Holland , Liviu Dudau , Sudeep Holla , Lorenzo Pieralisi , Geert Uytterhoeven , Magnus Damm , linux-samsung-soc@vger.kernel.org, linux-amlogic@lists.infradead.org, asahi@lists.linux.dev, linux-arm-msm@vger.kernel.org, linux-sunxi@lists.linux.dev, Peter Tyser Subject: Re: [PATCH v2 00/23] mfd: Use named initializers for arrays of *_device_data Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ka4fpqo6ejmxfupn" Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260709_090848_236052_68966DE7 X-CRM114-Status: GOOD ( 27.58 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org --ka4fpqo6ejmxfupn Content-Type: text/plain; protected-headers=v1; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH v2 00/23] mfd: Use named initializers for arrays of *_device_data MIME-Version: 1.0 Hello, On Wed, Jul 08, 2026 at 02:34:33PM +0300, Andy Shevchenko wrote: > On Wed, Jul 08, 2026 at 01:15:07PM +0200, Uwe Kleine-K=F6nig (The Capable= Hub) wrote: > > Hello, > >=20 > > this series superseeds my previous patch "[PATCH v1] mfd: Use named > > initializers for arrays of i2c_device_data" > > (https://lore.kernel.org/lkml/20260515095839.4005460-2-u.kleine-koenig@= baylibre.com) > > that Lee asked me to rebase and also the series "[PATCH v1 0/3] mfd: > > Initialize spi_device_id arrays using member names" > > (https://lore.kernel.org/lkml/cover.1783003256.git.u.kleine-koenig@bayl= ibre.com). > >=20 > > The objective for this series is to prepare mfd for changing > > of_device_id etc to make driver_data a union, see > > https://lore.kernel.org/all/cover.1780048925.git.u.kleine-koenig@baylib= re.com/ > > for the idea behind it. > >=20 > > This series is based on yesterday's next/master and it does the > > restructuring not only for i2c and spi (as the two series mentioned > > above), but for all *_device_id structures that I intend to modify with > > a union that affect mfd. So (I hope) this is the only patch series > > affecting mfd for this quest. > >=20 > > I don't care much about the last few patches unifying the coding style. > > I think it's a good opportunity to do that, but if you don't like them, > > just don't apply these. >=20 > The patches bring inconsistency (or still leave it) with the terminator s= tyle > in both I=B2C and ACPI ID tables. Can you revisit that? I found a few inconstencies for of_device_id, but not for acpi and i2c. I have a script for the acpi and i2c (and now also for the of) changes and don't spot inconsistencys in the terminator style for acpi and i2c devices apart from comments. (I looked at the output of: git grep -lE '(i2c|acpi)_device_id [a-z0-9_]*\[\]' drivers/mfd | xargs -r = sed -rn '/(i2c|acpi)_device_id [a-zA-Z0-9_]*\[/,/^};/p' | grep -B1 ^\} | so= rt | uniq -c ) Do you mean to unify the comments, too? Best regards Uwe --ka4fpqo6ejmxfupn Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmpPx4cACgkQj4D7WH0S /k624gf/dzy2q/+UDcko+3qRC/vjduntKV5JaImo1jv66pbGa0vVyVdYDHS/QwvV X+Jr6jTMyEZcw6O1onRP1ZIcKU6MTkl/wvtqeLkFJ4PXv/hKftTSkP/IHkLuekNm Cn37LNIalY7gpr1gfPvcL5Q/BN1qqXCUggmW0xXf+Gi9W5bwWuTaRsJ9ehVptA3+ rMp5HAYJ1isaiiqfMZJ/TqtNWHN6aVh8ZS6YU5b2iDitwtnRCQD1pOcYCYaXgfrt fbXqb+xpQvMfRgK+MLErhmJUfHf2tKi1s5OKoG1T9fiLCmp0VzTkB4+o4AgpQgeE pUTRSN5jhrCLDAt7v6B6b4XHPcYmTQ== =tSBk -----END PGP SIGNATURE----- --ka4fpqo6ejmxfupn--