From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4D401C43458 for ; Fri, 3 Jul 2026 13:11:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=tcD68ggny1joEpMqpashahzuMhH7VhG1V/QEZFS6CWY=; b=wSAt7mMtap/685u+DYLhbQdqj9 fMdyhol8m/DQV8guzcbOr1cLlf3/KtwFeWzXhG46X/eCJiaiK71lT2OFKSB5uQX0w19XKsSo/LMjs 6alHw3fkmioPdpBSGnTDvmfJjvPA9G2TYRBDOyq6o28ZPW1D4cWjP2uwZvX0XLq0tv/3xXN6uv9j1 il39CU8JTfzKD3n4hdDqdCbNKZ91WpWfL/xvMXk/C5ZNl7wYPuh56b5TmtaKy7DuLXMsLUzgXEcmy EKhhhPFXZ3wvhjWFKqX6cIB6uF8+7V0T8GL3bqh3X6CB616cWWCWM+Xu/JLJqaeVTzXgk8IyCduUh F7phh2ZQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wfdg1-000000073Gz-0B46; Fri, 03 Jul 2026 13:11:29 +0000 Received: from mgamail.intel.com ([198.175.65.16]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wfdfy-000000073GW-215j; Fri, 03 Jul 2026 13:11:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1783084286; x=1814620286; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=ur0KVXHfio32hANukgiS55qHcr/vid5LoYAKVA8ObVY=; b=ETgClG3D1EQeMLFzmtw6vJIEQFE8TIwPEiURekGiPldrPWxoHi/qeK3l 6e54VZYpGh2qCfzDpwHIN8vjmIViKDcuPyIuU0pEU/XUy67Sdkh2zo/ep xJa0DHXBoe5C9peQBBwh/Bup0XG4/rAbFtp5UNUWHwNNlRoN2WiF+/GOa oxhT0hrIGrBrtsTast0MvQigy7Y00RwG2viGVJTV+ZI6kUgUqf9bSPjJ8 5lg5/fureaiBcjXAvq9F88lWjwHBPhtrq9BH9aFLQEHjFoF2S6Al7MG9d UXyZN35RQMCzIRfo3XyilCFLJ/nQuAWUwcNlggV3S9L17O7aT8YAzcKnE A==; X-CSE-ConnectionGUID: 4y3nLF6XQPKbaS7mxPxz0Q== X-CSE-MsgGUID: npPua//xRZ2C8NzaFcO5Yg== X-IronPort-AV: E=McAfee;i="6800,10657,11835"; a="84028529" X-IronPort-AV: E=Sophos;i="6.25,145,1779174000"; d="scan'208";a="84028529" Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by orvoesa108.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Jul 2026 06:11:25 -0700 X-CSE-ConnectionGUID: OtKHXtZxRy+HZdZh/F4u3A== X-CSE-MsgGUID: 7twUTalZTUmLgv086/XQfQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.25,145,1779174000"; d="scan'208";a="248664397" Received: from carterle-desk.ger.corp.intel.com (HELO localhost) ([10.245.245.80]) by fmviesa006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Jul 2026 06:11:20 -0700 Date: Fri, 3 Jul 2026 16:11:18 +0300 From: Andy Shevchenko To: Chen-Yu Tsai Cc: Bartosz Golaszewski , Greg Kroah-Hartman , Daniel Scally , Heikki Krogerus , Sakari Ailus , "Rafael J. Wysocki" , Danilo Krummrich , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , linux-acpi@vger.kernel.org, driver-core@lists.linux.dev, linux-pm@vger.kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Manivannan Sadhasivam , Alan Stern , Bartosz Golaszewski Subject: Re: [PATCH v3 06/13] usb: hub: Pass |struct usb_port*| to usb_port_is_power_on() Message-ID: References: <20260703110317.1283411-1-wenst@chromium.org> <20260703110317.1283411-7-wenst@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260703110317.1283411-7-wenst@chromium.org> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260703_061126_960490_1D123BC1 X-CRM114-Status: GOOD ( 12.98 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Fri, Jul 03, 2026 at 07:03:07PM +0800, Chen-Yu Tsai wrote: > usb_port_is_power_on() currently takes |struct usb_hub*|, but only needs > it to tell if the hub/port is SuperSpeed or not. > > In a subsequent change, usb_port_is_power_on() needs access to a pwrseq > state tracking field in |struct usb_port|. Either structure can be used > to identify whether a port/hub is SuperSpeed or not, as the field in > |struct usb_port| is inherited from the hub: > > port->is_superspeed = hub_is_superspeed(hub) > > Replace usb_port_is_power_on()'s |struct usb_hub*| parameter with > |struct usb_port*| so a subsequent change can use it. At a brief look this will be the only function that takes usb_port instead of usb_hub in the entire hub.h (I don't count container_of() as a function). With that being said I would rather see it to be moved to port.c altogether (yes, it's more invasive change, but looks more consistent). I would even dare to move struct usb_port (and container_of() accompanied with that) and this function to port.h. This might require a separate patch, though. Perhaps something like: 1) "move struct usb_port and associated APIs to port.h"; 2) "...this patch...". -- With Best Regards, Andy Shevchenko