From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CDE68C43458 for ; Mon, 6 Jul 2026 06:37:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=VjcZmBFuXjLsV7sfYoSAPXXZPZioIsyWeSwOGddaHg0=; b=vBXS2kZmjEuMa3aCV0GyPSDNPM t3pR8/uR0Qb0R2/N6ffqJTjxyvnHuJ17G3mzPmOfy4gcJtJ5+wp0xhDU5UL//qqaP2PcWGFbtfcMu H+/pp0OMTIcQdmc2FyYR3EYhqPQCutOr0UTiZR25H4dqMh7t77ye8EWXKJBSY7LnkPsVhrsmImZP1 C/D7vWPwSk67ND2zfEAhhIuoiAUVx2s3mioAuN3JJ5AX196JwSToaATTHuXoU5lNH6nlh40FG13so SI0w3Z4siUQg2EmC9UKmvSsfXGmSLQKWWFsufMvIo4NV8uvejq1/4fvr6M+huUZC9G10+zk1RsWlZ heLOjbOQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wgcxS-0000000BdU8-2kYb; Mon, 06 Jul 2026 06:37:34 +0000 Received: from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wgcxR-0000000BdTY-2LQ4; Mon, 06 Jul 2026 06:37:33 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 8AAFC60018; Mon, 6 Jul 2026 06:37:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3EFA11F00A3A; Mon, 6 Jul 2026 06:37:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783319852; bh=VjcZmBFuXjLsV7sfYoSAPXXZPZioIsyWeSwOGddaHg0=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=YDyKS0SaRDvwlaShaJjV9biNKvr0BeBb2h3WIkgVUVMOtl/pqz7jwholBzal2OxMX FJFO0GE0tFw3/VQuPzqDai2SnLB219yrF4noFlP6D6luh0uwUu+TmSh8sTgYmFJly0 S/KmJOPJe1oDQDBJPrEP6lKy6DMjAWS/XKAxktdISW3zP2sTCIsGevRz1DSwlXWCnp A62U9+WLtsCIQ/1RoRqwTojDt0iwpFIFT3kDapWfqoPF9ZWz8nDDWaxeFJcrPgfTIf e4sFc8+idj5v1sMgInW8l0tEcSH1fa7qE1vJ/UYlmvIOHzefPNJF4kfD1jKeLXQ+fH vWF6kuxUltseQ== Received: from johan by xi.lan with local (Exim 4.99.4) (envelope-from ) id 1wgcxN-00000001Y5w-1Pmp; Mon, 06 Jul 2026 08:37:29 +0200 Date: Mon, 6 Jul 2026 08:37:29 +0200 From: Johan Hovold To: Guangshuo Li Cc: Chun-Kuang Hu , Philipp Zabel , David Airlie , Simona Vetter , Matthias Brugger , AngeloGioacchino Del Regno , CK Hu , Louis-Alexis Eyraud , dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, stable@vger.kernel.org Subject: Re: [PATCH v2] drm/mediatek: mtk_hdmi: Fix DDC adapter double put in v2 Message-ID: References: <20260706015507.453222-1-lgs201920130244@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260706015507.453222-1-lgs201920130244@gmail.com> X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Mon, Jul 06, 2026 at 09:55:07AM +0800, Guangshuo Li wrote: > mtk_hdmi_common_probe() gets the DDC adapter with > of_find_i2c_adapter_by_node() and registers a devm action to release the > adapter device reference with put_device(). > > The HDMI v2 remove callback also calls i2c_put_adapter() on the same DDC > adapter. This is not paired with of_find_i2c_adapter_by_node(): it drops > the adapter device reference before the devm action drops it again, and > it also puts a module reference that was never taken. > > Remove the extra i2c_put_adapter() call and drop the now-empty HDMI v2 > remove callback. The common devm action releases the adapter device > reference. > > Fixes: 8d0f79886273 ("drm/mediatek: Introduce HDMI/DDC v2 for MT8195/MT8188") > Cc: stable@vger.kernel.org > Signed-off-by: Guangshuo Li > --- > v2: > - Drop the empty remove callback, as suggested by Johan Hovold. > - Mention that i2c_put_adapter() also drops a module reference that was > never taken. > - Fix the Fixes tag. > - Add Cc stable. Please remember to CC reviewers: Reviewed-by: Johan Hovold