From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D7B67C44500 for ; Mon, 6 Jul 2026 10:39:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Go7lNGQE+yUmjPgVI2sZRhO3/S4lEXiftKalvVFj+z0=; b=4VdTBvvxCfBGf+lQnSOBdf0wcw CR7IfoYjGAS8FLZMxKwcdnC/AJ5z/kMB/qkqSS3l0us6dq9X1I1FS0vH+DVhDK0EALAv4SyOI6AnT f3qw3elz1x/Bcwmkd5F5K8iW9fadeigeAyy74HvWQ0roSNkS6ClrGubNde693qvi0lAEAiFF4hiVx eO7fVJBggtifMDG4tQD9JZhUM9NvW7KzmPLsTJYlLO+PO3sNBFT+AQ7h6oXDUsdGUZgR2AmAGmnvo LbjmQE9m0Z6MknW0u+0g7T6gDIK911G4qbJy1x+xrZ0+lC36G3Ce3RAhLepSvEmiv/iYnKgIgQITO wUCJCg9w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wggjn-0000000CFEP-2qpW; Mon, 06 Jul 2026 10:39:43 +0000 Received: from mail-wr1-x433.google.com ([2a00:1450:4864:20::433]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wggji-0000000CFCC-2JEz for linux-mediatek@lists.infradead.org; Mon, 06 Jul 2026 10:39:41 +0000 Received: by mail-wr1-x433.google.com with SMTP id ffacd0b85a97d-47c6e9a694bso749941f8f.1 for ; Mon, 06 Jul 2026 03:39:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1783334376; x=1783939176; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Go7lNGQE+yUmjPgVI2sZRhO3/S4lEXiftKalvVFj+z0=; b=RAGY7VJrRuV6fomU8zjBRG6mSXW+ITJOA42RcGien+zcjd72UOaCfhD+c1nPOef46M ptSzfpkz/wlgqRQ1VvxsJXHDQnU+QIEqBuNI5MFsFhJ7LoiHXGogsBxDSIBDNjeeEoMu Ho+YXKf1lm+mH/08yKs4ClhXSPmuunx1DwxBG8WQwszuoEUeRRtxEuXjXK4d2ixvwYdY sjx7iS2my/sofW6IPS9e+yf9HKP5v0Ly/yk71fLyr3yVuHYyYOaYgE1SQ6+pvrbQpq3j y9eMDcQ393Bq3KFUpKqikoyve4zdR4EEFfHjslQpggFK0g8grvS7GA3ba8D/xFb7Hgux CX1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783334376; x=1783939176; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Go7lNGQE+yUmjPgVI2sZRhO3/S4lEXiftKalvVFj+z0=; b=CYZGLRBEHViV4qLQ3ZM8d2ZJxFBWB2L1Bd51zJFqo3D+8D+9P5k01p488ULpw8IdJ6 zR0zDM0m6HlvvzALvp4g8jbx3+y5szasm2Aq20jO5s3kI+yUg74bK6CqyX+ouSQYe5Yg qN8rBN+yfE/3gInft5IlCAs+twFdg7Y1R0oIC+XR+RXx2Glmn+OkHcL0StR3czUqstgK WjJ6vl4dxyL0yCG7p0FmLWLYeVWgs3LTYn7ZuPLE05OXzhTCVK76qk6b2s5EFxA2nZqs k333C4feWGwjXF1cvOXlE/Gh6nFVBhHQue3jaf+CrEIKHzUxk0/aDzW046FVQWtDuD6W f6+Q== X-Forwarded-Encrypted: i=1; AHgh+RpZMMdBpq2hZOAiH7pC4F+bdGDsAxOSNtb5SliVXJNpj9t5x8qWpZseb/5Bb+Zes0wn7wrHDgZmCtZ+Juqk3g==@lists.infradead.org X-Gm-Message-State: AOJu0YwFrsHHm2ZlEd92S5v7CDMXaWI/tuBUQMGkBoJ/0zxDYfIX+Kak b363TYGgp/gRNRLwBXBQfx6IcDDB06vCUApyjatDqmGXwfU7qLT+ocYycy/lavH125c= X-Gm-Gg: AfdE7cnBhDNvKKkDHsCYkVucEjxZpljMKDJUI+TqtqgUBLcHGNSE2fFC8G22Yh5oNlo J8MWUEMc7CZonVI4UipADW620+CX6S+aKZpUwXG/YLtskA1nBHnlidD0lHIxl0VUhHW9Mo+UD4L fwy5MtGktO00jEhT6il1J169JTZlVENINb0ShRlTyw31Mbw9RaFOaUBMADiCKnRCWa1EK6KdzBM gjHMiuBG/puFZIx4IWSfWfAY0NrfvDj0UpjmXvhjn6BF78vBAGCO9MKNSUgau1x+YLUU04VcpH/ 78/eQ9762tYdDcvYxLVUzg4W3xr9M6QpFRTHlquC4Ck7qptnfbgnQAf5oytz21zwEtEMtRwysIg XoKZjFFBkUBvlPOZYlRpj85HulAF7cDpR0GNzGJkf5YRmKOIPrhPIqADM208QRbKIo4l7vzmo3t TCGz81vtaCYmm2F8nbY0GijCPpQgd8rMNxSYJXPqfSo1dk3hK4KCrkYgoPjOZD3aw9UPUZxhgxE 7JH X-Received: by 2002:a05:6000:4698:b0:475:36a:8c97 with SMTP id ffacd0b85a97d-47aab76f017mr8079359f8f.45.1783334376207; Mon, 06 Jul 2026 03:39:36 -0700 (PDT) Received: from localhost (p200300f65f47db0426af56a07ec3b32d.dip0.t-ipconnect.de. [2003:f6:5f47:db04:26af:56a0:7ec3:b32d]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-47a9de1d8cdsm25702223f8f.1.2026.07.06.03.39.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2026 03:39:35 -0700 (PDT) Date: Mon, 6 Jul 2026 12:39:34 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig_=28The_Capable_Hub=29?= To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Cc: Chen Wang , linux-pwm@vger.kernel.org, Sven Peter , Janne Grunau , Neal Gompa , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Ray Jui , Scott Branden , Broadcom internal kernel review list , Florian Fainelli , Benson Leung , Guenter Roeck , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Paul Cercueil , Vladimir Zapolskiy , Piotr Wojtaszczyk , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Matthias Brugger , AngeloGioacchino Del Regno , Geert Uytterhoeven , Magnus Damm , Heiko Stuebner , Krzysztof Kozlowski , Peter Griffin , Alim Akhtar , Paul Walmsley , Samuel Holland , Michael Walle , Inochi Amaoto , Orson Zhai , Baolin Wang , Chunyan Zhang , Fabrice Gasnier , Maxime Coquelin , Alexandre Torgue , Chen-Yu Tsai , Jernej Skrabec , Hammer Hsieh , Nobuhiro Iwamatsu , Alexey Charkov , Sean Anderson , Michal Simek , asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, chrome-platform@lists.linux.dev, imx@lists.linux.dev, linux-mips@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-riscv@lists.infradead.org, sophgo@lists.linux.dev, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev Subject: Re: [PATCH v1 4/5] pwm: Unify coding style of of_device_id arrays Message-ID: References: <20de6cd60c2938aad2d21397b92742849418ab1b.1783263835.git.ukleinek@kernel.org> <973f3d6f-6ff4-4685-9c9f-b07987f74d98@linux.dev> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="vyrf5kfcddz5uoeo" Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260706_033938_625174_DE84109D X-CRM114-Status: GOOD ( 17.64 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org --vyrf5kfcddz5uoeo Content-Type: text/plain; protected-headers=v1; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH v1 4/5] pwm: Unify coding style of of_device_id arrays MIME-Version: 1.0 Hello, On Mon, Jul 06, 2026 at 10:28:16AM +0200, Philippe Mathieu-Daud=E9 wrote: > Hi Uwe, >=20 > On 6/7/26 09:19, Uwe Kleine-K=C3=B6nig (The Capable Hub) wrote: > > Hello Chen, > >=20 > > On Mon, Jul 06, 2026 at 08:33:47AM +0800, Chen Wang wrote: > > > On 7/5/2026 11:14 PM, Uwe Kleine-K=F6nig (The Capable Hub) wrote: > > > > - Use a single space in a of_device_id array terminator; A singl= e space > > > > after the opening { and before the closing } in non-empty > > > > initializers; > > > > - No comma after an array terminator; > > > > - Also no trailing comma after a named initializer iff the > > > iff -> if > >=20 > > This is actually intended. iff =3D "if and only if", see e.g. > > https://en.wikipedia.org/wiki/If_and_only_if . >=20 > I agree this scientific idiomatic expression is not well known > by non-native English speakers, and using the expanded form is > just simpler to review (thinking at non-native English speaker > reading your commit in the future). fine for me, I'll fixup to=20 - Also no trailing comma after a named initializer if (and only if) the closing } is on the same line; when applying. Best regards Uwe --vyrf5kfcddz5uoeo Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmpLheQACgkQj4D7WH0S /k6DEQf+JKDZ+NcR412RMDPBxcWuk831SswOfJipQJVDxTsFWtpZIrZIbOu0ZlBp IEWpfB5nRfHwTSxF6Ceuf2jTc+wkwcRBKeH4MQsZFpGxBjGa4k7YEEfMSDU9S1vU 39G1FIVXnf0sDkUOUGf5zIomYewh4gdCoWRwDnCHsV4QnZKAaKCCEpX0U6QdW2OP diy3iqasYf6KZyXnUyj0HBQRGjBYY4jBvVutXt4KtCqAKW+AcCANOtubadJgydWD xXNkFLpscFQ9aVdyKZK19UP9yKdOwzkjR9pul+TqXDviO0c5UoAZEwMZYDbB1YPi AJloqZ9/3vBcnEjZo3eWYk8zkrQifQ== =vnC0 -----END PGP SIGNATURE----- --vyrf5kfcddz5uoeo--