Re: [PATCH v3 21/23] mfd: Unify style of of_device_id arrays

[Charles Keepax <ckeepax@opensource.cirrus.com>]

On Fri, Jul 10, 2026 at 03:15:17PM +0200, Krzysztof Kozlowski wrote:
> On 10/07/2026 15:00, Mathieu Dubois-Briand wrote:
> > On Thu Jul 9, 2026 at 6:58 PM CEST, Uwe Kleine-König (The Capable Hub) wrote:
> >> These arrays already mostly match the most used and generally
> >> recommended coding style. That is:
> >>
> >>  - no comma after the list terminator;
> >>  - a comma after an initializer if (and only if) the closing } is not
> >>    directly following;
> >>  - no explicit zeros in the list terminator;
> >>  - a space after an opening { and before a closing }, a single space in
> >>    the list terminator;
> >>
> >> Adapt the offenders accordingly.
> >>
> >> Reviewed-by: André Draszik <andre.draszik@linaro.org> # for Maxim MAX77759
> >> Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>
> 
> Thesr are all Acks, not reviews. Entire commit will now carry multiple
> review tags, implying it was reviewed by 3 or more people but none of
> these people actually reviewed the commit. None!
> 
> They looked at one line out of 100.

Technically 16 lines out of 375 ;-)

> This is ridiculous.
> 
> Quoting:
> "Reviewed-by:, instead, indicates that the patch has been reviewed and
> found acceptable according to the Reviewer's Statement:"
> 
> Not piece of a patch. THE PATCH.

More than happy for it to be switched to an ack if that is the
preferred process when reviewing parts of larger patches. I have
always just indicated the parts of the patch reviewed whilst
responding, apologies for my ignorance of the process. Would
probably be an idea to update the docs with a specific comment
for this case I am not sure that is as obvious to me as it was to
you, and it is very common to be reviewing a part of a larger patch.

Thanks,
Charles