From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 31635C4451B for ; Fri, 17 Jul 2026 16:06:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=BTNiDs+YQP5gErq+/6PIKAwZFcni80aDhJBtKwTwBbg=; b=Tq7zkzI/pB3mo1gScMnH+GmqVU fzwy2eMO/Z5geKJQIWdgRPTt7xs01ZgMhdQnLxr0tSbIfoUCvZQIxeNsM7U8XY42CyEJCzIi8XhPh CTo4hClcZBcfRHlD1gOiZh1m+s1Bz1lORynBm2bzp/HtATigKp4n2EUlkZO6d8lmaALV2vUGABdRL wPDR04la6M44N6wJF4bMj7mTHdMqhOxHEe5sEOTvQcDKPjLlJoXWS6r2kNVH0vWqmyO5c0kMq4aec 6uyvMWfRmzTcjoAd6Zl39k1Y3QEynWCkrWwWFyrVyUXRoXYuFnUQDY3lIz5P7MBSku7pLe+pycyxg DXh9HCFw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wkl5L-00000002hfy-2j7g; Fri, 17 Jul 2026 16:06:47 +0000 Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wkl5J-00000002hey-3IMk for linux-mediatek@lists.infradead.org; Fri, 17 Jul 2026 16:06:47 +0000 Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-493b966dd74so32793485e9.3 for ; Fri, 17 Jul 2026 09:06:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784304403; x=1784909203; darn=lists.infradead.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=BTNiDs+YQP5gErq+/6PIKAwZFcni80aDhJBtKwTwBbg=; b=l4P1/QkK4M2tCapXMyps7xxxTCnfeulxZWzD/gIgbzBw+IcG1npaYPS0bSUdRb9nYU zLsIRarwqfkhlz8dcRma3zC0tnJjh+4VyWUbz0AMwN9qn+VLmSDYNOpmWluxCAF2Wvje +sKR7negDiIbCRb1ZZaLR97e0Y3d9G0A2FeB9I75U+5iRD6aik4ICtzq815gTxDtebS/ dxltXK+y0zZqHsZozZhmb9kuTwcEITuAbcIHl92KjHa29RpekDDRwABxIjFUXglnfYE4 He5v1MyabYNPPgoaFvXp09gNxwEMARobmfoOk8PeKzrIHUd+xbZqL37xURgBRxwXRaka oa3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784304403; x=1784909203; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=BTNiDs+YQP5gErq+/6PIKAwZFcni80aDhJBtKwTwBbg=; b=Warno8QAnRs4APal+32t9a9umGJ0ZAdUufSKS1GPHZtrs9mLb5vqa0SeoC/T2U/tFr 9wAebZphVsf+qjxUX3uSBwOBXLeKVCy/51Fp00OElHeZYozuYlG3v62jaMjgHZek4qHO Nb/mmr1TenwAmg7dYWc66oKYELQvH8JKLRMCRSOuwibFX3kMiWvz/BkNWHz2/dU9VobK kdoSvnoHI/0YKxgJYnzeKQFMYyks6NnpkbD4xTm+SFM3No9lwFoNHcRA2pIEPv4Yvk09 SIAzFQ/lGQOZHQWwayO20hnvV84paoqjlEW/psPik84F1z5xGifoV8ZpSzZZeMLme+J5 Mmkg== X-Forwarded-Encrypted: i=1; AHgh+Rqj3IuaXZbWVrdk1vwjHqPi8FK3OZAXjJvT/i93eTUqdn2Q+ZOoQo+IY28VBOM1R7QUC/2sadQI34w8mmepeg==@lists.infradead.org X-Gm-Message-State: AOJu0YxUbVqZ1WVIfXOUnMNZbD1U/dn/nCIuS2Jjeku5fcV5PBTTncmK hmyz9DL/Rcgm4RSbIutdSjHACbRI4ZvIOWjcuMi1EKj5prdbjmk84f5v X-Gm-Gg: AfdE7ckpcT2Bja0Vo+35y/e1f18nQ5K0pNjxFgWzOcn/GTx60X/Kl7XQYjoQIdW43wK 89SWvJ0NmL1esMtseG6foBHZS0Tolz+Cw7LYvKJxdiOF+a58gUT9BuRHcyUNtLFWllAEpBrl6iG EqRA/sX2xa+mKDjWR2OWmkzOaietndRaoiDhnv2uWZ4nOocE5E74VfHNmWup/eGbfSmhVwec38A HjgwqPoFO9Ld4Z8l1v6okDgC/rmS6qdUl0OmcsxdUb/WLb5aOYVWGRoqfuyqPW3YNgWGnEIIQjn 8b5WX+LhnKEBAKhvdLZZSFGpOcjD+y/ykuNs7+KEJUxjOYVoqjw7gFYpb7D05Dz/DHl8UybACUP a9r9XV6k+lcwOxIHe6vaHIszdOJuODq6Uon7t03RwqOmdPWy90x70it8j8VzYed2K2At9+bBMDA == X-Received: by 2002:a05:600c:4453:b0:495:4f62:1ff7 with SMTP id 5b1f17b1804b1-4954f622066mr5214955e9.17.1784304402908; Fri, 17 Jul 2026 09:06:42 -0700 (PDT) Received: from owl5 ([2001:861:3201:3d10:d4b8:8874:bdef:21b2]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4954ba2abd0sm37795105e9.15.2026.07.17.09.06.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2026 09:06:41 -0700 (PDT) Date: Fri, 17 Jul 2026 18:06:40 +0200 From: Gary Bisson To: Esben Haabendal Cc: AngeloGioacchino Del Regno , Chun-Kuang Hu , Philipp Zabel , David Airlie , Simona Vetter , Matthias Brugger , dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Adam Thiede , Thorsten Leemhuis Subject: Re: [PATCH] drm/mediatek: mtk_dsi: enable hs clock during pre-enable Message-ID: References: <20260120-mtkdsi-v1-1-b0f4094f3ac3@gmail.com> <8733xko1ms.fsf@geanix.com> <0f719c00-3cf5-4403-afbf-713b07255981@collabora.com> <65558ccc-4f2c-492d-8c74-627d27dce864@collabora.com> <87h5m0mkca.fsf@geanix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87h5m0mkca.fsf@geanix.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260717_090645_859995_1B3B5D92 X-CRM114-Status: GOOD ( 25.40 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hi Angelo & Esteban, On Wed, Jul 15, 2026 at 03:52:05PM +0200, Esben Haabendal wrote: > "AngeloGioacchino Del Regno" > writes: > > > On 7/15/26 15:36, Gary Bisson wrote: > >> Hi, > >> > >> On Wed, Jul 15, 2026 at 03:25:11PM +0200, AngeloGioacchino Del Regno wrote: > >>> On 7/15/26 14:53, Esben Haabendal wrote: > >>>> Gary Bisson writes: > >>>> > >>>>> Some bridges, such as the TI SN65DSI83, require the HS clock to be > >>>>> running in order to lock its PLL during its own pre-enable function. > >>>>> > >>>>> Without this change, the bridge gives the following error: > >>>>> sn65dsi83 14-002c: failed to lock PLL, ret=-110 > >>>>> sn65dsi83 14-002c: Unexpected link status 0x01 > >>>>> sn65dsi83 14-002c: reset the pipe > >>>>> > >>>>> Move the necessary functions from enable to pre-enable. > >>>>> > >>>>> Signed-off-by: Gary Bisson > >>>> > >>>> Hi > >>>> > >>>> I have run into the same problem, but in combination with another > >>>> pipeline. I am seeing same problem with an i.MX8 using the nwl-dsi > >>>> bridge and the dcss driver. > >>>> > >>>> I have submitted a fix that adresses the problem in the ti-sn65dsi83 > >>>> driver instead. With a bit of luck, it can replace the fix proposed in > >>>> this thread. > >>>> > >>>> See https://lore.kernel.org/all/20260711-ti-sn65dsi83-fixes-v1-2-d85eb5342b98@geanix.com/ > >> > >> Thanks, just tried it on 7.2-rc3 with my patch reverted and confirm that > >> it works too. My assumption was that the SN65DSI83 was locking the PLL > >> earlier for some specific reason and therefore was reluctant to change > >> it. > >> > >>>> /Esben > >>> > >>> That clarifies a lot of things. > >>> > >>> The patch on mtk_dsi shall be reverted then. > >> > >> Angelo, do you want me to offer the revert patch? Should I wait to see > >> how the other thread goes? > >> > > > > Gary, yes please, send a revert and make sure to explain the reason why > > we're reverting this in the commit description :-) > > Maybe test if my fix actually solves the problem with the mtk_dsi driver > also ;) As mentioned in the other thread, your patch works but it might break the init sequence recommended by the bridge datasheet. Moreover, the drm_bridge.c doc [1] does mention that the clock lane should be initialized during pre_enable. If we agree on this assumption I believe my patch should not be reverted. Maybe Adam's bridge driver must be patched instead, just like the nwl-dsi driver should be updated to follow the drm recommendation. Let me know your thoughts. Regards, Gary [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/gpu/drm/drm_bridge.c#n169