question about drivers/dma/mediatek/mtk-cqdma.c

From: Julia Lawall <julia.lawall@inria.fr>
To: sean.wang@mediatek.com, vkoul@kernel.org, matthias.bgg@gmail.com
Cc: dmaengine@vger.kernel.org,
	Nic Volanschi <eugene.volanschi@inria.fr>,
	linux-mediatek@lists.infradead.org
Subject: question about drivers/dma/mediatek/mtk-cqdma.c
Date: Fri, 8 May 2020 23:57:17 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.21.2005082352340.6525@hadrien> (raw)

Hello,

The function mtk_cqdma_find_active_desc contains the following code:

        struct virt_dma_desc *vd;
        unsigned long flags;

        spin_lock_irqsave(&cvc->pc->lock, flags);
        list_for_each_entry(vd, &cvc->pc->queue, node)
                if (vd->tx.cookie == cookie) {
                        spin_unlock_irqrestore(&cvc->pc->lock, flags);
                        return vd;
                }

That is, from a &cvc->pc->queue there is an iteration over elements of
type virt_dma_desc.  But other uses of &cvc->pc->queue, such as in
mtk_cqdma_is_vchan_active, seem to indicate that the elements of this list
have type mtk_cqdma_vdesc.  It is not clear to me how the body of the loop
should be updated to account for this.

thanks,
julia

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek